Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp1095140rwb; Thu, 1 Dec 2022 12:17:41 -0800 (PST) X-Google-Smtp-Source: AA0mqf7eGUGz5XiiTgVBI5Dt0xlYJdZHcfABDd6zagmllu9aVnh1ABM62l0TnGQhot1S+GtDUiSJ X-Received: by 2002:a17:907:a709:b0:79f:cd7c:e861 with SMTP id vw9-20020a170907a70900b0079fcd7ce861mr56061016ejc.339.1669925860857; Thu, 01 Dec 2022 12:17:40 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669925860; cv=none; d=google.com; s=arc-20160816; b=h/W5baBdDY57O2nJUW3kmZ5j5DiRhGkCx3X7WbrOMt21IXImsu7jF2Tm3G7+3zT86A WpJ9EABC6hyJH6a8RqVjuCn0AjfscGpAbgeKuxuVgOn73b7vyW0jaPc7l0bolE+fSRWY nMgPUgvUu7OtPRkNL2HaYeP1z7gX0DRxsBg0dqlsCqf05lkPfUAaoBgDMSpswB3+aZMU uBulgrdK2kyl+rLvdy7dmNfvG1Qg8WMgRHIGRmnCcOfByHTQ4wjDuTGNqLfN/nV9UCqv e0UnCbfTp68mitMdY16EdRBWHDvPXbLMBrluVphd96nWlY5XxsYp/9+AJC4u7bXwGp0e lYKQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=5BHelv3N+41uf2laSJpjxNnqMJlO6nXbKkfIvjH6bF0=; b=BI8HtuHCSva0uRvcW0WDXqluQHV+n6IDTrk/9ng8XDTfqvwtximcfbITFITPbofTFm 7h8BmNi2S7l68zybQweHHsWM00oEbWI1mjSEsCir1EBVm+8SdSthtE24O6QHoFeSRCzg uUiw8GZENu5KXAAb8+SCvNVzfwoqr0VxSdRdsPiQnzNyfe0LqclHTKUIga7wpt+cDn/O nCpj7WOMLB1K9F6I10lhvbI/PoQ9IJ3KTXW9o77NtDnOR6lddJxkKShXb0yrtxmtlKV0 ZWtMXambTnVzxuO+0OhlCrSiEd61BOyY/NCply7l18k/VyTgUt3wYaigvVXMvylqwhx9 /IGg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=mNabccta; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id eb5-20020a0564020d0500b0046baedff35bsi4699626edb.291.2022.12.01.12.17.20; Thu, 01 Dec 2022 12:17:40 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=mNabccta; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230478AbiLAUKi (ORCPT + 81 others); Thu, 1 Dec 2022 15:10:38 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41184 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229653AbiLAUKh (ORCPT ); Thu, 1 Dec 2022 15:10:37 -0500 Received: from mail-qt1-x833.google.com (mail-qt1-x833.google.com [IPv6:2607:f8b0:4864:20::833]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AA82FBEC68 for ; Thu, 1 Dec 2022 12:10:33 -0800 (PST) Received: by mail-qt1-x833.google.com with SMTP id r19so2357417qtx.6 for ; Thu, 01 Dec 2022 12:10:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=5BHelv3N+41uf2laSJpjxNnqMJlO6nXbKkfIvjH6bF0=; b=mNabcctar8gTptAWFv2qhOoG6jR3HGKA09XMyZgezk74MidRGCgacejr1mVfybneYi LGwixB3c7ahYtBDjCFXzcFSSb2OCsoJ68ibVHMcIHuAHvGQqkB2viOrdeVlg+RzDP31j 6rzdkiEzi0902yFRNWpNNhTFw0rneMKbSH+6Q= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=5BHelv3N+41uf2laSJpjxNnqMJlO6nXbKkfIvjH6bF0=; b=aLbHQUod96xHW2gXko9ALSQotW/4AVIqk+9BYC9z7AfTGLeGbo1m706+L3U+4FJwn0 dz29hbLl1K2eXPgJuZD7gPfz3aPhoHy635Q6IQMA/IVNg5duyN/EgHcwVlGlXsPQvZJ/ Vp7tqepsHrrju2gk3RZxO87GHtXTh2sFKUuKoK/iFi9swvlFaPBDIV/LO5/+l4kPrHrH a4Hm6Bv6Q9VflNkLa64e3+2Yy9eb7tjDRqtA3SlqsAWAi5zrDbs2NEb4Axfmy8vriNbM qou7xPR3QJ9ec51h+cqoAQayyY29mo9euUlqiXG7X9hQpCQQsptwOgyHtvth8Yo3+OkH gbKA== X-Gm-Message-State: ANoB5pk8uAh0Nu0TaX+nQ5MD+qzPO70oR2sgboSfkxy8e4/aM3W5Y1Cz QKtNj47k3l9iyXzKgKLei7U4dtT7HKzIez9YuNduog== X-Received: by 2002:ac8:4a13:0:b0:3a5:b4ab:cb80 with SMTP id x19-20020ac84a13000000b003a5b4abcb80mr37195576qtq.59.1669925432860; Thu, 01 Dec 2022 12:10:32 -0800 (PST) MIME-Version: 1.0 References: <20221130231936.1666390-1-wonchung@google.com> In-Reply-To: <20221130231936.1666390-1-wonchung@google.com> From: Prashant Malani Date: Thu, 1 Dec 2022 12:10:22 -0800 Message-ID: Subject: Re: [PATCH] platform/chrome: Create new USB driver for RGB keyboard in ChromeOS devices To: Won Chung Cc: Benson Leung , linux-kernel@vger.kernel.org, chrome-platform@lists.linux.dev Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Won, On Wed, Nov 30, 2022 at 3:19 PM Won Chung wrote: > > Without any driver bound to RGB keyboard, it may not be suspended > properly, preventing USB xHCI to be suspended and causing power drain. > Create new USB driver for RGB keyboard so that it can be suspended > properly. This seems like overkill. Can't you set this from USB's sysfs nodes like power/control [1] ? [1] https://www.kernel.org/doc/html/latest/driver-api/usb/power-management.html#the-user-interface-for-dynamic-pm Best regards, -Prashant