Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Sean Anderson <sean.anderson@seco.com>
To:     Andrew Lunn <andrew@lunn.ch>,
        Heiner Kallweit <hkallweit1@gmail.com>,
        Russell King <linux@armlinux.org.uk>, netdev@vger.kernel.org
Cc:     Eric Dumazet <edumazet@google.com>, linux-kernel@vger.kernel.org,
        Paolo Abeni <pabeni@redhat.com>,
        "David S . Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>,
        Sean Anderson <sean.anderson@seco.com>
Subject: [PATCH net-next] net: phy: swphy: Only warn once for unknown speed
Date:   Thu,  1 Dec 2022 15:22:53 -0500
Message-Id: <20221201202254.561103-1-sean.anderson@seco.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?AmehDJfGeZPakyMWut9FpDNXXAS8XH4vky0zA/YlRLWxgsEH5LNpxLJzfkjU?=
 =?us-ascii?Q?hjfH1TQ0nTWIWFlz0KKLwZcsxYBBTveISFflIRiehE5TaTAZP9MqoiVYdpMF?=
 =?us-ascii?Q?/O+xaDTC4RhFZPZGSQ2kbBFR6qlEWsVAiasXlsLKpwREDNiD3HeQCtc7YFAt?=
 =?us-ascii?Q?xvu9qYw7MtK04Pe+xSE5+rvYBHcqYCn/mxF9qo5BwLpnY9bIyHG+qf8xynGL?=
 =?us-ascii?Q?BxLAuWMFMJnG6h0g+sZOBdOwCniWxNeoNy46dPTX2kmpgGW1oexl+QwF/TZy?=
 =?us-ascii?Q?YKc5XcNpHu4QOSKVRd6dUT+SPlpLbnsTy+KC0iKev99kYbjBcwqWkySP/9vN?=
 =?us-ascii?Q?f73FGmMCiyZOh0CBKq1Z7U8MPPPEO1Frw2aWUEftyMTrXaZCWUqoSiM8xmQt?=
 =?us-ascii?Q?iE4IQL44XVAAm0PmZKa3z/MRRyQNsrPktXPVxUt3baEyB+efBLR2DwXNptsS?=
 =?us-ascii?Q?ngkt8ERXBxX/wYR+Aa1QAf104eKAoM0CgEP0HIX3los7ZD2FREUGPjPeaBan?=
 =?us-ascii?Q?tQNKumY+mvCC6ZUYZ8U5qygYLOrXxepenfl2AUOb3hKMXTyp8OfYTc523l4J?=
 =?us-ascii?Q?SRJ+3V/r7+pglxHJlNj6zNrTWCg4E9N76Zrw5R2B8RlAnRNtdjXQK3PuEbIb?=
 =?us-ascii?Q?d0ZzdgurBry1gxsdjoYaPNckaVFH4VMpHYh0C/Mb5Q5Os/y8jpnaXbttqH80?=
 =?us-ascii?Q?/p96yNJDBxXxguuPpJL3zzRa2YMU0WaJnmOBbwrYhD3lt8Y+TnPKnHXsd3Dm?=
 =?us-ascii?Q?tEywF8mhUHyN+ACrH1L71IEtGAFd2jntsFUruRu/KKhAFAn99Mr5hKV3e8ik?=
 =?us-ascii?Q?9X+AAJ2mO69AIXfz8lGirSv/0lu/8BBENPfqCB+j/mqpfZbDuk05I5Ljw7ne?=
 =?us-ascii?Q?g68xj0stTVh3um+/z360mzLSIpnVn2cR+239EDyikw/uNd21FvAWi1g2OSMi?=
 =?us-ascii?Q?1hCW2lGxYKZU2KtLNOhnb9vFNq//axst8nwzw9NLKAk5AfNkTsgv8s8giWac?=
 =?us-ascii?Q?O5hb0gt/kVeC6lob+RAfxVay6KpFAccK95zm6+oHo+8pU5QjA2/BE9QGtxRN?=
 =?us-ascii?Q?Y6G1GEKRT6BurO/zD7811hosq0i68J6XSoollyqmOwlYrPUX47C4OdHQ+zwn?=
 =?us-ascii?Q?Umk8/BnXb12FYwTTvy7DAhZqaaKc7pV3NdYRCsr7zYCvj7GqyPLuAb5OH0vY?=
 =?us-ascii?Q?nUz7UrsqybS+oCN0PN/Ob5x2E7lZwJK52Q1N6P2Slt8om7/TrtOiVrZ/OIBW?=
 =?us-ascii?Q?F0ebfW/bw9+rsawAFzJHuDjbTEwvv3quRkSd3GWYDmK6CUHlFvYv4ETHBAez?=
 =?us-ascii?Q?j3/cSmgdNfSZeq8nqDjpZje5Uvd6gHKq51hTeFRLkIu7juY7FJssSVx5JwVL?=
 =?us-ascii?Q?lcxZw50yKI00yOx1sjh1PtQEX4w9nNerDulBR68t+tWvJjxM931Yt7tkYAgN?=
 =?us-ascii?Q?kERO2DG//4nJOSSHp3JyGL48Wj6cIN7qN0wvzV1PuvZGQcY2liqBdZt2dTGq?=
 =?us-ascii?Q?mr03UPDo3svaEq0Ky5lvWu5+XlhLlfXej7USGknVF7ZwMQ1GyWIBW3FTdK+6?=
 =?us-ascii?Q?A1fjmIn0bjhzmgveN/gY0eYJCCyWpUlUgbWAr7ajbDDD537pjEobAa3/jMWj?=
 =?us-ascii?Q?4g=3D=3D?=
X-OriginatorOrg: seco.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0d5c4434-1d74-41f2-8231-08dad3d9de35
X-MS-Exchange-CrossTenant-AuthSource: DB9PR03MB8847.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Dec 2022 20:23:13.4040
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: bebe97c3-6438-442e-ade3-ff17aa50e733
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ytGh1Os77VuK5iZKpvUB6eT37mtZPbIpLnwwH4LNrxc3tmcrC8ZZoS62Mvs8KTKNW82jVowI6fyWQdN5R43/uw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS1PR03MB8215
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

swphy_read_reg is called quite frequently during normal operation. If an
invalid speed is used for state, then it can turn dmesg into a firehose.
Although the first warn will likely contain a backtrace for the
offending driver, later warnings will usually just contain a backtrace
from the phy state machine. Just warn once.

Signed-off-by: Sean Anderson <sean.anderson@seco.com>
---

 drivers/net/phy/swphy.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/phy/swphy.c b/drivers/net/phy/swphy.c
index 59f1ba4d49bc..9af155a25f23 100644
--- a/drivers/net/phy/swphy.c
+++ b/drivers/net/phy/swphy.c
@@ -124,7 +124,7 @@ int swphy_read_reg(int reg, const struct fixed_phy_status *state)
 		return -1;
 
 	speed_index = swphy_decode_speed(state->speed);
-	if (WARN_ON(speed_index < 0))
+	if (WARN_ON_ONCE(speed_index < 0))
 		return 0;
 
 	duplex_index = state->duplex ? SWMII_DUPLEX_FULL : SWMII_DUPLEX_HALF;
-- 
2.35.1.1320.gc452695387.dirty