Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <ce7e62fa-5b5a-66c6-2154-31f99e9dfaca@intel.com>
Date:   Thu, 1 Dec 2022 12:25:32 -0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Firefox/91.0 Thunderbird/91.11.0
Subject: Re: [PATCH 4/4] firmware_loader: fix up to_fw_sysfs() to preserve
 const
Content-Language: en-US
To:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        <linux-kernel@vger.kernel.org>
CC:     Luis Chamberlain <mcgrof@kernel.org>,
        "Rafael J. Wysocki" <rafael@kernel.org>
References: <20221201193057.1195255-1-gregkh@linuxfoundation.org>
 <20221201193057.1195255-4-gregkh@linuxfoundation.org>
From:   Russ Weight <russell.h.weight@intel.com>
In-Reply-To: <20221201193057.1195255-4-gregkh@linuxfoundation.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QndwV0tkTlBNcENvL2tzZTRCVTY1c0VKeDk0ZjdLT1o2YzZHUlJ3RDRLRENQ?=
 =?utf-8?B?WlBnS01yNXZPaCtwbVBFbUZLRUlBaEw2dmJDY3BkdG1lenpuVkg4WHVlYndC?=
 =?utf-8?B?TlVBdVU0NlFvWFRkOFpEdzZhbjU4V012NWZjaVhjY0pqbGF5Z3VicnM1a0gv?=
 =?utf-8?B?dGFSS09DTkt5Z1o1ZmM1ODh3SEV5Wlk0R0xWbDBGbnJ4Z3RxcmR3MnhHbWtl?=
 =?utf-8?B?c3pZenY1U0NlM2FSZjdlc1dmazY1eHZMQzNMaWRDdWtzdmhlOVpQN1JNbit3?=
 =?utf-8?B?bGphRE1QRXl6Zm9jT3d1d1IwemtzRGdJYys5MkZZMGY1eThmNXhYTU9ld21T?=
 =?utf-8?B?bkp4emtHRnNPVkpoV096QnZpT3Y4YlFGYUhYZWdib0pQNUJJcTFpVUk3OUdt?=
 =?utf-8?B?cjNRL3lXRjZQZU1HMXJHU3RGVlNsZHN6QWpRdG5BbWNCTXpBYlNJNWJzK2hR?=
 =?utf-8?B?WkhQSlZCdWhCZmpNajRyTm82TzlNR3N3QWdGcmZLRkdCU1RWZi9YY2dxNGdM?=
 =?utf-8?B?dmQxZWpCTWN0ZTFLRzQ5VFhMc2FuQjRMcnN0dnZ0alhYd1IrOTM2RVRJbGRz?=
 =?utf-8?B?Z1JzcTFpc29KUFZheVQ0akRrL0FmT2orMy9SZ2FZNGhUYmxuZGp0MUgySld5?=
 =?utf-8?B?OGdJenFUVXpLSm1xcldTcWxLRGl0U2E2UDNHcndzWWhyZ2RuTmNKcjBJV1VU?=
 =?utf-8?B?ZnlnNTFGS3BWWXhlVTBibnhKdjkzcmFqeFo2cVVxeXh4T2JaeXY5WDhRRVR3?=
 =?utf-8?B?aG9hM2ZybXorOGNOMEdmMi9YSWlVckpHME5lbmdUR1R2Z0c4c3VJNGVkN1Fl?=
 =?utf-8?B?Q1NCQlB1NVBUWlNjZ0QyNDBoQy8vcWdyMlVzODVEYUVHKzJzYVFBUGtSb2d0?=
 =?utf-8?B?WElZSnA3Rzh1NVhicXYyc2xFeTkvd3Q3enN3Z0JhYmNpMmtuekd1TXJRclVP?=
 =?utf-8?B?Q3Y5cHVGd0Zxd3JiWWdSNDJPVStwNWVRMm9kREU3WlAvV2RQVUZHd0Z6TVBs?=
 =?utf-8?B?elFaSWU4VkxuQWxmUFNwOFE0KzM5bUl2bVA1NjIwWFhIVXFtYXBERkIrcDlv?=
 =?utf-8?B?clI2MVVuR3crcFRwbmo3OVdKODl6cXQ0U2EvSFFzMjRPZi9GdjNDUXdGOExQ?=
 =?utf-8?B?V3FvejRaNlBqM21WMmd5Mm40b2h5UkUyQmdQTGVPeVY0SEdxNis5QWNxN0Nq?=
 =?utf-8?B?VUV2OGN6YndlTzhITWNGM01FWVBUR0w1VDdPUjR3UWl6T2ZWOGtRbVlQcDVx?=
 =?utf-8?B?SE9nWWEyTUFmazNKQ2RmRGppd2VMZlNIZ1JkQVlzMEc1ZU1pMTFzWmxHL2s4?=
 =?utf-8?B?OW1UWVJMWlJrUDdmaG9uR3JQN1FSUXl2YTJSVlgvOThGVEx5VzNQL2sxVWN4?=
 =?utf-8?B?NzZXazJadXJOSlJTK3BjYmVUSE5CZXRhTU5HY3E0b3F6SXcxdmJzemI4MGF6?=
 =?utf-8?B?ck9mZElxZitXNCszR2p5NmJYKzZFSWUyTmdWd0c1MzBjUEhoMC8zaGdBL0ZM?=
 =?utf-8?B?enIwM0NtUkRqT0xvMzl1OWFkWk9DK3lvdSs4Y2g3MlgzUWI1TGZUN2REWXdv?=
 =?utf-8?B?bkFLUGhwdXlueCtzTkw2c1VtdW9tWWt3ZDZJNGN2Y0QrdFJCMjlnK1g2SVY1?=
 =?utf-8?B?OUY3VnRFVXduaHJ6N2NRVFFJOHhUU3lIa00wZ2YvY282UVJ5aDN4Z0pFeXZn?=
 =?utf-8?B?aE1Mc0xFUy91cGsydUErSEVzek01VSsvbWJGZjVQa2x4Skd1NDJSaG8wYVZh?=
 =?utf-8?B?UWZ0UGEySWdLb3d5dkV4eE40dHRSc0N2andZZXRzeG5rUndZRmprY3NBT3Jx?=
 =?utf-8?B?ay95aDd0bkRoM09BVUNCM2tGeWM1dHlUU1dtMXpqTkFZVlM3bGhpOFdwWTRi?=
 =?utf-8?B?N21qNkdsTUJtVDFNZzNNTC9tNDNaMTRZbEFkRDNWMHd1NkVZdHpRb0luNVZI?=
 =?utf-8?B?VExsa0lwYUZCcUlMNnJIWThpODR3UThPNVNZVWxnaGQ3dmlTcGQ1UjFqU1BC?=
 =?utf-8?B?VmYwRzV2QUx1QWlHV2IvN1NYT3NyMW93a05NSzlmTXZwaitqUnhuL0tzVEtY?=
 =?utf-8?B?RGhJRHZldXhCMEZUd29zQ2dIWkhtbWZqTGhTZHZnWHM5QklaMXVnMVRtYmpv?=
 =?utf-8?B?bXYyZlNwZ0N5Uktrd2k5cnNDQ3VKQlRHeThIb1F4TTFqNlRPVWozQklTdWE4?=
 =?utf-8?B?ckE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 90a41d1b-6bc2-4ab6-36ee-08dad3da33ff
X-MS-Exchange-CrossTenant-AuthSource: DM5PR11MB1899.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Dec 2022 20:25:35.7385
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: HJiJ4djHs0dNvQEaTGP8INIDuv4HZr78Xx6IJliDK79gEcncUEYv/66xFBFwuvD01tcXtRJfQLAsjZtgQ4MQMThDEyx5TGWYtezNK3g8QlI=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR11MB5553
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 12/1/22 11:30, Greg Kroah-Hartman wrote:
> to_fw_sysfs() was changed in commit 23680f0b7d7f ("driver core: make
> struct class.dev_uevent() take a const *") to pass in a const pointer
> but not pass it back out to handle some changes in the driver core.
> That isn't the best idea as it could cause problems if used incorrectly,
> so switch to use the container_of_const() macro instead which will
> preserve the const status of the pointer and enforce it by the compiler.
>
> Cc: Luis Chamberlain <mcgrof@kernel.org>
> Cc: Russ Weight <russell.h.weight@intel.com>
> Cc: "Rafael J. Wysocki" <rafael@kernel.org>
> Fixes: 23680f0b7d7f ("driver core: make struct class.dev_uevent() take a const *")
Acked-by: Russ Weight <russell.h.weight@intel.com>
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> ---
>  drivers/base/firmware_loader/sysfs.h | 7 ++-----
>  1 file changed, 2 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/base/firmware_loader/sysfs.h b/drivers/base/firmware_loader/sysfs.h
> index fd0b4ad9bdbb..0f0b1f7bf335 100644
> --- a/drivers/base/firmware_loader/sysfs.h
> +++ b/drivers/base/firmware_loader/sysfs.h
> @@ -80,11 +80,8 @@ struct fw_sysfs {
>  	struct firmware *fw;
>  	void *fw_upload_priv;
>  };
> -
> -static inline struct fw_sysfs *to_fw_sysfs(const struct device *dev)
> -{
> -	return container_of(dev, struct fw_sysfs, dev);
> -}
> +#define to_fw_sysfs(__dev)	\
> +	container_of_const(struct device, __dev, struct fw_sysfs, dev)
>  
>  void __fw_load_abort(struct fw_priv *fw_priv);
>