Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp1190387rwb; Thu, 1 Dec 2022 13:45:35 -0800 (PST) X-Google-Smtp-Source: AA0mqf73PzrcC9yaIe1sB1+YSujbo44BqUzZZ2kh/O3p6IerhDC6s6N1PYc1JFZmLGJlIGV3ofYb X-Received: by 2002:a17:903:28f:b0:189:8a36:1b70 with SMTP id j15-20020a170903028f00b001898a361b70mr23460645plr.12.1669931135600; Thu, 01 Dec 2022 13:45:35 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669931135; cv=none; d=google.com; s=arc-20160816; b=U6+n0CMSnhpOoa6BZO0p7fskS2olllgPt21/dfYSwlmIxEIrIcJ7FLHrAFcCfJEojt EH9StVK0fKd4GYsCJe4Jrt1FzA456BLYV8FzsfjsLGLUvg4brH+QqI2V4wHu/qsDeKw0 qjaC0GYnkBB0eho6bgcv7ppI3VFUW0toayD8Isa+fzi6XwuJzxYD6R0xvQs1Fg/bTo8g FO2qoFagYQPhxWvxXxoG9gLXstmfVMyEXy31q2jV637arY2aipmmnIr16mQPKm4ScibG bhDXqxW69eMtvBG8QDq+7tDXNc5ryJLxI2HrQdQ7O0cCkkK0+/qUyvjMJX9RmWOf14y7 6tBw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=vQXrnuAXhg6yJI2MI1PAeXCG7Dsb9welVCKSjTPejcQ=; b=B9dMngQ3z+kFzQMPmUYZvuyLO35K2ZoCZxR5drZui1dySqyEglidqV6JnX4I9sBuuI olDsEYVekwjirT+laP+rIXBmjhaZhuHFR+RsQDxGxzKCqR6zpSX380Ag6Rjncm03JhMQ zz+aW7GdcI235pQ717ioB6Hv5a+N2wn9MpmQuiO2q688m3okyUeHAjMVfcDZy6dTCsvw J5j3fODUsS5ygPta+Z2CxYVAM70Mm6A52eQwYsjnr11f7lBZDHD1w1YFP7rd8pkPytOI /gD/s6Jc1xBuUikG5bmRtlYvRcFwATvUTtrjZGuegYVpsIjo5M71n7t/WJmoxuZSc7Wp 4q/w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=korg header.b=T7mbNDNb; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id iz17-20020a170902ef9100b00189812f489asi4887168plb.155.2022.12.01.13.45.25; Thu, 01 Dec 2022 13:45:35 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=korg header.b=T7mbNDNb; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230401AbiLAVMv (ORCPT + 81 others); Thu, 1 Dec 2022 16:12:51 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34588 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230427AbiLAVMq (ORCPT ); Thu, 1 Dec 2022 16:12:46 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 88F7EDE98 for ; Thu, 1 Dec 2022 13:12:39 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 77301B82027 for ; Thu, 1 Dec 2022 21:12:38 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A0BA3C433D7; Thu, 1 Dec 2022 21:12:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1669929157; bh=ESBUZqzGtDNUEoKoNhyM+rRWNZFT5fSTe1bIeGft5mY=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=T7mbNDNbr172q4ma/Sih0o5jrItD9Yn3CVYnvaTzID/eAQctFnUyb6dnP2mNOtrmW jqJO7U+qc0FJDRB5tNtbZM2R555R8HX2FQqsuxfxD/CZkwKfpNfIpJb6AKW9DgHKNy hu2wbhOXp4DA1ZNJpc2FZUkjWfzpzp+wfmY0EqBo= Date: Thu, 1 Dec 2022 13:12:35 -0800 From: Andrew Morton To: Alexei Starovoitov Cc: Chris Mason , Steven Rostedt , Borislav Petkov , LKML , Linus Torvalds , Masami Hiramatsu , Peter Zijlstra , Kees Cook , Josh Poimboeuf , KP Singh , Mark Rutland , Florent Revest , Greg Kroah-Hartman , Christoph Hellwig , Benjamin Tissoires Subject: Re: [PATCH] error-injection: Add prompt for function error injection Message-Id: <20221201131235.06ba19ee600b2424e97d9c55@linux-foundation.org> In-Reply-To: References: <20221121104403.1545f9b5@gandalf.local.home> <3fa8ec60-dd96-c41f-ea46-8856bf855949@meta.com> <20221122132905.12a8d5ad@gandalf.local.home> <20221130143719.07e36277d1471b83e9a1b627@linux-foundation.org> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 1 Dec 2022 08:58:55 -0800 Alexei Starovoitov wrote: > but the better option for now would be to drop this patch. > For the next next merge window we can come up with alternative way > (instead of ALLOW_ERROR_INJECTION) to mark kernel functions > purely on the bpf side. > I don't think we have time to add this marking infrastructure > for the upcoming merge window. OK, thanks, dropped. Let's revisit this next cycle.