Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 1 Dec 2022 22:57:24 +0000
From:   Mark Brown <broonie@kernel.org>
To:     Doug Anderson <dianders@chromium.org>
Cc:     Vijaya Krishna Nivarthi <quic_vnivarth@quicinc.com>,
        agross@kernel.org, andersson@kernel.org, konrad.dybcio@linaro.org,
        linux-arm-msm@vger.kernel.org, linux-spi@vger.kernel.org,
        linux-kernel@vger.kernel.org, quic_msavaliy@quicinc.com,
        mka@chromium.org, swboyd@chromium.org, quic_vtanuku@quicinc.com,
        vkoul@kernel.org
Subject: Re: [V3] spi: spi-geni-qcom: Add support for SE DMA mode
Message-ID: <Y4kxVP97C66oi0Bi@sirena.org.uk>
References: <1669713814-28876-1-git-send-email-quic_vnivarth@quicinc.com>
 <CAD=FV=WW-YttMn2+_6MdKwVDQO2stHjiisSdX8vFoOFBMnsjRA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="MCfNU2/ldKjB0tuT"
Content-Disposition: inline
In-Reply-To: <CAD=FV=WW-YttMn2+_6MdKwVDQO2stHjiisSdX8vFoOFBMnsjRA@mail.gmail.com>
Precedence: bulk


--MCfNU2/ldKjB0tuT
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Thu, Dec 01, 2022 at 02:40:32PM -0800, Doug Anderson wrote:
> On Tue, Nov 29, 2022 at 1:23 AM Vijaya Krishna Nivarthi
> >
> > +       if (mas->cur_xfer_mode == GENI_SE_DMA) {
> > +               if (m_cmd & SPI_RX_ONLY) {
> > +                       ret =  geni_se_rx_dma_prep(se, xfer->rx_buf,
> > +                               xfer->len, &xfer->rx_dma);

> In response to v1 I asked if it's really OK to use "xfer->rx_dma" for
> your purposes since it's supposed to be managed by the SPI framework.

> It still makes me nervous to use it, even though it seems to work.
> Since we're using it in an undocumented way, I'd be nervous that the
> SPI framework might change what it's doing and break us in the future.

I'm a bit nervous too - why exactly are we doing the open coding here?

--MCfNU2/ldKjB0tuT
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmOJMVMACgkQJNaLcl1U
h9Dtkwf/dQzK7cnApqI9SmkAIOQ5X0plaNHltBhmjGmnnGvfP9HGSZ7IJ8JfPn+/
KNsxtOLIdjGqCwYdxT9bt5E+UbJ2yjdiObxXRyTHbAWm0K80x3J1FmizLtUUjkpV
7pHystlQj4LEOdAcLGygnHPYGLsyipEvsLnykheTgAm048f5aDneB4DDF14jlYPA
3Y1RXKpDJwCZUpOBHHj0oex4PBl1h1z9iqGQA/e9YRStRJWCNWgZHMdvRZ+bAORA
/vuYYUM4BGpJJQc0nnl5zRHTXGnTo8hxM1tytIMWE2Iu5WtjV9rze3AknVFOiudS
3O5lWJN1Rv8dLrqlpXuWwl7dEGQyJw==
=XeYp
-----END PGP SIGNATURE-----

--MCfNU2/ldKjB0tuT--