Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp1370016rwb; Thu, 1 Dec 2022 16:41:11 -0800 (PST) X-Google-Smtp-Source: AA0mqf4Wo9EaGYZwNQ6a6/ew6c8Z345rWS7Ctd0UacOZn3wBHCTw1dHxmI6rSh7MUBKTY5DinYK5 X-Received: by 2002:a17:902:f552:b0:186:b768:454d with SMTP id h18-20020a170902f55200b00186b768454dmr52388384plf.82.1669941671218; Thu, 01 Dec 2022 16:41:11 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669941671; cv=none; d=google.com; s=arc-20160816; b=cuGzgCQAGy6XZeeTeUutoSWJHu/PULQIpSbQaNw40PmSo/KLGksuD6CnvgNEB7Sa9+ pmPIs6Gv8tZnu626nUs126wsIVRCKrwGgulPdDlYb0NFVJnU+j7qH4Zb5v5mpftCS0ka rHPpU0wY7FZSHi4jS0NP64DMAMPEqYNbcsyrZ4HKSL6bwicn7sxGKoPtcJmkRlrcNN8M QWp8d1V35P1cBiWXfSLSi5mTM8sxUHz/F27iRHkNHGusl51/lW1B0p2p7HwCEYkI5LI1 Vl1HEskeCyxRa/4ikVnCG4MfwFkoqr8MztGI0YsZlMs1lwgeahZmU4GAjfQ/bssZt/9Y E13Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=7NnFjFewjuibKEk2xU+3KbUhw6Lla4EMjf1pe2o8yTI=; b=mIkGmeOALNiMljl+8EqrFcDxWmlgHEWvnhknXZdB9HidK03OLavvQey855sN4IcZTl 5wyLtorCXgAsy5yPZBM1DnKa9/P0q+HxH5NSFCtKdntuwisjD3PHVkG7Jvx6WGVap582 wId2fbsm7aL3iKE3lXXu3tU+mfRzp37ePAbB3aASJBeNCShptkEYhG/fEZkxkZI+ZJri jitjdZXra/EWZddFn93jviMUhZThkNQ8cdyTDwiigofGtcWtjDdkAabJ9UDJ0HJNdf+K vta1f1KCNS1sGCmYUSPlLM/wzFwgeejtPBZy5Vn0tJFvYEjxnlCEsrOa0fY4iuIntvpf TZ5Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcdkim header.b=e4TBayPk; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id l16-20020a170903245000b00174ea015ee8si6587258pls.592.2022.12.01.16.41.01; Thu, 01 Dec 2022 16:41:11 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcdkim header.b=e4TBayPk; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231520AbiLAXyw (ORCPT + 81 others); Thu, 1 Dec 2022 18:54:52 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57882 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229744AbiLAXyt (ORCPT ); Thu, 1 Dec 2022 18:54:49 -0500 Received: from alexa-out-sd-01.qualcomm.com (alexa-out-sd-01.qualcomm.com [199.106.114.38]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4265FC4CCF; Thu, 1 Dec 2022 15:54:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; i=@quicinc.com; q=dns/txt; s=qcdkim; t=1669938888; x=1701474888; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=7NnFjFewjuibKEk2xU+3KbUhw6Lla4EMjf1pe2o8yTI=; b=e4TBayPk0XJoYOQGUKBFP4aqdPrO2PKg7wj0XkBLOBX1Tmjfw2Kj9q9p xdMMMuNi1Zw3GT77E76r/atXk3Tz+0z8gerQyLYRR4Hma196xLmePmrIk sFxnzQVTupXHcLMYpb2Onm4/FLNZUO49MLvW3fHBxTPnB5HiIGv4GdUlh s=; Received: from unknown (HELO ironmsg-SD-alpha.qualcomm.com) ([10.53.140.30]) by alexa-out-sd-01.qualcomm.com with ESMTP; 01 Dec 2022 15:54:47 -0800 X-QCInternal: smtphost Received: from unknown (HELO nasanex01a.na.qualcomm.com) ([10.52.223.231]) by ironmsg-SD-alpha.qualcomm.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Dec 2022 15:54:47 -0800 Received: from asutoshd-linux1.qualcomm.com (10.80.80.8) by nasanex01a.na.qualcomm.com (10.52.223.231) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.36; Thu, 1 Dec 2022 15:54:47 -0800 Date: Thu, 1 Dec 2022 15:54:47 -0800 From: Asutosh Das To: Andrew Halaney CC: , , , , , , , , , Subject: Re: [PATCH 0/4] scsi: ufs: ufs-qcom: Debug clean ups Message-ID: <20221201235447.GD9934@asutoshd-linux1.qualcomm.com> References: <20221201230810.1019834-1-ahalaney@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; format=flowed Content-Disposition: inline In-Reply-To: <20221201230810.1019834-1-ahalaney@redhat.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nasanex01a.na.qualcomm.com (10.52.223.231) X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Dec 01 2022 at 15:09 -0800, Andrew Halaney wrote: >This patch series attempts to clean up some debug code paths in the >ufs-qcom driver. > >Andrew Halaney (4): > scsi: ufs: ufs-qcom: Drop unnecessary NULL checks > scsi: ufs: ufs-qcom: Clean up dbg_register_dump > scsi: ufs: ufs-qcom: Remove usage of dbg_print_en > scsi: ufs: ufs-qcom: Use dev_err() where possible > > drivers/ufs/host/ufs-qcom.c | 135 +++++++++++++----------------------- > drivers/ufs/host/ufs-qcom.h | 11 --- > 2 files changed, 48 insertions(+), 98 deletions(-) > >-- >2.38.1 > > This series makes sense to me. Thanks. Reviewed-by: Asutosh Das -asd