Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp1400666rwb; Thu, 1 Dec 2022 17:12:39 -0800 (PST) X-Google-Smtp-Source: AA0mqf7SHiOw7RGVTk57DXoO7lxCKoW2PqAaFqFy8HxsbHaLl2Y0CDCZuVabPj3dEuzuZWol491F X-Received: by 2002:a17:907:2989:b0:7c0:9d4c:561f with SMTP id eu9-20020a170907298900b007c09d4c561fmr9461262ejc.18.1669943559527; Thu, 01 Dec 2022 17:12:39 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669943559; cv=none; d=google.com; s=arc-20160816; b=iKWo6yDsQq4d9g7uhnm6pWzugMSJNb5rvz7V13V7hb8Hf3fXvUzDR6BsmQKrsOYOS3 IQCoCOgRx6F2koN+1z2rnmspJ5YQwnCDOnjS53XjFmcYJiWIvC/d7j3/9KYQY+oC/CZe i1AYvB7LmwxBZwRKOTo/Murafz9cZQ+TOjq+OsS7/Ye6G4d0nsAkp1DefxMjaFKMHZEZ dgBjpVK4YFdJqm9ahfdxACtyUjfF8lDu43Il6yjbx5sv40sUKeDH9B2/Z2GrcqLHk0mR 3+rk0QQgr9tM5XzN6zRcPHKM3QR2Ifn3mt4eMRB1QqAyIWPqnnXY4TsZkrCK1iRcQ67M bLlA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=7xl+qejN3tIVmJSkrvPgdLgILrBaOoxJHIfgTJ2nuQg=; b=ayGFsNprQw+R3CfoXpmvxB0Ixfw/IzOk6pvNpuzHRrEZ7njg3bmJcUuLWv6JnYS6e2 dmB9XKsweOhbN7+we0so/XOuhGpMPTRoagWlrWXySP2DMhgacLuqEjgmP0v8iDRCc/ch tijWP2lPi+f0t/UYbIlXt1NJwMKensmVQS+l6fPUdco5uKG6Dn0Ky3gtPFx6ak0s7/yu z0urwC4Em17wsuveG4qcV4KsIeXCzjR6oLUNO+7LXuxSKgZuknbNTxZWgJ7lXoyVvI6k pKWT8Im4Lo/Jp4Nx0eNJEc4H4jgE02/NV76JJEWxN4doLRpReLSkzAqOjJRvWhewuE3h yQwQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=U+LyVbbv; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id sg40-20020a170907a42800b007b4d76f5b17si5259391ejc.82.2022.12.01.17.12.19; Thu, 01 Dec 2022 17:12:39 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=U+LyVbbv; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232063AbiLBAzp (ORCPT + 82 others); Thu, 1 Dec 2022 19:55:45 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47452 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231961AbiLBAzn (ORCPT ); Thu, 1 Dec 2022 19:55:43 -0500 Received: from mail-pl1-x636.google.com (mail-pl1-x636.google.com [IPv6:2607:f8b0:4864:20::636]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2F6E8CB20E for ; Thu, 1 Dec 2022 16:55:42 -0800 (PST) Received: by mail-pl1-x636.google.com with SMTP id w23so3236088ply.12 for ; Thu, 01 Dec 2022 16:55:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=7xl+qejN3tIVmJSkrvPgdLgILrBaOoxJHIfgTJ2nuQg=; b=U+LyVbbvc/EqSA7iugywzm78ANe70elPrUE6NMTdrgNZxzrN3L+KXn1dw/OCBzTVZC 1ziu5BU9NNZ4E2l91AsMA/fiQOZTncgXH1a9s7Ci/SxRB1aneAxbUhMBp9Ni35w4S9ez sJ75+Hlki+gge/DYEBT4WOxRPS8Jcf3Y7BgOI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=7xl+qejN3tIVmJSkrvPgdLgILrBaOoxJHIfgTJ2nuQg=; b=EuC2jLXapxbXNZUbrlVgmA13ssOnTwSzQt/A5pgDsT47dRW9F+Q1IUcegG84kpYdkz 4e6MG/zSzKtwXhr6yKRACRJY8C8FsdgsEMyrT6W6fk6Qvw2VFmKiC2RcbR8Yu4QuH7SO 05UvnyQIxRMWaT+lH+Nkm0c9qlBsTqWmTdZLjmuWE9QxXZmiZswpnpkbuSquGBfA1KA9 ndbeklg+sXICnM/iil1KY2STjxorC0M5zTddZwozLw7lE4z9Ue2yRvueb/kwQZqJR5rj QZGG2Y6rz7lbcz3aipiYEQ6LC3Ea3MrlgU/3LOdsNxrZj/9zid2UR+kdYFZkIkiMWflC O7aw== X-Gm-Message-State: ANoB5pnvOwKfmruqwi4AWv4CC9Rjf/3U5jBlNzVtYAAzSOFE7qVpOFz2 YOMC7/B24qXRjYAgT//H5BxkIg== X-Received: by 2002:a17:902:c194:b0:189:6995:660c with SMTP id d20-20020a170902c19400b001896995660cmr32787116pld.48.1669942541672; Thu, 01 Dec 2022 16:55:41 -0800 (PST) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id x3-20020aa79ac3000000b00575c5ae50cdsm3949150pfp.142.2022.12.01.16.55.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 01 Dec 2022 16:55:41 -0800 (PST) Date: Thu, 1 Dec 2022 16:55:40 -0800 From: Kees Cook To: David Gow Cc: Brendan Higgins , Daniel Latypov , Shuah Khan , kunit-dev@googlegroups.com, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-mm@kvack.org, Oliver Glitta , Hyeonggon Yoo <42.hyeyoo@gmail.com>, Christoph Lameter , Vlastimil Babka , David Rientjes , Andrew Morton Subject: Re: [PATCH v4 3/3] mm: slub: test: Use the kunit_get_current_test() function Message-ID: <202212011655.7B32E97C92@keescook> References: <20221125084306.1063074-1-davidgow@google.com> <20221125084306.1063074-3-davidgow@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221125084306.1063074-3-davidgow@google.com> X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Nov 25, 2022 at 04:43:06PM +0800, David Gow wrote: > Use the newly-added function kunit_get_current_test() instead of > accessing current->kunit_test directly. This function uses a static key > to return more quickly when KUnit is enabled, but no tests are actively > running. There should therefore be a negligible performance impact to > enabling the slub KUnit tests. > > Other than the performance improvement, this should be a no-op. > > Cc: Oliver Glitta > Cc: Hyeonggon Yoo <42.hyeyoo@gmail.com> > Cc: Christoph Lameter > Cc: Vlastimil Babka > Cc: David Rientjes > Cc: Andrew Morton > Signed-off-by: David Gow Reviewed-by: Kees Cook -- Kees Cook