Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp1427075rwb; Thu, 1 Dec 2022 17:40:09 -0800 (PST) X-Google-Smtp-Source: AA0mqf7Q0pPewUT3ONdghHq4Pp8ex0hvX2x1JtfhvL2+9shvbSA0iogAcFaYJBhLFHg0XAqoYakn X-Received: by 2002:a17:903:1ce:b0:186:a2ef:7a69 with SMTP id e14-20020a17090301ce00b00186a2ef7a69mr50253150plh.77.1669945208933; Thu, 01 Dec 2022 17:40:08 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669945208; cv=none; d=google.com; s=arc-20160816; b=y0PZxIbcxR7pLtTp571Q5BHfz/fyYfFAcY2ItZ5Izfo0Q823nIUItOL8Y3OU3H8N7W e7cB3wo+SL6+MUDUW5PTZuNqFiXHu6OHcvVlwpMSIp2TERKzbA0HpG6EbnkJiTs76HJR KPPYs8doJ83sIoiy8A6ykSDcQ428qQwPek7xHWRh6WTYDhTnD4Y5NgT1KAJavB56JYSO hLRZJrHqVVSXINgXnbcgYU4u5g//xfVnZiq18gFuPgqtd8Fh7h14mFEi8QPdremciZGZ SLJsmSe3L7Hm0+ckmKyDHnL8zoFtkuuMk8pB6YsDyoQY8MVDBqkXSlyVSO1AvegIyu5J RylQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=Ha7o0eCHmk2nS/stJvaRFac3CxHDSLDcs+LGCRqIPBY=; b=mq0/2v11sA8J/PI8UJyhCGpyAjfF7Ik4KDDgVbU1ucXhT2FFnQugGo+2ZBzbUdvNqB S1v4RAIh8gJWK0DDJDzdjlNybLON7QS37DXYexFxPoU7VfIfrNqgnly/6pe50u1F3ln7 IMY5frZrwKEgOBK/kSExM9fEKAumsyiwiaoXZAZHmg8gdXmp945q7VlcWEK6w5tsUPk9 2+Ct7/5Q+meb7E/fsL6/Ap7MrulgTemY94wVYcZN8L87CzjjbYpz2gLPO9zfkR9tbOZ9 vZpYANuzY5AieG5dww9ZPqN+6i/FamLq4WuWeFDwMGukso/rWtHwIFNJsUgwr074yyqV eGig== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel-dk.20210112.gappssmtp.com header.s=20210112 header.b=BuUEFSdI; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id 68-20020a630947000000b0047886bf1538si98945pgj.427.2022.12.01.17.39.58; Thu, 01 Dec 2022 17:40:08 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel-dk.20210112.gappssmtp.com header.s=20210112 header.b=BuUEFSdI; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231197AbiLBBWp (ORCPT + 81 others); Thu, 1 Dec 2022 20:22:45 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42548 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230386AbiLBBWm (ORCPT ); Thu, 1 Dec 2022 20:22:42 -0500 Received: from mail-pg1-x530.google.com (mail-pg1-x530.google.com [IPv6:2607:f8b0:4864:20::530]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 809E7183B1 for ; Thu, 1 Dec 2022 17:22:40 -0800 (PST) Received: by mail-pg1-x530.google.com with SMTP id 6so3160096pgm.6 for ; Thu, 01 Dec 2022 17:22:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Ha7o0eCHmk2nS/stJvaRFac3CxHDSLDcs+LGCRqIPBY=; b=BuUEFSdIuuRDAjVFKVAhHELsh2BTyw5NoWSVDMZq1DGpduTVgVQpO+7R5WrmoIx13M M17M+w1VUbCDiexAf14moFi1WiPv5byymNaQeBzbnNxhv7ZEgDDE4rrQ5yrgFdX+5OQk SMfw+xxJKUuemgj7vBvIg7ae5dRpRRx63khUXhSoX7VuLzyVPS08OClh9OJtTo2WieSs s2eVSCczZxx7r8aGifEn1xk0+06SAwsbh3KN2NuIRxyJmSHmrAsiyOs6B5CdKbo84sx0 Q8MkiaW+nBe0rxzoIHJnvyn139jE7veJt1/9E1oQBFtsdQHOysYhnyb90VnNvUPxHr/M FFQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Ha7o0eCHmk2nS/stJvaRFac3CxHDSLDcs+LGCRqIPBY=; b=jGfkVmixzUYOHRpa5QiF16t3w2Z3xpAp9QrM+hmNcrRgMOhYS4CIcFz6qIKUT59L6D 0c3ydTSSezOfR6Rf3eU5F2TQ1hSS5WObevEcl96o6LcZhSRaY+z9m9ELp0d3AjCL32NP 8v4MkPjInPTwAqFuw13+BCyT/oXscFGCHCr0sgnAzH6C+myeXv+FTcUYRjEdJ0R59Pcy 3RLDgMonCMR6tS9211DGFRqCSp/0My29DUEIFSaxcPGFJNRWFRI2WLEtQ0M+Rl365eBV yLyHwZ4Px8LCIDngBFSHTSsTtXiUskiORstT/Vdu07dDrbkIxk2pzAsU/CSf+U6mPztx Z3BQ== X-Gm-Message-State: ANoB5pmG+XmDIGOCBjtC9dDI7VK26GBFUG2sLwySsnmjkmBL7gB/XzKH D2LrLXjtAovAif1rYEtzbIKEXA== X-Received: by 2002:a62:9409:0:b0:562:e571:3f0e with SMTP id m9-20020a629409000000b00562e5713f0emr52380182pfe.72.1669944159919; Thu, 01 Dec 2022 17:22:39 -0800 (PST) Received: from [192.168.1.136] ([198.8.77.157]) by smtp.gmail.com with ESMTPSA id w64-20020a17090a6bc600b00219025945dcsm5504114pjj.19.2022.12.01.17.22.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 01 Dec 2022 17:22:39 -0800 (PST) Message-ID: <7aa9e496-747d-46ae-b250-d504d84af6e5@kernel.dk> Date: Thu, 1 Dec 2022 18:22:38 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH -next] blk-cgroup: Fix some kernel-doc comments Content-Language: en-US To: Yang Li , tj@kernel.org Cc: josef@toxicpanda.com, cgroups@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, Abaci Robot References: <20221202011713.14834-1-yang.lee@linux.alibaba.com> From: Jens Axboe In-Reply-To: <20221202011713.14834-1-yang.lee@linux.alibaba.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.2 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/1/22 6:17 PM, Yang Li wrote: > Make the description of @gendisk to @disk in blkcg_schedule_throttle() > to clear the below warnings: > > block/blk-cgroup.c:1850: warning: Function parameter or member 'disk' not described in 'blkcg_schedule_throttle' > block/blk-cgroup.c:1850: warning: Excess function parameter 'gendisk' description in 'blkcg_schedule_throttle' Please always include a fixes line: Fixes: de185b56e8a6 ("blk-cgroup: pass a gendisk to blkcg_schedule_throttle") -- Jens Axboe