Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <66b3fd78-31bc-c435-ccc8-c8682b3cacee@gmail.com>
Date:   Fri, 2 Dec 2022 09:14:08 +0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.5.0
Subject: Re: [PATCH v1 3/3] Documentation: riscv: add a section about ISA
 string ordering in /proc/cpuinfo
Content-Language: en-US
To:     Conor Dooley <conor.dooley@microchip.com>
Cc:     Conor Dooley <conor@kernel.org>,
        Palmer Dabbelt <palmer@dabbelt.com>,
        linux-riscv@lists.infradead.org, ajones@ventanamicro.com,
        aou@eecs.berkeley.edu, corbet@lwn.net, guoren@kernel.org,
        heiko@sntech.de, paul.walmsley@sifive.com,
        linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org
References: <20221130234125.2722364-1-conor@kernel.org>
 <20221130234125.2722364-4-conor@kernel.org> <Y4gZ/KZz9rdYj/0r@debian.me>
 <Y4hjIWHTuYcf90ja@wendy>
From:   Bagas Sanjaya <bagasdotme@gmail.com>
In-Reply-To: <Y4hjIWHTuYcf90ja@wendy>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 12/1/22 15:17, Conor Dooley wrote:
> On Thu, Dec 01, 2022 at 10:05:32AM +0700, Bagas Sanjaya wrote:
>> On Wed, Nov 30, 2022 at 11:41:26PM +0000, Conor Dooley wrote:
>>> +#. Single-letter extensions come first, in "canonical order", so
>>> +   "IMAFDQLCBKJTPVH".
>>
>> "..., that is ... ."
> 
> Hmm, that reads strangely to me. s/that/which/.
> 

OK.

>>
>>> +#. The first letter following the 'Z' conventionally indicates the most
>>> +   closely related alphabetical extension category, IMAFDQLCBKJTPVH.
>>> +   If multiple 'Z' extensions are named, they should be ordered first by
>>> +   category, then alphabetically within a category.
>>> +
>>
>> Did you mean "most closely related alphabetical extension category in
>> canonical order"?
> 
> I am not 100% sure what you are suggesting a replacement of here. I
> think I may reword this as:
>   For additional standard extensions, the first letter following the 'Z'
>   conventionally indicates the most closely related alphabetical
>   extension category. If multiple 'Z' extensions are named, they will
>   be ordered first by category, in canonical order as listed above, then
>   alphabetically within a category.
> 

That LGTM.

>>> +An example string following the order is:
>>> +   rv64imadc_zifoo_zigoo_zafoo_sbar_scar_zxmbaz_xqux_xrux
>>> +
>>  
>> IMO literal code block should be better fit for the example above,
>> rather than definition list:
> 
> Uh, sure? I'm not sure what impact that has on the output, but I can
> switch to a pre-formatted block.
> 

Something like ``foo``?

Thanks.

-- 
An old man doll... just what I always wanted! - Clara