Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 1 Dec 2022 18:48:12 -0800
From:   Dan Williams <dan.j.williams@intel.com>
To:     <ira.weiny@intel.com>, Dan Williams <dan.j.williams@intel.com>
CC:     Ira Weiny <ira.weiny@intel.com>,
        Jonathan Cameron <Jonathan.Cameron@huawei.com>,
        Dave Jiang <dave.jiang@intel.com>,
        "Alison Schofield" <alison.schofield@intel.com>,
        Vishal Verma <vishal.l.verma@intel.com>,
        Ben Widawsky <bwidawsk@kernel.org>,
        "Steven Rostedt" <rostedt@goodmis.org>,
        Davidlohr Bueso <dave@stgolabs.net>,
        <linux-kernel@vger.kernel.org>, <linux-cxl@vger.kernel.org>
Subject: RE: [PATCH V2 04/11] cxl/mem: Clear events on driver load
Message-ID: <6389676c60d39_3cbe029487@dwillia2-xfh.jf.intel.com.notmuch>
References: <20221201002719.2596558-1-ira.weiny@intel.com>
 <20221201002719.2596558-5-ira.weiny@intel.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20221201002719.2596558-5-ira.weiny@intel.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?YSP29MQ1OTFqaW1SekJy8z7wisNYVMuWEv03Tlgf8HAGr+u5jPtpLWSY7Qro?=
 =?us-ascii?Q?sH1kjVWTQ9hBOPjlJ1Hu+8rC78shTkwekILc/RADvyIlhz6E0zyx7O+EhPUo?=
 =?us-ascii?Q?eSUpmUstY0s15LlZxtQ6hfMQPoDCD1GAFFUoCQKK1qnZopEwFydAN3yU1ggg?=
 =?us-ascii?Q?VKAg39EFh/exDuq+Jk4bsekLdl6wOuN+ZrFaIJeJckb6Av1wC6TLL3OjvoSy?=
 =?us-ascii?Q?0SZeAMNgc01fMXExH7JXn2p+UE7v0+CSQ8FOg3j89IhAq9dMW43xdMNP9vCZ?=
 =?us-ascii?Q?wGLwHBB/a7cFLrgIn9ABUYzVFRvCg5xs1ZI7iURmnZwQpe54Rne/X8f7swIe?=
 =?us-ascii?Q?9nDP95nDtSi9nVhRoHhXMitB61LTe7G+imTxvs7819lHghrwMTHUZVOyL9GA?=
 =?us-ascii?Q?YKmnE1gJT4JmihVyjgRS6uACx4vf/yY0fux1gMepJ4ffuW1yRxNf5MqKh/zz?=
 =?us-ascii?Q?Wh7IR6Rq2ZWtiUU8M/8JwDnLzrBIhwbXPTHexdAVgXVV1JRQB6AEAd8hfn9t?=
 =?us-ascii?Q?EfyYsropkR+6/NFQ4FNWwGGD2+GE02ib9q+rtbJ/7VcEsjOBQhJFxgHh5cdm?=
 =?us-ascii?Q?Ixx8ndzSBMe3hQ5cX3VHCgQwHTYaU42k5VZnOvSiyh3eCU/yIqnT6k5DiQG1?=
 =?us-ascii?Q?On4csJ7a0WsneMFs4m394UVPIgjTEBGPjRVncfeIGouBLucOLd1eEKRdfhzX?=
 =?us-ascii?Q?c/o7y7IV1PocP4qYFOst1HjK4LHHwoG1YLNUHLNdCDL/Hy3NwDY+89Lu1Sz+?=
 =?us-ascii?Q?rLTDAYeYqkpWW3GopFi1Mc8Q1kx4ZAL7nmkog40mbH9F3DDmm0Y1SddoAhTm?=
 =?us-ascii?Q?Gs4yAoCx7/35v4tshfOoSA7o3QYrXWPAqsztnuc3++Wz0Fv2lSWlY4mddHdH?=
 =?us-ascii?Q?xHsYgEJBQ7Wk6mKnGYZY9vZvJtMlzLV2Hpy2IlHdBmS/CDn8EKJgH1o1xd7Q?=
 =?us-ascii?Q?JrN990bolvnybaWeb9CY0qDY6KIxYMVWKF9WQ2/R409nqA9EokmrbL+Ug0qd?=
 =?us-ascii?Q?IwuJNFP0xkcyLae1qd27yFAmchdf4MrTr13OwzBabohkvLeMREjKxh1wx8TM?=
 =?us-ascii?Q?LAw52usBRYcdWODQOZAPxI3XVHOWsX74E5P6x4jpA4xxA9azGtBqnBgHV4KH?=
 =?us-ascii?Q?GoZr6UwkkOC4IyW6RV8ieylJcfdqiaVDB6F4qEQeXKOgBRbqyR+D3S/l357k?=
 =?us-ascii?Q?AEVswaRasG1So1WtB7CS7yjtEv3KlMUwxyUSuj0omlb/4akh7ti6cajL6HUE?=
 =?us-ascii?Q?gOAemAzWl4CyL4YFBcDMeGy8E+DSpx3S7vTFhww/lsuoFGu7Qj02TNfssCLA?=
 =?us-ascii?Q?X83e06HMl8bbibSmz89x02K3Njl2HwdhIirs3MtUTAHyh8tuohm5bb2S413A?=
 =?us-ascii?Q?vR7KxIopk5qED0+7JiAu5EAmbZjpvolzv2EgZ9LsNbjKmskqvqo7sX4X091F?=
 =?us-ascii?Q?UhMSf+FeJLZysPBqTMVMFA3dLKmFTIZdiyctDToYcK//ZlTjtPxoBfK90KJa?=
 =?us-ascii?Q?ZUH+ps/KuLPAbnMqHspy7QR2Sdsy1PIXRk4tVUYHfkcZK3fT45w6+EIYBU8z?=
 =?us-ascii?Q?6uwgyK3j0vOovGQ37qM6MGAZrAYQe9u59X2NstX6vGCrjAkZhVjCMpMKNffE?=
 =?us-ascii?Q?lg=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 35512954-1ac7-49dd-c95d-08dad40fa8ec
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1101MB2126.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Dec 2022 02:48:15.1597
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: U1l6Osz4KVx5TOa7of8NvhZ72RQdtxPceB280TSM4Ajonp4OMhPSLk37ZMrl3oXllGShdzvAHFLGLSR8cJV2byk7p4Tu8kGivYFSqbI9eR0=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB5920
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI,
        SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

cxl/mem is cxl_mem.ko, This is cxl/pci.

ira.weiny@ wrote:
> From: Ira Weiny <ira.weiny@intel.com>
> 
> The information contained in the events prior to the driver loading can
> be queried at any time through other mailbox commands.
> 
> Ensure a clean slate of events by reading and clearing the events.  The
> events are sent to the trace buffer but it is not anticipated to have
> anyone listening to it at driver load time.

This is easy to guarantee with modprobe policy, so I am not sure it is
worth stating.

This breakdown feels odd. I would split the trace event definitions into
its own lead in patch since that is a pile of definitions that can be
merged on their own. Then squash get, clear, and this patch into one
patch as they don't have much reason to go in separately.

> Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> Reviewed-by: Dave Jiang <dave.jiang@intel.com>
> Signed-off-by: Ira Weiny <ira.weiny@intel.com>
> ---
>  drivers/cxl/pci.c            | 2 ++
>  tools/testing/cxl/test/mem.c | 2 ++
>  2 files changed, 4 insertions(+)
> 
> diff --git a/drivers/cxl/pci.c b/drivers/cxl/pci.c
> index 8f86f85d89c7..11e95a95195a 100644
> --- a/drivers/cxl/pci.c
> +++ b/drivers/cxl/pci.c
> @@ -521,6 +521,8 @@ static int cxl_pci_probe(struct pci_dev *pdev, const struct pci_device_id *id)
>  	if (IS_ERR(cxlmd))
>  		return PTR_ERR(cxlmd);
>  
> +	cxl_mem_get_event_records(cxlds);
> +
>  	if (resource_size(&cxlds->pmem_res) && IS_ENABLED(CONFIG_CXL_PMEM))
>  		rc = devm_cxl_add_nvdimm(&pdev->dev, cxlmd);
>  
> diff --git a/tools/testing/cxl/test/mem.c b/tools/testing/cxl/test/mem.c
> index aa2df3a15051..e2f5445d24ff 100644
> --- a/tools/testing/cxl/test/mem.c
> +++ b/tools/testing/cxl/test/mem.c
> @@ -285,6 +285,8 @@ static int cxl_mock_mem_probe(struct platform_device *pdev)
>  	if (IS_ERR(cxlmd))
>  		return PTR_ERR(cxlmd);
>  
> +	cxl_mem_get_event_records(cxlds);
> +

This hunk likely goes with the first patch that actually implements some
mocked events.

>  	if (resource_size(&cxlds->pmem_res) && IS_ENABLED(CONFIG_CXL_PMEM))
>  		rc = devm_cxl_add_nvdimm(dev, cxlmd);
>  
> -- 
> 2.37.2
>