Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp1730215rwb;
        Thu, 1 Dec 2022 23:44:33 -0800 (PST)
X-Google-Smtp-Source: AA0mqf5cWYhLeTIBQKOKaqqeS+l8sa9miJ5QrAPVAjdUWDn0EX5p+qhWUj8Tmx+DjpXHkHNMZAJ9
X-Received: by 2002:a05:6402:548a:b0:468:e8e2:31c9 with SMTP id fg10-20020a056402548a00b00468e8e231c9mr36871983edb.310.1669967072833;
        Thu, 01 Dec 2022 23:44:32 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; t=1669967072; cv=none;
        d=google.com; s=arc-20160816;
        b=CPdHWNVRjD16rCLOQ21cCeAxSgqCQmN8Nt/YYbzo+FzYKf+zEydwyfsnhc0RnFpF77
         RhiiWB0DCfUOCSYGtHuxLYS1yNXUc9IAVHKRWpo055evXSJDkmoceleWI3glwvj/jauF
         nnttRTGlPJ610htBdHus0BJA/mm+dvAZ31WJggKlLXQy615T1YhmvsQsafu4pQhwUvpM
         NUv7GwUE3eyBFziVMgBAI4bcjgiK5AfWva+GBNSIHjcJ0cH3d7D5cHw2qxa5r/7kgdnL
         liZOMG4LxAZZd8xDCYhTIiXqb+vkPgSq5Akg+o7A0U10C/yi+dbdNf+DNxbkpmmHxB61
         PwLw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:sender:in-reply-to:content-disposition
         :mime-version:references:message-id:subject:cc:to:from:date
         :dkim-signature;
        bh=1y/HNhY87C/cynIcRRBRIvjFTnd1b8AbWpP8wEmSPhw=;
        b=f5CPms/MxK2HM5S/yGAuarosGhEIjwho3REmeqJV2l8hSE9A7rGdGp5Zf2dtCmS6TL
         wC3O6K0JS6lU21aGIor4tMWrGU/+psqiOFBcZX689d2Eiq3ZwM3gtTTFkLvdYdnP71ln
         x/XJSwYBYoeTdD9ERH1wcyMLQEQKYCMYUtsGfmaKU3JsCXFlPGYHci2y7DaaKYVSSEiO
         aiziRpsA2V0XKUdoeSeHsZNMb8yZc0mb10eoWzaSYZs9LHMwTCGexKaQFU3iAVxYooUa
         8zMQqtkanmggkNZ3mXwWpvPlpBWZ7H9Tp1ocljj4e+hQvHNLEpTVB2ZNEcWoOZQMJvGf
         lyiA==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@linux.org.uk header.s=zeniv-20220401 header.b="V2euY/KC";
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=zeniv.linux.org.uk
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20])
        by mx.google.com with ESMTP id z3-20020a056402274300b004627d582888si6574363edd.24.2022.12.01.23.44.12;
        Thu, 01 Dec 2022 23:44:32 -0800 (PST)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@linux.org.uk header.s=zeniv-20220401 header.b="V2euY/KC";
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=zeniv.linux.org.uk
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S232422AbiLBHNg (ORCPT <rfc822;2bno13@gmail.com> + 83 others);
        Fri, 2 Dec 2022 02:13:36 -0500
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59996 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S232307AbiLBHNd (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 2 Dec 2022 02:13:33 -0500
Received: from zeniv.linux.org.uk (zeniv.linux.org.uk [IPv6:2a03:a000:7:0:5054:ff:fe1c:15ff])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 95CFB70617;
        Thu,  1 Dec 2022 23:13:31 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
        d=linux.org.uk; s=zeniv-20220401; h=Sender:In-Reply-To:Content-Type:
        MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To:
        Content-Transfer-Encoding:Content-ID:Content-Description;
        bh=1y/HNhY87C/cynIcRRBRIvjFTnd1b8AbWpP8wEmSPhw=; b=V2euY/KCjM6yGHXGW1uv8xA/Ow
        N/y9vuV/m4GnPxmVrHHQmtZuVyEMf7oVrga2i2eYUfUQC+wM4kNaXqr/+AwoBgDQvZfpGBev0fLqC
        jyt9A65qC5Fiyayp0TjPoJuvJVBTBydSteozTm1r0gHfMPO4XDjCasj1rHOkcbPLqnvnqWRePxFHg
        SuIOhBI3lS6gNAB84JtBxmL6hnF3VMuDt1R2LyB/gZqHFFaF2TH4WU7p88BVh8NVkoInOn0iI6T8A
        9nYtQ5HhU9W3m596c6A4twInZd9el5pcw3eMVsuIeBh5lwHJwM2KYc25D+SlxB6J1lYmeyXtkvUuF
        DG1bqzZg==;
Received: from viro by zeniv.linux.org.uk with local (Exim 4.96 #2 (Red Hat Linux))
        id 1p10EW-008Ngh-1C;
        Fri, 02 Dec 2022 07:13:16 +0000
Date:   Fri, 2 Dec 2022 07:13:16 +0000
From:   Al Viro <viro@zeniv.linux.org.uk>
To:     Li Qiong <liqiong@nfschina.com>
Cc:     Pablo Neira Ayuso <pablo@netfilter.org>,
        Jozsef Kadlecsik <kadlec@netfilter.org>,
        Florian Westphal <fw@strlen.de>,
        "David S . Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org, netfilter-devel@vger.kernel.org,
        kernel-janitors@vger.kernel.org, coreteam@netfilter.org,
        Yu Zhe <yuzhe@nfschina.com>
Subject: Re: [PATCH] netfilter: initialize 'ret' variable
Message-ID: <Y4mljMYvNh7zHlOh@ZenIV>
References: <20221202070331.10865-1-liqiong@nfschina.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20221202070331.10865-1-liqiong@nfschina.com>
Sender: Al Viro <viro@ftp.linux.org.uk>
X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_EF,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Dec 02, 2022 at 03:03:31PM +0800, Li Qiong wrote:
> The 'ret' should need to be initialized to 0, in case
> return a uninitialized value.

Why is 0 the right value?  And which case would it be?
We clearly need to know that to figure out which return
value would be correct for it...