Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Kurt Kanzenbach <kurt@linutronix.de>
To:     Artem Chernyshev <artem.chernyshev@red-soft.ru>,
        artem.chernyshev@red-soft.ru, Vladimir Oltean <olteanv@gmail.com>
Cc:     Andrew Lunn <andrew@lunn.ch>,
        Florian Fainelli <f.fainelli@gmail.com>,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        lvc-project@linuxtesting.org
Subject: Re: [PATCH v3 2/3] net: dsa: hellcreek: Check return value
In-Reply-To: <20221201140032.26746-2-artem.chernyshev@red-soft.ru>
References: <20221201140032.26746-1-artem.chernyshev@red-soft.ru>
 <20221201140032.26746-2-artem.chernyshev@red-soft.ru>
Date:   Fri, 02 Dec 2022 08:54:36 +0100
Message-ID: <87h6yes0jn.fsf@kurt>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
        micalg=pgp-sha512; protocol="application/pgp-signature"
Precedence: bulk

--=-=-=
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

On Thu Dec 01 2022, Artem Chernyshev wrote:
> Return NULL if we got unexpected value from skb_trim_rcsum()=20
                                              ^ pskb_trim_rcsum()
> in hellcreek_rcv()

For the next time, a change log should rather explain *why* a change is
made instead of *what* the patch is doing.

Other than that,

Reviewed-by: Kurt Kanzenbach <kurt@linutronix.de>

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQJHBAEBCgAxFiEEvLm/ssjDfdPf21mSwZPR8qpGc4IFAmOJrzwTHGt1cnRAbGlu
dXRyb25peC5kZQAKCRDBk9HyqkZzgiZeEACZycYo7R3gBb9NfgWODxFrrXOgR6jI
svJW/OaEEDv+xaFP8OetWRR08gqlDaynBMLJSKUxOnJR9cF6eSUp0KkGy4kKHO3g
iCLEyJpmh7zum3b9vjXS9TA9ePHiWxIvkWgm7PTBDBSVwztadIf4H7S3UU8I2Mac
Gzjc69V+beYJBoEBfwa7o9OoPI0VQ2yYqmDMJQ9q8oyQVgc1XRaHQEPYj+GOhHvv
flNMC/uzeh8u2Ld8Rw5pzGZ7AO0DXCDpRIKdbnlLcMNysVJeMc9VqwIb0ifh7+4s
HHJo0C8AzZ9LkNVvNFtFKnj+Ge16Dvnb+16aqv6SmJXFuj//0QbwtYBWaMC6nYXG
4zPRcI+m/LhvwcbEsjXzuKWdHPOodxt7bnOLDQZvJOcmwZiEtj0nL8kdIeq0L418
0wFiAg5TWudB6xDyhqg2hP4wwsQ1wv5MN0gGSOQQvBaff48HxZdakmdK8aqiprkB
MKRJHBMUE8v6NEy8H7rKWcGH3EmJrqJ926hwPC4vQgAbnZ1tVPuP+xWUJPROmwNQ
omf811iOtGwUK0jBDmDG7tpQtuVHOsNHFcL8pFRnzeJ4WUEFxH2g2U+rZxuMyR85
uGd6c7PX0v2hOlPg92p44iX8rMxsONbFgmKNfK5FeH9He5WQfbJI1D69EjIpqPbr
57InUdUSyyEhSg==
=z5S+
-----END PGP SIGNATURE-----
--=-=-=--