Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <8685fd07e7abd6ed5b0321d9d9ba3abc5a8db2fc.camel@icenowy.me>
Subject: Re: [PATCH v2 12/12] riscv: defconfig: Enable the Allwinner D1
 platform and drivers
From:   Icenowy Zheng <uwu@icenowy.me>
To:     Guo Ren <guoren@kernel.org>, Samuel Holland <samuel@sholland.org>
Cc:     Chen-Yu Tsai <wens@csie.org>,
        Jernej Skrabec <jernej.skrabec@gmail.com>,
        linux-sunxi@lists.linux.dev, Palmer Dabbelt <palmer@dabbelt.com>,
        Conor Dooley <conor@kernel.org>,
        linux-riscv@lists.infradead.org, devicetree@vger.kernel.org,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Rob Herring <robh+dt@kernel.org>,
        Heiko Stuebner <heiko@sntech.de>,
        Jisheng Zhang <jszhang@kernel.org>,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        Andre Przywara <andre.przywara@arm.com>,
        Albert Ou <aou@eecs.berkeley.edu>,
        Anup Patel <apatel@ventanamicro.com>,
        Atish Patra <atishp@rivosinc.com>,
        Christian Hewitt <christianshewitt@gmail.com>,
        Conor Dooley <conor.dooley@microchip.com>,
        Heinrich Schuchardt <heinrich.schuchardt@canonical.com>,
        Linus Walleij <linus.walleij@linaro.org>,
        Paul Walmsley <paul.walmsley@sifive.com>,
        Stanislav Jakubek <stano.jakubek@gmail.com>
Date:   Fri, 02 Dec 2022 16:34:20 +0800
In-Reply-To: <CAJF2gTTOKPAqazF5w03NBzxMW7MGpoCn7vvdj=RabGrzp5WVZQ@mail.gmail.com>
References: <20221125234656.47306-1-samuel@sholland.org>
         <20221125234656.47306-13-samuel@sholland.org>
         <CAJF2gTTOKPAqazF5w03NBzxMW7MGpoCn7vvdj=RabGrzp5WVZQ@mail.gmail.com>
Organization: Anthon Open-Source Community
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.44.4 
MIME-Version: 1.0
Precedence: bulk

=E5=9C=A8 2022-11-26=E6=98=9F=E6=9C=9F=E5=85=AD=E7=9A=84 08:24 +0800=EF=BC=
=8CGuo Ren=E5=86=99=E9=81=93=EF=BC=9A
> On Sat, Nov 26, 2022 at 7:47 AM Samuel Holland <samuel@sholland.org>
> wrote:
> >=20
> > Now that several D1-based boards are supported, enable the platform
> > in
> > our defconfig. Build in the drivers which are necessary to boot,
> > such as
> > the pinctrl, MMC, RTC (which provides critical clocks), SPI (for
> > flash),
> > and watchdog (which may be left enabled by the bootloader). Other
> > common
> > onboard peripherals are enabled as modules.
> >=20
> > Signed-off-by: Samuel Holland <samuel@sholland.org>
> > ---
> >=20
> > (no changes since v1)
> >=20
> > =C2=A0arch/riscv/configs/defconfig | 23 ++++++++++++++++++++++-
> > =C2=A01 file changed, 22 insertions(+), 1 deletion(-)
> >=20
> > diff --git a/arch/riscv/configs/defconfig
> > b/arch/riscv/configs/defconfig
> > index 05fd5fcf24f9..8dfe0550c0e6 100644
> > --- a/arch/riscv/configs/defconfig
> > +++ b/arch/riscv/configs/defconfig
> > @@ -25,6 +25,7 @@ CONFIG_BLK_DEV_INITRD=3Dy
> > =C2=A0CONFIG_EXPERT=3Dy
> > =C2=A0# CONFIG_SYSFS_SYSCALL is not set
> > =C2=A0CONFIG_PROFILING=3Dy
> > +CONFIG_ARCH_SUNXI=3Dy
> > =C2=A0CONFIG_SOC_MICROCHIP_POLARFIRE=3Dy
> > =C2=A0CONFIG_SOC_SIFIVE=3Dy
> > =C2=A0CONFIG_SOC_STARFIVE=3Dy
> > @@ -118,22 +119,31 @@ CONFIG_VIRTIO_NET=3Dy
> > =C2=A0CONFIG_MACB=3Dy
> > =C2=A0CONFIG_E1000E=3Dy
> > =C2=A0CONFIG_R8169=3Dy
> > +CONFIG_STMMAC_ETH=3Dm
> > =C2=A0CONFIG_MICROSEMI_PHY=3Dy
> > =C2=A0CONFIG_INPUT_MOUSEDEV=3Dy
> > +CONFIG_KEYBOARD_SUN4I_LRADC=3Dm
> > =C2=A0CONFIG_SERIAL_8250=3Dy
> > =C2=A0CONFIG_SERIAL_8250_CONSOLE=3Dy
> > +CONFIG_SERIAL_8250_DW=3Dy
> > =C2=A0CONFIG_SERIAL_OF_PLATFORM=3Dy
> > =C2=A0CONFIG_VIRTIO_CONSOLE=3Dy
> > =C2=A0CONFIG_HW_RANDOM=3Dy
> > =C2=A0CONFIG_HW_RANDOM_VIRTIO=3Dy
> > +CONFIG_I2C_MV64XXX=3Dm
> > =C2=A0CONFIG_SPI=3Dy
> > =C2=A0CONFIG_SPI_SIFIVE=3Dy
> > +CONFIG_SPI_SUN6I=3Dy
> > =C2=A0# CONFIG_PTP_1588_CLOCK is not set
> > -CONFIG_GPIOLIB=3Dy
> > =C2=A0CONFIG_GPIO_SIFIVE=3Dy
> > +CONFIG_WATCHDOG=3Dy
> > +CONFIG_SUNXI_WATCHDOG=3Dy
> > +CONFIG_REGULATOR=3Dy
> > +CONFIG_REGULATOR_FIXED_VOLTAGE=3Dy
> > =C2=A0CONFIG_DRM=3Dm
> > =C2=A0CONFIG_DRM_RADEON=3Dm
> > =C2=A0CONFIG_DRM_NOUVEAU=3Dm
> > +CONFIG_DRM_SUN4I=3Dm
> > =C2=A0CONFIG_DRM_VIRTIO_GPU=3Dm
> > =C2=A0CONFIG_FB=3Dy
> > =C2=A0CONFIG_FRAMEBUFFER_CONSOLE=3Dy
> > @@ -146,19 +156,30 @@ CONFIG_USB_OHCI_HCD=3Dy
> > =C2=A0CONFIG_USB_OHCI_HCD_PLATFORM=3Dy
> > =C2=A0CONFIG_USB_STORAGE=3Dy
> > =C2=A0CONFIG_USB_UAS=3Dy
> > +CONFIG_USB_MUSB_HDRC=3Dm
> > +CONFIG_USB_MUSB_SUNXI=3Dm
> > +CONFIG_NOP_USB_XCEIV=3Dm
> > =C2=A0CONFIG_MMC=3Dy
> > =C2=A0CONFIG_MMC_SDHCI=3Dy
> > =C2=A0CONFIG_MMC_SDHCI_PLTFM=3Dy
> > =C2=A0CONFIG_MMC_SDHCI_CADENCE=3Dy
> > =C2=A0CONFIG_MMC_SPI=3Dy
> > +CONFIG_MMC_SUNXI=3Dy
> > =C2=A0CONFIG_RTC_CLASS=3Dy
> > +CONFIG_RTC_DRV_SUN6I=3Dy
> > +CONFIG_DMADEVICES=3Dy
> > +CONFIG_DMA_SUN6I=3Dm
> > =C2=A0CONFIG_VIRTIO_PCI=3Dy
> > =C2=A0CONFIG_VIRTIO_BALLOON=3Dy
> > =C2=A0CONFIG_VIRTIO_INPUT=3Dy
> > =C2=A0CONFIG_VIRTIO_MMIO=3Dy
> > +CONFIG_SUN8I_DE2_CCU=3Dm
> > +CONFIG_SUN50I_IOMMU=3Dy
> Do we need IOMMU?

It's utilized by some peripherals, e.g. the display engine.

>=20
> Others:
> Reviewed-by: Guo Ren <guoren@kernel.org>
>=20
> > =C2=A0CONFIG_RPMSG_CHAR=3Dy
> > =C2=A0CONFIG_RPMSG_CTRL=3Dy
> > =C2=A0CONFIG_RPMSG_VIRTIO=3Dy
> > +CONFIG_PHY_SUN4I_USB=3Dm
> > +CONFIG_NVMEM_SUNXI_SID=3Dy
> > =C2=A0CONFIG_EXT4_FS=3Dy
> > =C2=A0CONFIG_EXT4_FS_POSIX_ACL=3Dy
> > =C2=A0CONFIG_EXT4_FS_SECURITY=3Dy
> > --
> > 2.37.4
> >=20
>=20
>=20