Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S969193AbXHMMyp (ORCPT ); Mon, 13 Aug 2007 08:54:45 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S942222AbXHMHph (ORCPT ); Mon, 13 Aug 2007 03:45:37 -0400 Received: from brick.kernel.dk ([87.55.233.238]:8485 "EHLO kernel.dk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S968048AbXHMHpd (ORCPT ); Mon, 13 Aug 2007 03:45:33 -0400 Date: Mon, 13 Aug 2007 09:45:30 +0200 From: Jens Axboe To: Daniel Phillips Cc: Evgeniy Polyakov , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, Peter Zijlstra Subject: Re: Distributed storage. Message-ID: <20070813074530.GE23758@kernel.dk> References: <20070731171347.GA14267@2ka.mipt.ru> <200708071124.56859.phillips@phunq.net> <20070807205538.GB5245@kernel.dk> <200708121637.00144.phillips@phunq.net> <20070813072848.GC23758@kernel.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20070813072848.GC23758@kernel.dk> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1025 Lines: 23 On Mon, Aug 13 2007, Jens Axboe wrote: > > You did not comment on the one about putting the bio destructor in > > the ->endio handler, which looks dead simple. The majority of cases > > just use the default endio handler and the default destructor. Of the > > remaining cases, where a specialized destructor is needed, typically a > > specialized endio handler is too, so combining is free. There are few > > if any cases where a new specialized endio handler would need to be > > written. > > We could do that without too much work, I agree. But that idea fails as well, since reference counts and IO completion are two completely seperate entities. So unless end IO just happens to be the last user holding a reference to the bio, you cannot free it. -- Jens Axboe - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/