Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 2 Dec 2022 11:37:42 +0000
From:   Conor Dooley <conor@kernel.org>
To:     Bagas Sanjaya <bagasdotme@gmail.com>
Cc:     Conor Dooley <conor.dooley@microchip.com>,
        Palmer Dabbelt <palmer@dabbelt.com>,
        linux-riscv@lists.infradead.org, ajones@ventanamicro.com,
        aou@eecs.berkeley.edu, corbet@lwn.net, guoren@kernel.org,
        heiko@sntech.de, paul.walmsley@sifive.com,
        linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org
Subject: Re: [PATCH v1 3/3] Documentation: riscv: add a section about ISA
 string ordering in /proc/cpuinfo
Message-ID: <Y4njhrGft++1rVRj@spud>
References: <20221130234125.2722364-1-conor@kernel.org>
 <20221130234125.2722364-4-conor@kernel.org>
 <Y4gZ/KZz9rdYj/0r@debian.me>
 <Y4hjIWHTuYcf90ja@wendy>
 <66b3fd78-31bc-c435-ccc8-c8682b3cacee@gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="Q5Y2pBB/5VxqMAhM"
Content-Disposition: inline
In-Reply-To: <66b3fd78-31bc-c435-ccc8-c8682b3cacee@gmail.com>
Precedence: bulk


--Q5Y2pBB/5VxqMAhM
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, Dec 02, 2022 at 09:14:08AM +0700, Bagas Sanjaya wrote:
> On 12/1/22 15:17, Conor Dooley wrote:
> > On Thu, Dec 01, 2022 at 10:05:32AM +0700, Bagas Sanjaya wrote:
> >> On Wed, Nov 30, 2022 at 11:41:26PM +0000, Conor Dooley wrote:
> >>> +#. Single-letter extensions come first, in "canonical order", so
> >>> +   "IMAFDQLCBKJTPVH".
> >>
> >> "..., that is ... ."
> >=20
> > Hmm, that reads strangely to me. s/that/which/.
> >=20
>=20
> OK.
>=20
> >>
> >>> +#. The first letter following the 'Z' conventionally indicates the m=
ost
> >>> +   closely related alphabetical extension category, IMAFDQLCBKJTPVH.
> >>> +   If multiple 'Z' extensions are named, they should be ordered firs=
t by
> >>> +   category, then alphabetically within a category.
> >>> +
> >>
> >> Did you mean "most closely related alphabetical extension category in
> >> canonical order"?
> >=20
> > I am not 100% sure what you are suggesting a replacement of here. I
> > think I may reword this as:
> >   For additional standard extensions, the first letter following the 'Z'
> >   conventionally indicates the most closely related alphabetical
> >   extension category. If multiple 'Z' extensions are named, they will
> >   be ordered first by category, in canonical order as listed above, then
> >   alphabetically within a category.
> >=20
>=20
> That LGTM.
>=20
> >>> +An example string following the order is:
> >>> +   rv64imadc_zifoo_zigoo_zafoo_sbar_scar_zxmbaz_xqux_xrux
> >>> +
> >> =20
> >> IMO literal code block should be better fit for the example above,
> >> rather than definition list:
> >=20
> > Uh, sure? I'm not sure what impact that has on the output, but I can
> > switch to a pre-formatted block.
> >=20
>=20
> Something like ``foo``?

Not posting a v2 for another few days, but this is what I currently
have:
https://git.kernel.org/pub/scm/linux/kernel/git/conor/linux.git/tree/Docume=
ntation/riscv/uabi.rst?h=3Driscv-uabi_docs


--Q5Y2pBB/5VxqMAhM
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCY4njhgAKCRB4tDGHoIJi
0nG3AQDN11twX+XbGwoN9/XYbdJzgY33yW3WXUGANYI/mtCVIwEA91AUTZo73nDi
o+yCNCSVVUcFUSw6gPxGDo39EVTHCwQ=
=8KH2
-----END PGP SIGNATURE-----

--Q5Y2pBB/5VxqMAhM--