Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp1993194rwb; Fri, 2 Dec 2022 04:11:08 -0800 (PST) X-Google-Smtp-Source: AA0mqf4ddlXhlBzdfO/SJdif0ukda2qx5Gml6tXKZFcx6jXCmmsER7MQITgQzTUnQa5s7hZYL/Qk X-Received: by 2002:a17:902:c40a:b0:189:884b:96db with SMTP id k10-20020a170902c40a00b00189884b96dbmr25906107plk.9.1669983068525; Fri, 02 Dec 2022 04:11:08 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669983068; cv=none; d=google.com; s=arc-20160816; b=VkcPyUTgnauJCvL1nNF+jeu6L1/YfiUhrXPV0PHpzM5M8NPc+yr9ad3nXaBNM14ccP t7NDczNlejZrFmto2t635C2OTaEPa8cztPXe3sUyDY+aMWWJT9GWNW3pqa6ofAvVsum/ IEt150cnw12XyRiPTCyLdtEmcDnm/Xz4RvBYpp9e/+C9lMkCtIfZ3stSVTNSPRac2f1/ CcRtaUJ0Eo6msj5V2hkJ0UyvLigns2gs6bbKlJ38mPUjDj/I6LS/WX6ObrC48aFq2Rfz 3K6B7i4C7pv9NCZAy61Rl23CEzVrn0bmzhYLfx85HFUPicDAxtR4ZfEZwRg8xvxnd2c9 dMhA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:message-id:date:references :in-reply-to:subject:cc:to:dkim-signature:dkim-signature:from; bh=MxUgapFgQeAY8vmEc0fUSYeWC09ZtOYl1lu3CzVnn5k=; b=cQFASEUIUsUkh09OnQg6rwgIzmEAMDHSmEUgzXvobm7rGGBP01x0n0Lp5PWoKLSG/Q IkeQxcZOtFn9+LUqz2ASDPvoUNh6fKZ79boXhJOs/xehlRDFAE2jR7Uwxuhz/YMEqurJ qy/gYhgUmndcUGtLmPpfPSBr/PBmZC3/4q9we6EBBZwsZkKnCwkDTa1T4Lf9FP1yMHFP cVkZSSxR4Si5xBEHwwxaFdVbAq8GhtReJJ5mnO8KvEGO+52dSEXIEZGHv1gYHdxG1VLg HFYlS+0lQSCNBpr1kef63N8aKAyy7SaOuD7l54VGmveWVt9//oJETOhtt3tQkUXjgjEy aiYA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=vLUJdaLG; dkim=neutral (no key) header.i=@linutronix.de header.b=4tJKvMoE; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id gt19-20020a17090af2d300b002182cd7d958si9495951pjb.46.2022.12.02.04.10.53; Fri, 02 Dec 2022 04:11:08 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=vLUJdaLG; dkim=neutral (no key) header.i=@linutronix.de header.b=4tJKvMoE; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233006AbiLBLwY (ORCPT + 83 others); Fri, 2 Dec 2022 06:52:24 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40010 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233376AbiLBLwS (ORCPT ); Fri, 2 Dec 2022 06:52:18 -0500 Received: from galois.linutronix.de (Galois.linutronix.de [IPv6:2a0a:51c0:0:12e:550::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 24792D757C for ; Fri, 2 Dec 2022 03:52:18 -0800 (PST) From: Thomas Gleixner DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1669981936; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=MxUgapFgQeAY8vmEc0fUSYeWC09ZtOYl1lu3CzVnn5k=; b=vLUJdaLG8FuAjkjsRytMPFLo6IvVpJkbHhYhwhv4mOBc8kG3I58WjdSkUG1DO1CoGMmcae 0+83iKRyKSjOEY38SafPhKTRiAqpULG9wYcMYO243CsTFroN8ZudUzX/eKEF16nYy1wcFI vjTvLBMj6RudOBJRGafC2oYLSJvVhLgi+kNP/d21wJR8g7Yb2bEmcZrj8YuQAQ5jcb20Ou iTwvVGbDNeFT5pIreZJjiDC9b83o5bAtySy9hyVXVA5yIyDskvzQu8EX6PspqymI78Uat4 nB7eh+kIXikrAC5ZwXo15aytgrQfg9GQ8eIyudu1Eq+/6Co0tTb0ZTLZLKkEdQ== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1669981936; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=MxUgapFgQeAY8vmEc0fUSYeWC09ZtOYl1lu3CzVnn5k=; b=4tJKvMoE2Rc5132Wivb1ggSpYYkc4xrKbw9va65uy7xLyBGVLVw6klpCUEEijlmQkt3lGJ YOMCejcdH4LOkpAA== To: Oleg Nesterov , Andrew Morton , Masami Hiramatsu Cc: Denys Vlasenko , Seiji Nishikawa , x86@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] uprobes/x86: allow to probe a "nop" insn with 0x66 prefix In-Reply-To: <20221201142644.GA27185@redhat.com> References: <20221201142644.GA27185@redhat.com> Date: Fri, 02 Dec 2022 12:52:16 +0100 Message-ID: <871qpiqaz3.ffs@tglx> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Dec 01 2022 at 15:26, Oleg Nesterov wrote: > From: Denys Vlasenko > > Intel icc -hotpatch inserts 2-byte "0x66 0x90" NOP at the start of each > function to reserve extra space for hot-patching, and currently it is not > possible to probe these functions because branch_setup_xol_ops() wrongly > nacks NOP with REP prefix. > > Fixes: 250bbd12c2fe ("uprobes/x86: Refuse to attach uprobe to "word-sized" branch insns") > Reported-by: Seiji Nishikawa > Signed-off-by: Oleg Nesterov The SOB chain is invalid as it lacks the author's signoff.