Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 2 Dec 2022 07:46:23 -0500
From:   Petar Gligoric <petar.gligor@gmail.com>
To:     Ian Rogers <irogers@google.com>
Cc:     linux-kernel@vger.kernel.org, Hagen Paul Pfeifer <hagen@jauu.net>,
        Petar Gligoric <petar.gligoric@rohde-schwarz.com>,
        Arnaldo Carvalho de Melo <acme@redhat.com>,
        Andi Kleen <ak@linux.intel.com>, Jiri Olsa <jolsa@kernel.org>,
        Namhyung Kim <namhyung@kernel.org>
Subject: Re: [PATCH 1/2] perf script: introduce task analyzer
Message-ID: <Y4nzn6FGS0/2BcQP@debian>
References: <20221201193557.65548-1-petar.gligor@gmail.com>
 <20221201193557.65548-2-petar.gligor@gmail.com>
 <CAP-5=fV374SjiMQPsba3Tw2qJwtT8sXneRKAyqnEtCAhJ6FaUg@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAP-5=fV374SjiMQPsba3Tw2qJwtT8sXneRKAyqnEtCAhJ6FaUg@mail.gmail.com>
Precedence: bulk

On Thu, Dec 01, 2022 at 04:05:15PM -0800, Ian Rogers wrote:

> 
> Thanks Peter, Python2 isn't a thing any more. It is worth knowing that
> for python3 you can test old versions easily with docker:
> docker run -it --rm --name my-running-script -v "$PWD":/usr/src/myapp
> -w /usr/src/myapp python:3.6 python <script to test>
> Python 3.6 is 5 years old and what the jevents.py script aims to
> support. This allows type annotations and f-strings, both of which can
> make your code more pythonic.
> 

Good to hear Ian! We have not removed Python2 support, because we still use
the script on older installations where (unfortunately) only Python2 is
installed. But good to know that in future patches you don't have to pay
attention to python2 compatibility anymore! Which Python version is the
baseline? Python 3.6?

> Given the new functionality of this code a test would be useful to
> avoid regressions. You can invoke perf as part of a shell test:
> https://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git/tree/tools/perf/tests/shell?h=perf/core
> The perf command found is the current running perf command, as its
> directory is appended to the front of PATH. Could you look to add a
> test? You could have individual subtests for the different command
> line flags.
> 
> Thanks,
> Ian
>

Great, I will create a patch 3 which will add test support - I already
have a test script. I have to dig into the test system first and port
this script to the new environment

Thank you Ian for your valuable input!

Petar