Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 02 Dec 2022 14:15:14 +0100
Message-ID: <87iliuoskd.wl-tiwai@suse.de>
From:   Takashi Iwai <tiwai@suse.de>
To:     Dicheng Wang <wangdicheng123@hotmail.com>
Cc:     perex@perex.cz, tiwai@suse.com, sdoregor@sdore.me,
        john-linux@pelago.org.uk, hahnjo@hahnjo.de, wangdicheng@kylinos.cn,
        connerknoxpublic@gmail.com, alsa-devel@alsa-project.org,
        linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH -next] The USB audio driver does not contain the VID and PID of this sound card, so the driver is not loaded.
In-Reply-To: <SG2PR02MB5878D3E800F2D571A7C2234F8A179@SG2PR02MB5878.apcprd02.prod.outlook.com>
References: <SG2PR02MB5878D3E800F2D571A7C2234F8A179@SG2PR02MB5878.apcprd02.prod.outlook.com>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0
MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue")
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk

On Fri, 02 Dec 2022 09:29:08 +0100,
Dicheng Wang wrote:
> 
> From: wangdicheng <wangdicheng@kylinos.cn>
> 
> Add relevant information to the quirks-table.h file.
> The test passes and the sound source file plays normally.
> 
> Cc: stable@vger.kernel.org
> Signed-off-by: wangdicheng <wangdicheng@kylinos.cn>

The code change itself looks good, but could you fix the patch subject
line?  It should have the proper prefix (in this case something like
"ALSA: usb-audio: Blah blah..."), and the text is unnecessarily long.
Please make it concise.

Also, could you give the lsusb -v output of the corresponding device?
Just to make sure.  If possible, it'd be better to use the existing
macro like USB_DEVICE_VENDOR_SPEC() or USB_AUDIO_DEVICE() instead.


thanks,

Takashi


> ---
>  sound/usb/quirks-table.h | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/sound/usb/quirks-table.h b/sound/usb/quirks-table.h
> index 874fcf245747..1fb183895da0 100644
> --- a/sound/usb/quirks-table.h
> +++ b/sound/usb/quirks-table.h
> @@ -2802,6 +2802,13 @@ YAMAHA_DEVICE(0x7010, "UB99"),
>  	.idProduct = 0x1020,
>  },
>  
> +/* Ktmicro Usb_audio device */
> +{
> +	.match_flags = USB_DEVICE_ID_MATCH_DEVICE,
> +	.idVendor = 0x31b2,
> +	.idProduct = 0x0011,
> +},
> +
>  /* QinHeng devices */
>  {
>  	USB_DEVICE(0x1a86, 0x752d),
> -- 
> 2.25.1
>