Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp2272142rwb; Fri, 2 Dec 2022 07:39:55 -0800 (PST) X-Google-Smtp-Source: AA0mqf4EyFx1mLxLGe5FEUikkRVVVYVRJsnBugMaIrw+b5oSjhZxaJoNk048zSGr4FLRgmF8cCpL X-Received: by 2002:a05:6402:289d:b0:46c:2460:cdf with SMTP id eg29-20020a056402289d00b0046c24600cdfmr3573854edb.103.1669995595068; Fri, 02 Dec 2022 07:39:55 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669995595; cv=none; d=google.com; s=arc-20160816; b=SyP2hdI4tjdADsFWw/3/Yd1ebCoDUDTZLjGeGOz8XLfS6lz6qdE0cPEo1bQBqyBHKk V61P1tZ24OgifnIlMvf/5mHH5DhkeUSgrtPgdwspAxr3sOYWfJNhydabzbTNa1AvAg5N a3lAfpaScSUElhOH3aJljhesblP0IgPOdGIJLYQ2ywkAFivd3PdXTvFycNbhDZ68M74k sdc3copBp1OpabvIY+291A1s2OUYnIz6tMvOH2ixF7VnIBm3bWt5DKEBhRS0deYRb0ri 4qW5iu8qDeT+rL1s9PWn48nicQpWq7cHAUjpGtX+S0WO1T5p/VcxXkBYkACkKEiQe2Ru Qk2Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=J3OVbZmtrxXPAlk2s0gUETRy7cMOwK//SPYHzR+fMfE=; b=pu4TPqY0H6WTj8PE9vsGcM0U2mPFIvYVscl8fiTRkxDUNJkoFKRVEUoXN400NihI3H f6QsVbCp42h2LvPQxrR3I2SoxkuLI63V27F+WFNgZUhS4btB5XbbOCIpxFXGu260IvLQ aV0FyeYtHj9KEg5V+12gYNUqLwD2XvgyeISl1bdy6BNfHL97N8dkT1nZgYgHmV5Y2YsT qncySH92F/lNrHmWpPFtN64YBmJeY68tKnd1ZRVhSV2WlY0uIB1s2R4ZaKqAs6NfWy0e CCoIuysB71x7aztNaxbh3W4iGq3K48Y0YPnUvTjNiAB2/4TTJehIOsVvu5vxUVVA/sml LiQg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id ji16-20020a170907981000b007833c7cf1dcsi4463249ejc.387.2022.12.02.07.39.33; Fri, 02 Dec 2022 07:39:55 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233313AbiLBPN7 (ORCPT + 82 others); Fri, 2 Dec 2022 10:13:59 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44488 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233765AbiLBPNg (ORCPT ); Fri, 2 Dec 2022 10:13:36 -0500 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D58076D7E8 for ; Fri, 2 Dec 2022 07:13:33 -0800 (PST) Received: from gallifrey.ext.pengutronix.de ([2001:67c:670:201:5054:ff:fe8d:eefb] helo=bjornoya.blackshift.org) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p17jG-0005zw-Mv; Fri, 02 Dec 2022 16:13:30 +0100 Received: from pengutronix.de (unknown [IPv6:2a03:f580:87bc:d400:63a6:d4c5:22e2:f72a]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (prime256v1) server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: mkl-all@blackshift.org) by smtp.blackshift.org (Postfix) with ESMTPSA id 5D0E413176E; Fri, 2 Dec 2022 15:13:29 +0000 (UTC) Date: Fri, 2 Dec 2022 16:13:20 +0100 From: Marc Kleine-Budde To: Frank Jungclaus Cc: linux-can@vger.kernel.org, Wolfgang Grandegger , Vincent Mailhol , Stefan =?utf-8?B?TcOkdGpl?= , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/1] can: esd_usb: Allow REC and TEC to return to zero Message-ID: <20221202151320.7pimdtgqehi4x77k@pengutronix.de> References: <20221130202242.3998219-1-frank.jungclaus@esd.eu> <20221130202242.3998219-2-frank.jungclaus@esd.eu> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="zbmgx7pa7b3psdf2" Content-Disposition: inline In-Reply-To: <20221130202242.3998219-2-frank.jungclaus@esd.eu> X-SA-Exim-Connect-IP: 2001:67c:670:201:5054:ff:fe8d:eefb X-SA-Exim-Mail-From: mkl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --zbmgx7pa7b3psdf2 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 30.11.2022 21:22:42, Frank Jungclaus wrote: > We don't get any further EVENT from an esd CAN USB device for changes > on REC or TEC while those counters converge to 0 (with ecc =3D=3D 0). > So when handling the "Back to Error Active"-event force > txerr =3D rxerr =3D 0, otherwise the berr-counters might stay on > values like 95 forever ... >=20 > Also, to make life easier during the ongoing development a > netdev_dbg() has been introduced to allow dumping error events send by > an esd CAN USB device. >=20 > Fixes: 96d8e90382dc ("can: Add driver for esd CAN-USB/2 device") > Signed-off-by: Frank Jungclaus Added to linux-can. It will go into the net/master after v6.1. Marc --=20 Pengutronix e.K. | Marc Kleine-Budde | Embedded Linux | https://www.pengutronix.de | Vertretung West/Dortmund | Phone: +49-231-2826-924 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | --zbmgx7pa7b3psdf2 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEBsvAIBsPu6mG7thcrX5LkNig010FAmOKFg0ACgkQrX5LkNig 010xqQf+KEMYSuEJz87Zms6RXIkVZFKmW8TXTACOZazR4adl2kyi+FwSwp3TmD1a hurLZLlXR6v475v0rdPebdtUpEk/glg9FfdHhQuCUL+eHEUEkOC0Ou/Yrqsnkl75 25k/+qzmXKo4Wcf1g5lRCRku76kybdbkPyhlLzqx9qzuZREkZ1vjXGFYTFbBYnTJ XOeCDKqker45QQ2Zh7pQjxI8Alg/CGOGpkgpUhZBohWpS5Vcmric2t7Le10Dnikd BB3vion2stmKazY3iK6SeihDp4EkvbT08V05ptnD1EJ77FlAaX+AAXegKSIeDXmG 91o3GwICCcr6tWeKDBNu88/HE1sLUQ== =48WK -----END PGP SIGNATURE----- --zbmgx7pa7b3psdf2--