Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <4e5bbaf8-58ea-5ebe-a585-496ee7b51bce@intel.com>
Date:   Fri, 2 Dec 2022 08:29:15 -0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Firefox/91.0 Thunderbird/91.11.0
Subject: Re: fw_fallback.sh test failed in Debian 11
Content-Language: en-US
To:     "Zhou, Jie2X" <jie2x.zhou@intel.com>,
        "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>
CC:     "shuah@kernel.org" <shuah@kernel.org>,
        "mcgrof@kernel.org" <mcgrof@kernel.org>,
        "Zhang, Tianfei" <tianfei.zhang@intel.com>,
        "linux-kselftest@vger.kernel.org" <linux-kselftest@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "Li, Philip" <philip.li@intel.com>
References: <CY4PR11MB1320DAA7D7972E738EDA754EC5129@CY4PR11MB1320.namprd11.prod.outlook.com>
 <Y4W+/TfM4F9TdSnZ@kroah.com>
 <CY4PR11MB132092589F9270FB559B01D8C5159@CY4PR11MB1320.namprd11.prod.outlook.com>
 <0e688462-7f22-118e-6cb1-de8b582e3973@intel.com>
 <CY4PR11MB13205F799D0A30BB011E4334C5149@CY4PR11MB1320.namprd11.prod.outlook.com>
 <217b7959-facc-1028-19be-1040898a705c@intel.com>
 <CY4PR11MB13206A6918FFDEB5B3D3794BC5149@CY4PR11MB1320.namprd11.prod.outlook.com>
 <57b8f45b-da8c-e9ae-6b3f-ba82f936c9b2@intel.com>
 <CY4PR11MB132068A19AF9704D1B14814FC5179@CY4PR11MB1320.namprd11.prod.outlook.com>
From:   Russ Weight <russell.h.weight@intel.com>
In-Reply-To: <CY4PR11MB132068A19AF9704D1B14814FC5179@CY4PR11MB1320.namprd11.prod.outlook.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cXhLWjZPVkpiNHRxRnNnNGlpb3VhUXhPZVlLd2NkK0NZdU9rM3k1alpZZ2lp?=
 =?utf-8?B?bndTYlFBUjVNbHhqeGg0Q3VlaXRCU0VOOFFLbzdqZ1NkTTZoY3FkdXZlSEJK?=
 =?utf-8?B?TVFRUWdhR21peldzRHhGZWh4OGFVSHNxc2QxaXVGK25IQ0lSOVBDajVxc3Uz?=
 =?utf-8?B?WVNPVkVIVDFUNVk3Y0Z6MXdYb2JJZGxkZnlDWnFDNnBJVU1xRWJWM2VUemo4?=
 =?utf-8?B?ZEFvejlQaklpSWJWS2JueG1KamRyVVFFZ3plRG9oMjFGdnc1eVNDNUN6UW9i?=
 =?utf-8?B?YkNHVU04cUpBSVIwNTlsVjNoQXhucTZLOFJsWHFDTzc0dUVPMmx6Z0VPNUpz?=
 =?utf-8?B?MFl3aTVLMWhlTEkvWFdYQlhBeDdXQTRBUEI5d2wyMXlyVmVYRGpRcjIxODVm?=
 =?utf-8?B?OEYyUkpoWHNlY1hhVzNxbFFCd3VJT1pvUEZwYnh1eVU4c2lXNGFZRmp4M09L?=
 =?utf-8?B?NXRXMHR3VklDRkZWMnM1MmFBQ0xiemFIdngvK3JQelFLODZKNlFEN2xUamxk?=
 =?utf-8?B?WEZPRjgvbmhuWjk5dW1RV0U1RXBFTmdyYUpTRk0vZ3Nib3VtVUljVGJuMTFZ?=
 =?utf-8?B?blFETXdsZ21xeXF5b1dGWVU5S01BWDY4VEFQejR4dTJqWGdBT1FCTVF3OVdv?=
 =?utf-8?B?VmpXWXlidmZJeGE2S1phWU1ybDUxcjhOcERON0dodm11SDE5ZEdOd0dzbUNi?=
 =?utf-8?B?NTRhR0E2QzN6NEE2RmIvL244SFI0R3g4YklFWDdicy9UU3d3LzFHN1dDWk1N?=
 =?utf-8?B?THhmOVRqUnBKN1hNanQwMFIzbWxUNUJseHcyVlBudkRPREhZQ0tCK2dmL253?=
 =?utf-8?B?U09kQUhwRE9QQ1ErWDVNaFhOZDV5UVppYnNHYzJDdWhENHc1R3JJOUdya0RT?=
 =?utf-8?B?ZmtPKzdpQ2tSSWN0ckowMXQwTVEweWpudlNwK00vOEtEbCtQNUQvVndnU1Jz?=
 =?utf-8?B?TDFSZlM4SU5SL1YwVXI5VWN4b28rek05aExIdFJVMTJDNERFdXdSTU1oQldk?=
 =?utf-8?B?QitXTk5CaTdBMWtsbTJnU09ZZEhOV2VEaEk3N3BDSldWaktzYnl6VVZyNytp?=
 =?utf-8?B?anBUcFJTRUJDS2RqMUdqK0dTNFRIamxpOUZuV2pmNFhrbkZmdzlHMTk3eWRZ?=
 =?utf-8?B?aHIyK2pYNEM3UW9jbEVwZXgwTnA1cU1NRDlzT3pXVi9WSmx0MldOckhHTnlB?=
 =?utf-8?B?M21ma3FSeEs3ZDlnSzR5eGlpQkduMmprb05yUUFMYVRPWU1MQXpRZ3JrS2hT?=
 =?utf-8?B?ZTRTMndZejNZZDZZR0xKVGtvTHBZR2VobEZ4NUgvMjZ5bVZ1SU43a2NxU0Rn?=
 =?utf-8?B?dXRCM3Q4Tm9qR2t6MGFQblVBZUE4YUxFSWE4bmlIZXUvTU15L200SnE0dk9s?=
 =?utf-8?B?Q1h2YU1TZCtPTDRCWHJhWTh0a1kwNG8waGk1blJJKzdkUTdDU0dwb0JHTmd6?=
 =?utf-8?B?VzJSd1ltTzlKR082RjRBcHh0V1l1VDZZNXRNejlxK0Nlb0U3NkZ5Z21oNzBr?=
 =?utf-8?B?NTRIRXBnMkkyUzdxZ0R6dkhJd0FobUJlKzF3U0x1Nnlja3pGTGlsVGpvWVoy?=
 =?utf-8?B?UmZKY1RranQ5d0I0aWNuT0VMZmNDVk5uUXcrNmw1a1pqc3UxS3RUM1V6WFhp?=
 =?utf-8?B?L1BGdys0L2dnYUdTYXM0dHRiVzljTCtjdTNkYXhUYk9CaHNPTTJybUV1SmVa?=
 =?utf-8?B?WWZCckhhaGNndGNINnV3YklHSEIyVndsbkpEaHpTNGh1UWFVUkF0M0tQSFdI?=
 =?utf-8?B?Vnd4TEw1WVNENFBxd3hqN3prQ1FnV3gzR1dONklWVGFta3R0RVJRNnhoenNw?=
 =?utf-8?B?M1Q0ampESnBMbkZmdkNLUzVuL0xsU2piNlVRUXlqeDZJL3ZaVXczMlhMOXJF?=
 =?utf-8?B?RjRCRXZlYlYvTHRoN09oKytGanpZNmV0TnE2RWxLN2g3ZXJGSnViNlB5RXh6?=
 =?utf-8?B?Z2M5V0RwMjVkbWpMVkRNTEFWTHlKMCtnUTd0Q0hKUFA1ZEIrcnBYcUtmdGU4?=
 =?utf-8?B?QnhLSHlXTlRvNE84S1IxRFNJNDA4UkdPQ2NkYlU3R3liV295bUszOCt5bUZw?=
 =?utf-8?B?cWJSMVZKMFhQd0FsbFczUVV2QzJDME41MlU3S2VvU0JlbnNYWGl0VFFzb1FS?=
 =?utf-8?B?RVZpMkxmUnU1RDl3WnV0YzUrdDVJbXZxQVh0eXhQRjBqWENzamxBYUF6SUgw?=
 =?utf-8?B?a3c9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 9cbf2e98-79d5-45c5-4c0b-08dad4825d0f
X-MS-Exchange-CrossTenant-AuthSource: DM5PR11MB1899.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Dec 2022 16:29:21.2059
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: IxFtCP3bkwlJrb48akbROJAeClnWSeKj7Seb+Sg04mQK/cab1DcMGHGxKlLehAXN35hc44bRjO7JMFKSzC7Y15TkN9/99DC8hzOAIa9vlqs=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB4711
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 12/1/22 22:02, Zhou, Jie2X wrote:
>> The above message looks like the problem. Firmware sysfs fallback has been turned off
>> on this system using sysctl. Can you try turning it on and rerunning the test?
> Sorry, I don't know how to turn on firmware sysfs fallback.
> Could you tell me?

Take a look at the kernel documentation (https://www.kernel.org/doc/html/v5.0/driver-api/firmware/fallback-mechanisms.html) which says, "This syfs fallback mechanism may be disabled completely on a system by setting the proc sysctl value ignore_sysfs_fallback to true."

Also refer to the sysctl man page: https://manpages.debian.org/testing/procps/sysctl.8.en.html.

- Russ

>
> I search the firmware fallback options in kernel config.
> CONFIG_FW_LOADER_USER_HELPER=y
> # CONFIG_FW_LOADER_USER_HELPER_FALLBACK is not set
>
> best regards,
>
> ________________________________________
> From: Weight, Russell H <russell.h.weight@intel.com>
> Sent: Thursday, December 1, 2022 10:37 AM
> To: Zhou, Jie2X; gregkh@linuxfoundation.org
> Cc: shuah@kernel.org; mcgrof@kernel.org; Zhang, Tianfei; linux-kselftest@vger.kernel.org; linux-kernel@vger.kernel.org; Li, Philip
> Subject: Re: fw_fallback.sh test failed in Debian 11
>
>
>
> On 11/30/22 17:28, Zhou, Jie2X wrote:
>>> How much of this path exists on your machine?
>>> /sys/devices/virtual/misc/test_firmware/trigger_request
>> This path exists.
>>
>>> And is there anything in the dmesg output that indicates a failure associated with
>>> the test_firmware device?
>> Yes.
>>
>> kern  :info  : [   77.858068] test_firmware: loading 'test-firmware.bin'
>> kern  :info  : [   77.864705] test_firmware: loaded: 8
>> kern  :info  : [   77.874250] test_firmware: loading 'test-firmware.bin'
>> kern  :warn  : [   77.880672] misc test_firmware: Direct firmware load for test-firmware.bin failed with error -2
>> kern  :info  : [   77.890106] test_firmware: load of 'test-firmware.bin' failed: -2
>> kern  :info  : [   78.896662] test_firmware: loading ''
>> kern  :info  : [   78.901059] test_firmware: load of '' failed: -22
>> kern  :info  : [   78.907422] test_firmware: loading ''
>> kern  :err   : [   78.912278] test_firmware: failed to async load firmware
>> kern  :info  : [   78.918594] test_firmware: loading 'nope-test-firmware.bin'
>> kern  :warn  : [   78.925405] misc test_firmware: Direct firmware load for nope-test-firmware.bin failed with error -2
>> kern  :info  : [   78.935260] Ignoring firmware sysfs fallback due to sysctl knob
> The above message looks like the problem. Firmware sysfs fallback has been turned off
> on this system using sysctl. Can you try turning it on and rerunning the test?
>
> Thanks,
> - Russ
>
>> kern  :info  : [   78.941934] test_firmware: load of 'nope-test-firmware.bin' failed: -2
>> kern  :info  : [   78.962155] test_firmware: loading 'test-firmware.bin'
>> kern  :info  : [   78.968232] test_firmware: loaded: 9
>> kern  :info  : [   78.986063] test_firmware: loading 'test-firmware.bin'
>> kern  :info  : [   78.992269] test_firmware: loaded: 9
>> kern  :info  : [   79.023611] test_firmware: reset
>> kern  :info  : [   79.028466] test_firmware: batched sync firmware loading 'test-firmware.bin' 4 times
>>
>> best regards,