Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <6970fef2a3826a8f060db2091db87b135a06da57.camel@icenowy.me>
Subject: Re: [PATCH v2 2/6] dt-bindings: usb: Add binding for Genesys Logic
 GL850G hub controller
From:   Icenowy Zheng <uwu@icenowy.me>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Chen-Yu Tsai <wens@csie.org>,
        Jernej Skrabec <jernej.skrabec@gmail.com>,
        Samuel Holland <samuel@sholland.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Matthias Kaehlcke <mka@chromium.org>,
        Andre Przywara <andre.przywara@arm.com>
Cc:     devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org,
        linux-usb@vger.kernel.org
Date:   Sat, 03 Dec 2022 01:00:39 +0800
In-Reply-To: <feb6d0d3-706f-b726-dd13-9ed665a52f9d@linaro.org>
References: <20221202081647.3183870-1-uwu@icenowy.me>
         <20221202081647.3183870-3-uwu@icenowy.me>
         <b4ddf139-5604-bd04-e309-d7bc15e9d23b@linaro.org>
         <2f0f31551d361cf23abdd2c4117f2feb84e2b1a8.camel@icenowy.me>
         <feb6d0d3-706f-b726-dd13-9ed665a52f9d@linaro.org>
Organization: Anthon Open-Source Community
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.44.4 
MIME-Version: 1.0
Precedence: bulk

=E5=9C=A8 2022-12-02=E6=98=9F=E6=9C=9F=E4=BA=94=E7=9A=84 17:59 +0100=EF=BC=
=8CKrzysztof Kozlowski=E5=86=99=E9=81=93=EF=BC=9A
> On 02/12/2022 17:54, Icenowy Zheng wrote:
> > =E5=9C=A8 2022-12-02=E6=98=9F=E6=9C=9F=E4=BA=94=E7=9A=84 10:02 +0100=EF=
=BC=8CKrzysztof Kozlowski=E5=86=99=E9=81=93=EF=BC=9A
> > > On 02/12/2022 09:16, Icenowy Zheng wrote:
> > > > The Genesys Logic GL850G is a USB 2.0 Single TT hub controller
> > > > that
> > > > features 4 downstream ports, an internal 5V-to-3.3V LDO
> > > > regulator
> > > > (can
> > > > be bypassed) and an external reset pin.
> > > >=20
> > > > Add a device tree binding for its USB protocol part. The
> > > > internal
> > > > LDO is
> > > > not covered by this and can just be modelled as a fixed
> > > > regulator.
> > > >=20
> > > > Signed-off-by: Icenowy Zheng <uwu@icenowy.me>
> > > > ---
> > > > Changes in v2:
> > > > - Misc fixes suggested by Krzysztof, including property
> > > > descriptions,
> > > > =C2=A0 single-item "items" and fixing the example's gpio property.
> > > > - Fixed $id.
> > > >=20
> > > (...)
> > >=20
> > > > +
> > > > +examples:
> > > > +=C2=A0 - |
> > > > +=C2=A0=C2=A0=C2=A0 usb {
> > > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 dr_mode =3D "host";
> > > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 #address-cells =3D <1>;
> > > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 #size-cells =3D <0>;
> > > > +
> > > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 hub: hub@1 {
> > > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
 compatible =3D "usb5e3,608";
> > > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
 reg =3D <1>;
> > > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
 reset-gpios =3D <&pio 7 2>;
> > >=20
> > > Use GPIO flags. What did you fix in the example?
> >=20
> > It used to be here, but using it needs another include, which I
> > don't
> > think it necessary here.
>=20
> The header is necessary for the flags...
>=20
> >=20
> > Maybe I should just drop this line in the example?
>=20
> It's useful. The example should be rather complete, not just
> compatible
> and reg.
>=20
> Different problem - you miss maxItems for the GPIOs.

Okay thanks.

>=20
> Best regards,
> Krzysztof
>=20