Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp2412401rwb; Fri, 2 Dec 2022 09:23:43 -0800 (PST) X-Google-Smtp-Source: AA0mqf4xycwHbrDLCmDVxdPMPmNCuonqNlI8k2wMzJ0FBBTNwWKL2POwWjW7PVOeCD9YbI/VBNlV X-Received: by 2002:a05:6402:134c:b0:46a:1d7:c94d with SMTP id y12-20020a056402134c00b0046a01d7c94dmr27574634edw.327.1670001823537; Fri, 02 Dec 2022 09:23:43 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1670001823; cv=none; d=google.com; s=arc-20160816; b=LNOmgxy/oWpOJVFTlwk9P+VugD94cmUs8as5m3WBAW27i++GZwX4X+gFncSFblWfY1 YlYzn7/6cvKXwOyAZPwMOj6vGrW7dNsVIMWeOfoBRyTFG7QVnVQYqPWBNjDGh+Z//++2 FtaRiTYnx/qY9EJ5L7rubjTBqYX68Ng339oOsZ+GAP4uXf2omvWdkl4VCdcoRdDkpDFg 76Id2Zq69BHMm7AXj4xydOTVqbsSeObKy8RQpLHdnzmBzLKjPIM/LtkR7y1Hzu2xR4lB mRbc7iRGd8tFM18MnKug02DADuaIOrOZ8TVzYjh1EamUJodeCMOhgX/2uZo3Kx7h3HU9 yPTQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:subject:cc:to:from:date; bh=pMkOrqvO8tUanPaZglPCzEhUDZAZs1V19fdr0hL8bJY=; b=TfKssTUmsa2aF3GI9P+c4eBo4biP4kYN9mvYG2mBEQ0070Z6sNZ8NWaCAZ4wewk/LR V1/Wm94VSVpznBSxuC+2Dks0XoW1jlPFGd7YoYMBeby/3ZOMvCmCGbrsz/FUHUqjf+80 pUGyJMAGMYclDJk3P3m/KCb1CYRjMI80Xh0zR89R15hQmm4gOWUfgXwZu60wTAZj3wa5 5kNhgxduTy4Qy2v9MiojeB6VYxJmwXWYzXBMTY25r89syu4HQ2ZD0gKwbnN31/qZpaIY gCNAw6npdDQTxR1+8jyExV6HoPOTJD6vnkW0Xv+/oOLRw/9BvKHbhk8nRjBHSZbGCzcr J6vA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id cw18-20020a170906479200b00781b66e7065si1246879ejc.240.2022.12.02.09.23.23; Fri, 02 Dec 2022 09:23:43 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234329AbiLBRAW (ORCPT + 82 others); Fri, 2 Dec 2022 12:00:22 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59116 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234318AbiLBQ7l (ORCPT ); Fri, 2 Dec 2022 11:59:41 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 15F76331 for ; Fri, 2 Dec 2022 08:59:41 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id C3122B821F5 for ; Fri, 2 Dec 2022 16:59:39 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 08DCEC433C1; Fri, 2 Dec 2022 16:59:37 +0000 (UTC) Date: Fri, 2 Dec 2022 11:59:36 -0500 From: Steven Rostedt To: LKML Cc: John 'Warthog9' Hawley Subject: [PATCH] ktest.pl minconfig: Unset configs instead of just removing them Message-ID: <20221202115936.016fce23@gandalf.local.home> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-6.7 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_HI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Steven Rostedt After a full run of a make_min_config test, I noticed there were a lot of CONFIGs still enabled that really should not be. Looking at them, I noticed they were all defined as "default y". The issue is that the test simple removes the config and re-runs make oldconfig, which enables it again because it is set to default 'y'. Instead, explicitly disable the config with writing "# CONFIG_FOO is not set" to the file to keep it from being set again. With this change, one of my box's minconfigs went from 768 configs set, down to 521 configs set. Signed-off-by: Steven Rostedt --- tools/testing/ktest/ktest.pl | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tools/testing/ktest/ktest.pl b/tools/testing/ktest/ktest.pl index 590518144167..56135e7d2295 100755 --- a/tools/testing/ktest/ktest.pl +++ b/tools/testing/ktest/ktest.pl @@ -3775,9 +3775,10 @@ sub test_this_config { # .config to make sure it is missing the config that # we had before my %configs = %min_configs; - delete $configs{$config}; + $configs{$config} = "# $config is not set"; make_new_config ((values %configs), (values %keep_configs)); make_oldconfig; + delete $configs{$config}; undef %configs; assign_configs \%configs, $output_config; -- 2.35.1