Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sat, 3 Dec 2022 01:48:44 +0800
From:   Yujie Liu <yujie.liu@intel.com>
To:     Michal Hocko <mhocko@suse.com>
CC:     Shakeel Butt <shakeelb@google.com>, <oe-lkp@lists.linux.dev>,
        <lkp@intel.com>, Andrew Morton <akpm@linux-foundation.org>,
        kernel test robot <oliver.sang@intel.com>,
        Soheil Hassas Yeganeh <soheil@google.com>,
        Feng Tang <feng.tang@intel.com>,
        Roman Gushchin <roman.gushchin@linux.dev>,
        Muchun Song <songmuchun@bytedance.com>,
        Eric Dumazet <edumazet@google.com>,
        "Johannes Weiner" <hannes@cmpxchg.org>,
        Michal =?iso-8859-1?Q?Koutn=FD?= <mkoutny@suse.com>,
        <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] kselftests: cgroup: update kmem test precision tolerance
Message-ID: <Y4o6fN9kWHW0iJcg@yujie-X299>
References: <202212010958.c1053bd3-yujie.liu@intel.com>
 <Y4m8Unt6FhWKC6IH@dhcp22.suse.cz>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <Y4m8Unt6FhWKC6IH@dhcp22.suse.cz>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?dGCEBsAaOqNyeRILc3VtQPoKTkYFOkLBmE36zWT5+6iahO/5BA0Q2L7MRjJo?=
 =?us-ascii?Q?RYgXmamAhvMWGmL6CdH8M8U9QMTwNpr9rack3UytcVG3IauPxzqxV2dltaLA?=
 =?us-ascii?Q?X19ZWPGh54pQ0jxF+vz/poI0VGFMTy2sAbMH1dVgI9xZcoOA14vmKJ0OB3a/?=
 =?us-ascii?Q?7qQSvpB/5AUz957Q90gCWWqj8iI6yPSV/gvs63mi3SYwqttmO/9ivfLvlIah?=
 =?us-ascii?Q?AvOBzELrUX1c2WTRV73hJhLPf0JuOFUzr+poZUT/OUR+P84EYM3mXPQQ5+kS?=
 =?us-ascii?Q?RslMlCPtFF5tYH5I/rzu9oZwVoUzMUxY5G56HT7tNqxfOKttQMW7tzJ1RI6g?=
 =?us-ascii?Q?YKz3+jxITqQ1BxdBc26X8W9zj+DaWaD+HH4B75WK2fcILSZiJgYk7U+/0FE0?=
 =?us-ascii?Q?VNiZ19uJ/JLXaAR8GFK5bIoIC6+f9MR3LIM6RLhWyS1dk+ToSF3F8F7sHmnO?=
 =?us-ascii?Q?Q8WbkMZ3+qLnjILpAbCE6qf5oO4O4tlUGAfX/uSko/WTy+k0Mrq9O5BJT3wT?=
 =?us-ascii?Q?W8F0qJO3rLNVBpejce/DVs57zdyOH0H+DLlPxK0T9g0+l6rv958kiyf0ws+X?=
 =?us-ascii?Q?LgqTgfmP48m622ZXeTQellJEZmWUtTanl7csqgrmcAmueJMWBPoUWqdlvHd8?=
 =?us-ascii?Q?gwdSk3hYJQNQWVLYJMKAKrGDbUBEVB2uwdBJvIuvetExiQlaA8tdEiclCcld?=
 =?us-ascii?Q?ix3hqMNJxxJKgfmdNbp8C7bJbxxC4vvNC8bCmA5GBkOjDtm2CXgNb4u0nmLP?=
 =?us-ascii?Q?icDEkfjOvr0hnfxAHWLdpHOn1G7TRLKJq6/R4/MM9MQUXLxH9HkRNoyVoBlc?=
 =?us-ascii?Q?gGtxZ7W63L3MfamGw6AykqSdAIp4vP5VYC0MrjLQWVZrxCAJ7B1fL9TijiIH?=
 =?us-ascii?Q?FyfCYELPwddnLMGKHn3F8zrbagMMuHjokZ3OtJlnRn5NDydMDp9IqDTd5mo+?=
 =?us-ascii?Q?oHEUv5m8bUtFpNaRSq8mJP7BV6wiRRD+EbtbU8cdfnnbp6s0UT2ZTGygYelr?=
 =?us-ascii?Q?Gd3+2e0vU8Hn/YX16DRP3lVcCLOhrKV5iXFwxDc5uj5c5PE2WE/zWZRvxdZO?=
 =?us-ascii?Q?qzb876NVZQakFrS4uA7YQDFTxU2XCcv9PnECNxg47oz/sPZRzHtpsdCNUZfa?=
 =?us-ascii?Q?rf8OCtB6cwHDJZZjQE0GeeY1cF9UEabs9eR/d6BPe7jAlourkdt/+K3zyj7H?=
 =?us-ascii?Q?OFO0gn4N2jJp3mnzLg8rDmLgQYlzwvkvP+ufEI+kSabFRbL94Nufs/shxbGp?=
 =?us-ascii?Q?DLquOwkRqbjU8Cei/L1/jmpcZekhfJIDYSlYTePhEHZEyG63RQCV9uVaIAhl?=
 =?us-ascii?Q?xYL5QqvJuaOG/FcSrlEdc+dBYq93nGtR32gh9ViArzhjGbYBKbQxbHa2N2la?=
 =?us-ascii?Q?GR7kEpiJMStCTUNZE1T6zNZQYRtg7VGQV5oMd7KcUe3ITBYoVPEPKY1ghKcx?=
 =?us-ascii?Q?YwjKaaPlfC5xBdyXTcTdVENJb3eOVpmxuCKftSWAdx7BGlf/M97ztPhpXVxH?=
 =?us-ascii?Q?u0CNooLhGkm7f0hOJU6JmmmokJfeSTQa2E7v/9YDtbVKt5oZ4BZKrQEQXd6E?=
 =?us-ascii?Q?zkWT9XOR1w6rIwZ+yuZ4/kWR8sB1eKykelL1ljvW?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 418e6332-2376-4b2b-7756-08dad48dbf94
X-MS-Exchange-CrossTenant-AuthSource: CY5PR11MB6392.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Dec 2022 17:50:49.7720
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 33fsGc+RlydIHiA3ytsSpxmt/OBsU7P/dNYwy44SND+xR9CcMbz2hkvAFP1Q7Vz3kucc4VKsbfViZYyCFNx1iA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR11MB6960
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Dec 02, 2022 at 09:50:26AM +0100, Michal Hocko wrote:
> OK, so this is a full patch to fix this
> --- 
> From 7f338ed952ba4a100822004bc8399bf720b42899 Mon Sep 17 00:00:00 2001
> From: Michal Hocko <mhocko@suse.com>
> Date: Fri, 2 Dec 2022 09:45:29 +0100
> Subject: [PATCH] kselftests: cgroup: update kmem test precision tolerance
> 
> 1813e51eece0 ("memcg: increase MEMCG_CHARGE_BATCH to 64") has changed
> the batch size while this test case has been left behind. This has led
> to a test failure reported by test bot:
> not ok 2 selftests: cgroup: test_kmem # exit=1
> 
> Update the tolerance for the pcp charges to reflect the
> MEMCG_CHARGE_BATCH change to fix this.
> 
> Reported-by: kernel test robot <yujie.liu@intel.com>
> Link: https://lore.kernel.org/oe-lkp/202212010958.c1053bd3-yujie.liu@intel.com
> Signed-off-by: Michal Hocko <mhocko@suse.com>

The failure is gone after applying this patch. Thanks.

Tested-by: Yujie Liu <yujie.liu@intel.com>

=========================================================================================
compiler/group/kconfig/rootfs/tbox_group/testcase:
  gcc-11/cgroup/x86_64-rhel-8.3-kselftests/debian-12-x86_64-20220629.cgz/lkp-icl-2sp5/kernel-selftests

commit:
  1813e51eece0a ("memcg: increase MEMCG_CHARGE_BATCH to 64")
  8046f9500f4b7 ("kselftests: cgroup: update kmem test precision tolerance")

  1813e51eece0a                8046f9500f4b7
---------------- ------------- -------------
       fail:runs  %reproduction    fail:runs
           |             |             |
          3:3         -100%            :5     kernel-selftests.cgroup.test_kmem.test_kmem_memcg_deletion.fail

> ---
>  tools/testing/selftests/cgroup/test_kmem.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/testing/selftests/cgroup/test_kmem.c b/tools/testing/selftests/cgroup/test_kmem.c
> index 22b31ebb3513..1d073e28254b 100644
> --- a/tools/testing/selftests/cgroup/test_kmem.c
> +++ b/tools/testing/selftests/cgroup/test_kmem.c
> @@ -24,7 +24,7 @@
>   * the maximum discrepancy between charge and vmstat entries is number
>   * of cpus multiplied by 32 pages.
>   */
> -#define MAX_VMSTAT_ERROR (4096 * 32 * get_nprocs())
> +#define MAX_VMSTAT_ERROR (4096 * 64 * get_nprocs())
>  
>  
>  static int alloc_dcache(const char *cgroup, void *arg)
> -- 
> 2.30.2
> 
> -- 
> Michal Hocko
> SUSE Labs