Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 2 Dec 2022 19:09:32 +0100
From:   Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= <u.kleine-koenig@pengutronix.de>
To:     AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@collabora.com>
Cc:     krzysztof.kozlowski+dt@linaro.org, thierry.reding@gmail.com,
        robh+dt@kernel.org, matthias.bgg@gmail.com, john@phrozen.org,
        sean.wang@mediatek.com, linux-pwm@vger.kernel.org,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org,
        linux-mediatek@lists.infradead.org
Subject: Re: [PATCH v1 1/2] arm64: dts: mediatek: mt7622: Add missing
 pwm-cells to pwm node
Message-ID: <20221202180932.5k3vymrwds5ssivq@pengutronix.de>
References: <20221128112028.58021-1-angelogioacchino.delregno@collabora.com>
 <20221128112028.58021-2-angelogioacchino.delregno@collabora.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="dbscrtoucbjx3ah7"
Content-Disposition: inline
In-Reply-To: <20221128112028.58021-2-angelogioacchino.delregno@collabora.com>
Precedence: bulk


--dbscrtoucbjx3ah7
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, Nov 28, 2022 at 12:20:27PM +0100, AngeloGioacchino Del Regno wrote:
> Specify #pwm-cells on pwm@11006000 to make it actually usable.
>=20
> Fixes: ae457b7679c4 ("arm64: dts: mt7622: add SoC and peripheral related =
device nodes")
> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@coll=
abora.com>
> ---
>  arch/arm64/boot/dts/mediatek/mt7622.dtsi | 1 +
>  1 file changed, 1 insertion(+)
>=20
> diff --git a/arch/arm64/boot/dts/mediatek/mt7622.dtsi b/arch/arm64/boot/d=
ts/mediatek/mt7622.dtsi
> index 146e18b5b1f4..f321c6d0fd7c 100644
> --- a/arch/arm64/boot/dts/mediatek/mt7622.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt7622.dtsi
> @@ -435,6 +435,7 @@ uart3: serial@11005000 {
>  	pwm: pwm@11006000 {
>  		compatible =3D "mediatek,mt7622-pwm";
>  		reg =3D <0 0x11006000 0 0x1000>;
> +		#pwm-cells =3D <2>;

3 should be possible, too. The driver does only support one
polarity, so it's not really needed, but would be nice for consistency?

Thierry, what's your take here?

Other than that: Who would pick this up, I assume it to go via an ARM
tree together with the 2nd patch in this series?

Best regards
Uwe

--=20
Pengutronix e.K.                           | Uwe Kleine-K=F6nig            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

--dbscrtoucbjx3ah7
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEfnIqFpAYrP8+dKQLwfwUeK3K7AkFAmOKP1kACgkQwfwUeK3K
7AkdtQf9F9zcjUhzj6zMAal2E7Hya0b+VW7ihKDYEKL2u3cIZb0g7U42fx2UlRf0
wuHtFvUTIm1GOTBc/abeiuXLGzxXBm/J59aMlpaEIpJgbuvQTQ0yd9aGEP2EI116
2Ed9QFpv0TNTdm1vhIdPC56P4ZSE3Z574Vv5diLTJVHMHc+Y0pjxU4XniOM9ToKy
3P8UVB9OatIYfjN4PwYDMBDBojK680Y1X7OaWXCYRe0pBSL23UmQ5ZVXrcmRZiib
6nDkZJiTZRIZxnYMp8dwBei1PWgWvMuAT4vBiKGCzTGXEeqT6btQ5QyXWjwDkZ5c
KDN4UAdH/Q1+DOb+mzTaLGoigs/Mgw==
=CI4Q
-----END PGP SIGNATURE-----

--dbscrtoucbjx3ah7--