Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <c347688e-7426-8eda-b618-af64de4af35a@amd.com>
Date:   Fri, 2 Dec 2022 13:10:52 -0600
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.2
Subject: Re: [PATCH][next] perf/x86/amd: fix potential integer overflow on
 shift of a int
Content-Language: en-US
To:     Ian Rogers <irogers@google.com>,
        Colin Ian King <colin.i.king@gmail.com>
Cc:     Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@redhat.com>,
        Arnaldo Carvalho de Melo <acme@kernel.org>,
        Mark Rutland <mark.rutland@arm.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Jiri Olsa <jolsa@kernel.org>,
        Namhyung Kim <namhyung@kernel.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Borislav Petkov <bp@alien8.de>,
        Dave Hansen <dave.hansen@linux.intel.com>, x86@kernel.org,
        "H . Peter Anvin" <hpa@zytor.com>,
        linux-perf-users@vger.kernel.org, kernel-janitors@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20221202135149.1797974-1-colin.i.king@gmail.com>
 <CAP-5=fWKbC_wOLiAnEnPV42mM9fpobJD++wKohFYVU66LdaJ-g@mail.gmail.com>
From:   Kim Phillips <kim.phillips@amd.com>
Organization: AMD
In-Reply-To: <CAP-5=fWKbC_wOLiAnEnPV42mM9fpobJD++wKohFYVU66LdaJ-g@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZDBxOG40N1BIOExmeElUejZUdERMNWlndU4rdHhlVW1kMUZkdUV1b3IxUmlW?=
 =?utf-8?B?K2RSSHYzd09BRnVWZEFvK0RUUGJQeDhMbXc2WC9jd292d0M2VHhOazBQNExy?=
 =?utf-8?B?WXlocHViVVFXdWNPMHRwS1NiNDNTZUVvMTFuMWk2LzYwRzRtZHNHWWVEMXpB?=
 =?utf-8?B?ZE4zbXo4TTZpZFJ4TkU0V3pyQVNrdVNwSmh3cnpHU0VZbnQxdFlidEIzcVFh?=
 =?utf-8?B?RVVuR3IxTjNVWnJkazQwbk9keWdEandLZXhUSjhmNEZNTk5vVk5lNFZhYWln?=
 =?utf-8?B?NTBnWWhHdVZvYWVCSU1WZytaSE1SdUl6OWlsZlZ5SExqUys0TTVEZmFmTXM1?=
 =?utf-8?B?ZjcyM1AvVmtFK2YvR29OcndMSVJCL0Q3RmFrd1pyaWVaVXloSzNXZ2ZUcnAz?=
 =?utf-8?B?cjJQdnhBWkovMHg3aDVlRkZoM2trZll3cFdjZHkyT2xuRnVoYmxPZzl4ekpw?=
 =?utf-8?B?QnNyRjVlOFhTbnpBMXUwMXR4clVBYnNsc0x4WXBObFdkZXNWYWhIV0d6cDFp?=
 =?utf-8?B?b2Y5MlVsaVA3ZzdDSTJnK0JQdnhLVlZMOWdkLzJFUFpLemlGWHNxMjVZK1Mz?=
 =?utf-8?B?L2RZdjRYSDBTbUUxMnI5NmprU1c4YmNGMU5YY0N6eHBCU3ZmcmRPREh2SUZL?=
 =?utf-8?B?Wk9mWmloalN5YXpOSDRydXJYMzFzNXdUMFRkbUI5Z2MvNWYydDdDVXJCOUJM?=
 =?utf-8?B?TjNuNnFWL0pLczNWUWFXY0tQQmYvdnpkdjBtVUZmZmNYVjZUL3VSOHdWeXFj?=
 =?utf-8?B?RUJDTDhHQ1RZRCtJdWpLUk1HWWpsNUN3aFRtb0xjOUN0bVJacTg5c1VUVUZ1?=
 =?utf-8?B?SWpWKzE2Z1FzdmNXVTZSWU1uczl0KytuTk9sY0VtN0FCZ01iNFVsd3hieW4v?=
 =?utf-8?B?ZGh4cUxYUWtTQnFKeXo1bUFBa1RxdUF6TkdiMllHSklNaC81SlhoQlNpaElE?=
 =?utf-8?B?bGd0UFVWcC9tMzdZb0pFUlM4R2ljVXIwQ1N0ZUlya0VEdTJOeEl2Uk5NWUN4?=
 =?utf-8?B?NGJJZkFmcXNCanFsWkpRNG8zRlVjNXdTTmIvMW01cU1NR0YzbWR5MXlKOVY3?=
 =?utf-8?B?blNyQjNyc2ZOMjBlNUNTQnFuOHRXdHBXZDR5dHAwNE9oTkM5M0ptQ3ozK2Zx?=
 =?utf-8?B?Y3I2clNHdVU4SzJmM2g5K3diNHgzdEQvKzJibk1ybkJkeVRHdWtBdktMcFNp?=
 =?utf-8?B?U2xtRnFtV3MvNjJvWWNjSjdQNmpoUHNWdnhLMVlidjRqeXlncjJyWHEzTGFl?=
 =?utf-8?B?ekJUZHJ1K1RCck1mQWpSNjV2OTlsanNWbjlUR1J4cVViOGdmbEw1dkxkZ3dP?=
 =?utf-8?B?aUQ0U1pnWmVtK3I0UXVVc2JkOUNsQzM2aC9FK25Ub0JkOHc1Z2M4Tzk1NTNE?=
 =?utf-8?B?QUJKUnBQbTFFUmh0d2haMXN1N0JqRjlrVU5GN0MvajI4SU5PNHZOcEVMZHN2?=
 =?utf-8?B?aDJYM2xpc04vUVkrWitESU85RlphajRkNzVVNmVYeU9GK0VxTHpqRE41Umtq?=
 =?utf-8?B?NDY5KytTOXZXTGxnY1U4SC9OTGNlZXJaTHgxTTFCQjc1aGRKWG40ZHF3Sk1r?=
 =?utf-8?B?TzlVdDhkRGRHNkI0cUhFUHRjYzNRYmxyNEZPMDhRcDNjNVJZZDlMOCtwUEVW?=
 =?utf-8?B?VStqQzBOcGwxZ09uRVhkTjFOa2Y4MnFmd2hleDFaVTcvYk5rNHYvL3cvemRk?=
 =?utf-8?B?NVA2T1E1N292TDJwNkhQNzRsZ2JYWkRFWU8rc01JbmxHbHRsTlBPdkNqeUZK?=
 =?utf-8?B?SkZhWG10NGI5SmNhN2dVNVZjNDVjTzBsY0FaelRRd2grT2FzM0RhcWx4Ync2?=
 =?utf-8?B?N1RhNFBKQjJVOU8zTnBlTllpY2ZjdDNDTWxyQkRFYlFuN1JXQXFqNXZDdVo2?=
 =?utf-8?B?bFhuZDBxam1McVo3dWozcUdxV1BjOSt6Unl4Wkhoa21va1ZQZkh1OWpiOEZm?=
 =?utf-8?B?ZHJuWUtsS1crMVNmcXpneGxudUxlSEFjS2Nncll5c0p4bmlKMWxrUG93dTNz?=
 =?utf-8?B?Rnl1bkJSTkZHQmFzMVhYb2szdm9wK29yckl2MWtHczVzVFlubzV3dE5LaVBJ?=
 =?utf-8?B?YUFIb3Nqcmdhd1d4TDhCYmYxUmloVlpMMHloNFprUFVwS00xK0ExU1lLSXN6?=
 =?utf-8?B?ckh6aW5MTnB0SmJpYkNpTUM5RUUvSE5oVXpzejJ6bkNDQUYvRmJ4LzBySHcy?=
 =?utf-8?Q?swAmEw6UZrBfAVHsFsHsHQtNwE/mJp20dnX/TJRxuRz8?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a0938c36-8b5f-4a30-654b-08dad498f108
X-MS-Exchange-CrossTenant-AuthSource: DS7PR12MB6263.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Dec 2022 19:10:57.1729
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: iUMziUs6AglfWUEZHGL7R9kkzMZbxmx4vVgjmJVfXXUCzSLHff42QVqnt4t+eKKPqjH7MUISPnzqWWwdh2Bvtg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR12MB7416
X-Spam-Status: No, score=-2.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 12/2/22 11:36 AM, Ian Rogers wrote:
> On Fri, Dec 2, 2022 at 5:52 AM Colin Ian King <colin.i.king@gmail.com> wrote:
>>
>> The left shift of int 32 bit integer constant 1 is evaluated using 32 bit
>> arithmetic and then passed as a 64 bit function argument. In the case where
>> i is 32 or more this can lead to an overflow.  Avoid this by shifting
>> using the BIT_ULL macro instead.
>>
>> Fixes: 471af006a747 ("perf/x86/amd: Constrain Large Increment per Cycle events")
>> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
> 
> Acked-by: Ian Rogers <irogers@google.com>

Acked-by: Kim Phillips <kim.phillips@amd.com>

Thanks,

Kim