Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Sean Anderson <sean.anderson@seco.com>
To:     Andrew Lunn <andrew@lunn.ch>,
        Heiner Kallweit <hkallweit1@gmail.com>,
        Russell King <linux@armlinux.org.uk>, netdev@vger.kernel.org
Cc:     "David S . Miller" <davem@davemloft.net>,
        Tim Harvey <tharvey@gateworks.com>,
        Vladimir Oltean <olteanv@gmail.com>,
        Eric Dumazet <edumazet@google.com>,
        Paolo Abeni <pabeni@redhat.com>, linux-kernel@vger.kernel.org,
        Jakub Kicinski <kuba@kernel.org>,
        Sean Anderson <sean.anderson@seco.com>
Subject: [PATCH net-next v3 0/3] phy: aquantia: Determine rate adaptation support from registers
Date:   Fri,  2 Dec 2022 13:17:15 -0500
Message-Id: <20221202181719.1068869-1-sean.anderson@seco.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?PgLD9AEBh0FdYusD3j05k77UwaC1W96v7v0DSC8I8sBclHWqT4yaMHhW0cGF?=
 =?us-ascii?Q?mSVBjAiUFQdXFMrfsHy8rMXQ2kWlt0JNQZcVnY99mWq0fT8dVUo3cnC1Hii5?=
 =?us-ascii?Q?Ro+GsWlti7izDu3S21nquBXLybbuzTCzn+w8lembmJ9HT2xQRFu0Y/zQfcVC?=
 =?us-ascii?Q?R7rHbbfM8QuMpsjroAept3mlrLyOpZUbq4eR76ke0BXdi1kH49MApZdrmDPo?=
 =?us-ascii?Q?oqji/Tg9Vj9DbQDNnlQfHjEXZVJm4z0PG0Vs+NzyJx3B9lmEM3FXm14/Vp6d?=
 =?us-ascii?Q?5/nvXme/UC/v5cWmXxfpRdpB2njqfCMNbKv82HW7VQRpuLS7srkHFtDcukz7?=
 =?us-ascii?Q?KVp5Nq8RQdWZTKzxn6Ql08L6vf3vgml388pN5Z7z6b3pAaQIkdarkwQJ1qwG?=
 =?us-ascii?Q?m/M1D+A31VxTLTy111q9g2AuEKRXL1BXw2Vmy305j6dQifddKFnNd2lqtd2/?=
 =?us-ascii?Q?bBqyneRLML8t9Vjk+h1jvqibMpXcFscnYvLkdMa3a2VvsRmP37ZMjAvUTBht?=
 =?us-ascii?Q?nBktNatzsqI9D+HxwWJt3Jlr/K2HqEJXkZUvdk9qrKqYbGaX8JSFY9/4tJVs?=
 =?us-ascii?Q?GrRmBjUbHtpa9lgozGGEx37zMZBYLZDeMvfVOOl/d6+QExku926lZ3lPbpe+?=
 =?us-ascii?Q?9GSNVP0WQ2Ut1sXjKlPGyo6yrNmZVkedJktj0R3dAgHtWluAl4LChF3+aYDo?=
 =?us-ascii?Q?U9cQMgGcTWAJBFtdbAnrSMYpvPtzMoHsaXtTquE32eGJXrfcGLq8zR4AZWWZ?=
 =?us-ascii?Q?yrKkCkWjRlINPQhwP/VwsMPEqLi15DB8vB6jp9dp1iMqdtjdWtZvYEEQL0za?=
 =?us-ascii?Q?qvr6WWwfaJLy83oj0sgYHZcM4r4gRwnTqiDINS2K1VFBg0F7mbXMN98TFQwQ?=
 =?us-ascii?Q?ft8I/8R8/cQaGWejdMK25iQegKhb0FtWc718lJNawQlFsAtXXq0GwOBBx0C6?=
 =?us-ascii?Q?IYM585mOik4lXtH8JgBjpbL/OvO+bIEjstkJFuMUUPuXcUt0iaEzTJVzx/HZ?=
 =?us-ascii?Q?zQV2FD5Zypv/Ci8hG/O6bc5K2bZ9FWaT5tt7NvlwvvN23M7A31YBij5tWNHx?=
 =?us-ascii?Q?ToKZwqHDySd8qZ0SaoSHtqjqzkiTjky0FGynI5u+Tfo2qmwbSq8ImvTMnNo8?=
 =?us-ascii?Q?GI4Han5TXHyrg/W5QZvVdfyFaBJ2bSiqiHnDLqTzcljLnoxYXoW8O04Zs7qN?=
 =?us-ascii?Q?dT06Rr5VFjQULf7kU/X4NdI46cOEpd1L+cXWtLC/ep/SzRW/v7+SfP4WPSVu?=
 =?us-ascii?Q?Kcp8GFjGAw0IKV0oLRuOFoLMP0s2hr0Nc8QP/RtmnsmAkhkb4GqZR75DBdtO?=
 =?us-ascii?Q?NlukdPwgnfmv70DgGgmpnxHh++NMAjzTRfWh419ibOGwF3dDOUpQYFEVeRdw?=
 =?us-ascii?Q?DgCoBgQsED8joQdsXA8qwW7212e21Qvd6XTbq3MbUXq02zUJ5NRXlpitjxn5?=
 =?us-ascii?Q?qM5MRUaMazDhz/sRcMNqA1codIeeHFeJEMARzc3hcTvbrq7UfwaSWW5J7n5V?=
 =?us-ascii?Q?XaZBm1kWULzTA4XVNGF5h4qSERjZ/iuy4ywfGWyFF84VLkYHFYmmZoC5Q2hC?=
 =?us-ascii?Q?mhm9Ypk4cT98gJCKk6fCtkjirY7kHiW8HVdV/g4q2uBBoVEn9argcf5tCOYN?=
 =?us-ascii?Q?Pw=3D=3D?=
X-OriginatorOrg: seco.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 32ff6a25-478c-44b5-5e0a-08dad491790f
X-MS-Exchange-CrossTenant-AuthSource: DB9PR03MB8847.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Dec 2022 18:17:30.8392
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: bebe97c3-6438-442e-ade3-ff17aa50e733
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: YOFnrXF2c3b09ALDfbPtOfRLQ3sJapKtINv438fwB00isXxW5qZHwyHrI7OB7cRaWJg/JclZp9eUHx8FaWdGIQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR03MB7081
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

This attempts to address the problems first reported in [1]. Tim has an
Aquantia phy where the firmware is set up to use "5G XFI" (underclocked
10GBASE-R) when rate adapting lower speeds. This results in us
advertising that we support lower speeds and then failing to bring the
link up. To avoid this, determine whether to enable rate adaptation
based on what's programmed by the firmware. This is "the worst choice"
[2], but we can't really do better until we have more insight into
what the firmware is doing. At the very least, we can prevent bad
firmware from causing us to advertise the wrong modes.

Past submissions may be found at [3, 4].

[1] https://lore.kernel.org/netdev/CAJ+vNU3zeNqiGhjTKE8jRjDYR0D7f=iqPLB8phNyA2CWixy7JA@mail.gmail.com/
[2] https://lore.kernel.org/netdev/20221118171643.vu6uxbnmog4sna65@skbuf/
[3] https://lore.kernel.org/netdev/20221114210740.3332937-1-sean.anderson@seco.com/
[4] https://lore.kernel.org/netdev/20221128195409.100873-1-sean.anderson@seco.com/

Changes in v3:
- Update speed register bits
- Fix incorrect bits for PMA/PMD speed

Changes in v2:
- Move/rename phylink_interface_max_speed
- Rework to just validate things instead of modifying registers

Sean Anderson (3):
  net: phy: Move/rename phylink_interface_max_speed
  net: mdio: Update speed register bits
  phy: aquantia: Determine rate adaptation support from registers

 drivers/net/phy/aquantia_main.c | 160 ++++++++++++++++++++++++++++++--
 drivers/net/phy/phy-core.c      |  70 ++++++++++++++
 drivers/net/phy/phylink.c       |  75 +--------------
 include/linux/phy.h             |   1 +
 include/uapi/linux/mdio.h       |  22 ++++-
 5 files changed, 249 insertions(+), 79 deletions(-)

-- 
2.35.1.1320.gc452695387.dirty