Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp2580092rwb; Fri, 2 Dec 2022 11:47:01 -0800 (PST) X-Google-Smtp-Source: AA0mqf6JACOph258y914yc8Y8BxZCHUjZ3XSLab7KYTSX3zC6Tssrrbdkqr95M2/yuzhUzJ/YA1x X-Received: by 2002:a17:906:190d:b0:7bd:1f71:ee0e with SMTP id a13-20020a170906190d00b007bd1f71ee0emr30008999eje.714.1670010421428; Fri, 02 Dec 2022 11:47:01 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1670010421; cv=none; d=google.com; s=arc-20160816; b=e6IJ51zmAiqKPY4F21zAkL2RGrUXP1BGMPTfc9qfL+k/Fmt3WVM70wVURImjqGYVUb pitfiK/tFbIU9qShM/LgOLDA7+q9sh+haSeYgIFIJ1cIxBAxMhZclmUn7gxobUJqw7Ul Wc88jxQYU7hX2f48RasYpYevEoDmx1FcTXQTIM4ogQQfFY5cXuIJXZDRt74t6/7erjxE 1cv3xJUd5UeqhTinLARPgRNKE2alSYjGi4iLy1SFzg3UvMVrT/YRhL/E1h7USstPNdXV mDULx1IyQQRGdV2B+xHLkTuZ1nlxqetZDiyC1NnsDmQzR8qJrCz8cA4FTiyDrEUg5Clb 1KkA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=KPAEThHQYkAoxRgOP0gcMQ7C7LKoqBRopPsonFY0Z1c=; b=RWbxtOkIABMg7cvxSvauii97wX7ngZqH5t7j0FgGNLphHpYSS3bFB+DkktXGPYQiug Hzpf6iAKW2Omsi1CsYstChKtcJ8GKo7spW6PdWrw2vq7WvgCzm9TJU65YjDAEb0Fw5gE SMyyp8qBnMn+jXrLERiKzCLrWFiY9mXrcxf2+n3wfczhpUetVNFnY1J1wC1HGSPTRzim 6UWVwjLrYGyp8IFA/Ys5/NvibMu/zVlwB0PlCWBjleBziw0b/eHv6AlpIkHmCoTfo0zz 54YeSLFCETJF+wP3IiLUIKbp4IAEAMMc5FqNEd7rEbfuW6SRGB6QUApqi79L2X7KfdCT 2nZQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=DxMLWKoE; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id w15-20020a056402268f00b0046acab646ecsi7981213edd.81.2022.12.02.11.46.41; Fri, 02 Dec 2022 11:47:01 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=DxMLWKoE; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233664AbiLBSc2 (ORCPT + 82 others); Fri, 2 Dec 2022 13:32:28 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36644 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234472AbiLBScQ (ORCPT ); Fri, 2 Dec 2022 13:32:16 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DA152E98BE for ; Fri, 2 Dec 2022 10:31:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1670005878; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=KPAEThHQYkAoxRgOP0gcMQ7C7LKoqBRopPsonFY0Z1c=; b=DxMLWKoEiwLt2DpYxATLt3sNoZxzGWpa+wQpW2/YkbMl9iin+4Ok4ELgEidFE9WQoxD13w LdZd91lC60C6zn9CxUynivtdYmCxWlkhQbSxu7Zgwi9xCuor2rZwgkpJezIGUoq84Crw0S nvvkYsddCL5pKhsLXr7YHjF5ajs+s6Q= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-115-kHGVc2Z5Nf-YUN5zaoNnIg-1; Fri, 02 Dec 2022 13:31:16 -0500 X-MC-Unique: kHGVc2Z5Nf-YUN5zaoNnIg-1 Received: by mail-wm1-f69.google.com with SMTP id o34-20020a05600c512200b003d07ee4a667so1546464wms.0 for ; Fri, 02 Dec 2022 10:31:16 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=KPAEThHQYkAoxRgOP0gcMQ7C7LKoqBRopPsonFY0Z1c=; b=sKR4/5wdJqOLnI4m9VXpjyj0b+PwAkeDUPDnfZF4GdGAW5q1JJ4wqbDZLwMJ/Zg2+w jcD559hFxzgCuTgdvXpkhh+YBttghrGVTX5iyWN5CMOQMmek6DA6oAH9SIEWUfdoYDHh 9O8F4/9uaK2a8aYMa2mNECOTgipGbhs8WZtEC+T9l2514kkUUTXiPHltk9a0VBo3gr+s h6x6bS8K/a+Lbi/TPqRpsPriAKaCy0OyA0t+rwDqkStmmG6GG4tOkLv+NSlhxoYMGJeK cGMMDULnTsu4M3orM9DQqkGvrUaX1/wIIDzhQ/UZ8DCSo7NOCdczsAemlW6xwInNInMP VXhw== X-Gm-Message-State: ANoB5pl5jf5Y7mXOl7moJo5OKgVzJSG+illoUlQkTQGgy2YhfecMSL1W sI/YmXNn6G7z6kuuVTr5zWCGKSgaJcrppEzTzES6H0mkpCL68luqldDh8C15MIqONpBG1VZDIdo E6aKvGnV90ejov2ZDS7TmpkVa X-Received: by 2002:a7b:c8d0:0:b0:3cf:ca91:7094 with SMTP id f16-20020a7bc8d0000000b003cfca917094mr52829040wml.24.1670005874952; Fri, 02 Dec 2022 10:31:14 -0800 (PST) X-Received: by 2002:a7b:c8d0:0:b0:3cf:ca91:7094 with SMTP id f16-20020a7bc8d0000000b003cfca917094mr52829022wml.24.1670005874693; Fri, 02 Dec 2022 10:31:14 -0800 (PST) Received: from ?IPV6:2001:b07:6468:f312:9af8:e5f5:7516:fa89? ([2001:b07:6468:f312:9af8:e5f5:7516:fa89]) by smtp.googlemail.com with ESMTPSA id z10-20020a05600c0a0a00b003c70191f267sm15432586wmp.39.2022.12.02.10.31.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 02 Dec 2022 10:31:14 -0800 (PST) Message-ID: Date: Fri, 2 Dec 2022 19:31:13 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH 10/14] KVM: x86: Remove unnecessary export of kvm_vcpu_is_reset_bsp() Content-Language: en-US To: Like Xu , Sean Christopherson Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org References: <20221114095606.39785-1-likexu@tencent.com> <20221114095606.39785-11-likexu@tencent.com> From: Paolo Bonzini In-Reply-To: <20221114095606.39785-11-likexu@tencent.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A, RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/14/22 10:56, Like Xu wrote: > > Don't export x86's kvm_vcpu_is_reset_bsp(), the helper isn't used by > KVM x86's vendor modules. Move up the code block out of existing > callers' need. I'm not sure why to move the code up? Paolo