Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp2590172rwb; Fri, 2 Dec 2022 11:58:47 -0800 (PST) X-Google-Smtp-Source: AA0mqf6MmnurLpCq9VmCJVZ597a3J/KAhDXvPoKjNHtQelGqyi5FGFzJlMlFr97uXCt2L7zVW0i+ X-Received: by 2002:a17:906:80c2:b0:7c0:7db7:e1af with SMTP id a2-20020a17090680c200b007c07db7e1afmr19092108ejx.596.1670011126989; Fri, 02 Dec 2022 11:58:46 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1670011126; cv=none; d=google.com; s=arc-20160816; b=TflqV7i/b7jKgXkeAJtCZQRnGZXMa+D1lEq2SYVMkJhWAhqrBKxoOmB2EWsoY4+oHw XM8suBNP/DOELjReqoE0qg2IBqpzL0pzpKSumRp2WQnIzm5ubg9CbonL+SoImDz+F6kE iz1k4f4QqXEdJrv0UFUV6Y0M5ko9bW3uZjp6OMfnXSFOvimxLvUdGS903FIfiOW3nfW+ NEuD8+dJ+yLFkCxBO2fnSWHJg0lM4oGmIW5Kb2S8DYK9QfDHwTFbC0yy0vmOz2GSTtgX 6l9qzp0/Xb7xyJGgucXDJKAX5P1Ev72S+e725Pk0R37p4huVWhk6Jras0xfjdUPlsuAR 3QIg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:message-id:date:references :in-reply-to:subject:cc:to:dkim-signature:dkim-signature:from; bh=hjDSkUH0p+tY8l0rmcBtgIY2pcEuGoRGi40mhKIE2SY=; b=nufB59ay4nhsVjdHZV7+2OLhZ1nxsSt5XkLKYzYhgRc8G1UcFeONKNtFIP/aqrbnNT lQpo/oBDJhoUEhHV9d4aKaiuT4q7u1iOY0ez3ifWZmxmEF/RrHY/HzqFYb395AxwVZ+r CTK/HtHFoGRU9h85hSSFOljTIEdrxLjttfsqvNPBpx6EgDQZI+qmb12Y7Z55mVh9nHfK eY3MJIpHBEo6YKk4FI6ivghHBNRt4A/xGdFT6yFkRIqJl4WMufTcm5F/z02+lvpv5a4b ou0PQzxXt84CBLlLU8mDBoJZNo3Fn8DZ+hgP4WTWvklF3qLfqhp0e0ZEZ4t2yxC+MH2M bhlw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=A5Cdhnpm; dkim=neutral (no key) header.i=@linutronix.de header.s=2020e header.b=4kpqtHHv; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id ss28-20020a170907c01c00b007adc8c49d83si5694296ejc.477.2022.12.02.11.58.26; Fri, 02 Dec 2022 11:58:46 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=A5Cdhnpm; dkim=neutral (no key) header.i=@linutronix.de header.s=2020e header.b=4kpqtHHv; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234777AbiLBT3t (ORCPT + 82 others); Fri, 2 Dec 2022 14:29:49 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57814 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234167AbiLBT3q (ORCPT ); Fri, 2 Dec 2022 14:29:46 -0500 Received: from galois.linutronix.de (Galois.linutronix.de [IPv6:2a0a:51c0:0:12e:550::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EC181EC80E for ; Fri, 2 Dec 2022 11:29:45 -0800 (PST) From: Thomas Gleixner DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1670009384; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=hjDSkUH0p+tY8l0rmcBtgIY2pcEuGoRGi40mhKIE2SY=; b=A5CdhnpmJv/Ucs9jhukCRT+TAIyOTXmaZcx6PSknpfwM+sSpNPYNnL0qRLW0FtsTije5KV 5+vWHvDKGhvQQa/uzr5M3EDrb6JXGspPD24X+renn3XJG0ORpO49wN2prqIn2yW7drr87I m9pq03/E2far2fZXin9hVgO8kIK7n2G6sC1iulfPlYfCqPKhkoJb4TD6Z8NBX9/1j1IvpO YHsMVN7BmcOSyr0XivT8q2j1Pspq7ZdCs9yHWq0h8KHj7bFknllCQS+LsWXrmdDXinUgDU eyi1I/GKNRLM9i07mg9hG6Ic061BFxd7O7UK9f/hNJUbrhs1/TI8I9xb+MkYbA== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1670009384; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=hjDSkUH0p+tY8l0rmcBtgIY2pcEuGoRGi40mhKIE2SY=; b=4kpqtHHvDB36JlGi87jNK4zrXZFvAPiqkx8/E5xlj9ik9rXQELs2YO8fy1UiTeGafbvSmI iMUyUvCVJBjPT6AA== To: Ashok Raj , Borislav Petkov Cc: X86-kernel , LKML Mailing List , Ashok Raj , Dave Hansen , Tony Luck , alison.schofield@intel.com, reinette.chatre@intel.com Subject: Re: [Patch V1 6/7] x86/microcode/intel: Print old and new rev during early boot In-Reply-To: <20221129210832.107850-7-ashok.raj@intel.com> References: <20221129210832.107850-1-ashok.raj@intel.com> <20221129210832.107850-7-ashok.raj@intel.com> Date: Fri, 02 Dec 2022 20:29:44 +0100 Message-ID: <87y1rpob87.ffs@tglx> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 29 2022 at 13:08, Ashok Raj wrote: > Make early loading message to match late loading messages. Print > both old and new revisions. > > This is helpful to know what the BIOS loaded revision is before an early > update. > > microcode: early update: 0x2b000041 -> 0x2b000070 date = 2000-01-01 > > Store the early BIOS revision and change the print format to match > late loading message from microcode/core.c Cache the early BIOS revision before the microcode update and change print_ucode_info() so it prints both the old and the new revision in the same format as $function(). > */ > static void > -print_ucode_info(unsigned int new_rev, unsigned int date) > +print_ucode_info(int old_rev, int new_rev, unsigned int date) Oh. Forgot to mention that before. Can you please get rid of this pointless line break after 'static void' ? > { > - pr_info_once("microcode updated early to revision 0x%x, date = %04x-%02x-%02x\n", > - new_rev, > + pr_info_once("early update: 0x%x -> 0x%x, date = %04x-%02x-%02x\n", > + old_rev, new_rev, > date & 0xffff, > date >> 24, > (date >> 16) & 0xff); And while at it also consolidate these arguments into a single or at max. two lines? Should happen in the first patch which touches this function. Other than that, the code is fine. Thanks, tglx