Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 2 Dec 2022 11:31:28 -0800
From:   Colin Foster <colin.foster@in-advantage.com>
To:     Rob Herring <robh@kernel.org>
Cc:     linux-renesas-soc@vger.kernel.org,
        linux-mediatek@lists.infradead.org,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        devicetree@vger.kernel.org, netdev@vger.kernel.org,
        John Crispin <john@phrozen.org>,
        Alexandre Belloni <alexandre.belloni@bootlin.com>,
        Claudiu Manoil <claudiu.manoil@nxp.com>,
        Marek Vasut <marex@denx.de>,
        Sean Wang <sean.wang@mediatek.com>,
        DENG Qingfang <dqfext@gmail.com>,
        Landen Chao <Landen.Chao@mediatek.com>,
        =?utf-8?B?bsOnIMOcTkFM?= <arinc.unal@arinc9.com>,
        Vivien Didelot <vivien.didelot@gmail.com>,
        =?utf-8?B?Q2zDqW1lbnQgTMOpZ2Vy?= <clement.leger@bootlin.com>,
        Alvin =?utf-8?Q?=C5=A0ipraga?= <alsi@bang-olufsen.dk>,
        Linus Walleij <linus.walleij@linaro.org>,
        UNGLinuxDriver@microchip.com,
        Woojung Huh <woojung.huh@microchip.com>,
        Matthias Brugger <matthias.bgg@gmail.com>,
        Kurt Kanzenbach <kurt@linutronix.de>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Eric Dumazet <edumazet@google.com>,
        "David S. Miller" <davem@davemloft.net>,
        Vladimir Oltean <olteanv@gmail.com>,
        Florian Fainelli <f.fainelli@gmail.com>,
        Andrew Lunn <andrew@lunn.ch>,
        George McCollister <george.mccollister@gmail.com>
Subject: Re: [PATCH v3 net-next 05/10] dt-bindings: net: dsa: qca8k: utilize
 shared dsa.yaml
Message-ID: <Y4pSkOFaGQKc7j/6@euler>
References: <20221127224734.885526-1-colin.foster@in-advantage.com>
 <20221127224734.885526-6-colin.foster@in-advantage.com>
 <20221201224240.GA1565974-robh@kernel.org>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20221201224240.GA1565974-robh@kernel.org>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?2Kd/z5rEr/ry1LVUu8IwMHuCR/kwx6pD2EOTkYXbzntU0tLkAkn4HUSpN0CT?=
 =?us-ascii?Q?O0xKv+KDLEy3ojeHsNF2t+/VpQ2a2213s0NtlDxShhrkmb7RCzb1htZR18hu?=
 =?us-ascii?Q?zB1ubZBrNyktUGRlQ9p1x2cWmMGAR6V2Ak6zHKpwYsmC7KMX5+xmrn6Wu9RB?=
 =?us-ascii?Q?9ybmxhp0vXCsT9jJbwEJgz71cuCu6iZlc1Dzweg5aZbrgUkovLg4YFoUettd?=
 =?us-ascii?Q?QStizf1bxTKD6k258QEL02KL4FxUsaBHEeKzWj8qEFzOzIYmY7AQAP4Zl3b9?=
 =?us-ascii?Q?H4lCDbm4K4x1qV7Jul28waljBrv0rm8rmIZByI0Dg9x9qQfyEd4aikC91NVs?=
 =?us-ascii?Q?AH8XL9XUNOOjOqAYqaQRE1/gD6sBl8FiPzohyPSr63HMcraiPHbRfNuBKHrU?=
 =?us-ascii?Q?KmTxpwaw8K64O3l8EcEyxjFeqW91aerpd+IAxe1H2BjWsDfFxRDxlbv96yCT?=
 =?us-ascii?Q?oqRF3g8EIrGI1pMU2Qo89WFWHpoBVlFzTbBArGd5a4QY4crUC2LHUqC03SRW?=
 =?us-ascii?Q?ZxMge4EdN+vcFl4iti+X8mZ1+dauYpifKeKc5xpujPxpZILZqDgk+NDJtHfC?=
 =?us-ascii?Q?VJdl7UPf4rLvTfCCgWEyF1lupVa2SzhpH+AtpCn6A6e7Nkl2DcT7vYAi8y/r?=
 =?us-ascii?Q?zNoZfVlrPj2Z/vtSviDUf6lzfuhmPl6AEwQJyv+zIP9ceLfjM76/16yyOJW7?=
 =?us-ascii?Q?jCaox1VTp70WC9oBCzg5Uxo0EDgONZwSwdyK7JiUdpUkgjXiOwV4qVkmPRyE?=
 =?us-ascii?Q?UJ4x3LCFhB0UrCNbUVMbDXffoY2o9XmX8Rhomhpz7i3hVJQ9UgP7u0WN1+M5?=
 =?us-ascii?Q?lDs2Aa/BsK5oloQWvYo9alkXwaf9PRdGUThQ9PycGOdgNEj34P5TSAdfsCre?=
 =?us-ascii?Q?HcFDals3N0Jlrh6nQ/QAmVLhaOXrWbZkVVa1mXCvb8ayFIp4HwzsKAJ/oOoZ?=
 =?us-ascii?Q?iE5LcNcq7QdIBcqGm4pAmpLe/ATcw75UxhfCEXVuDuv63umzC+Al65mrgCwA?=
 =?us-ascii?Q?WUibV4/+lN5qNqhZGfwpNKICy1SqF1UNXHsu9Tq6Gj5rVcSVRLUGErtb9aRn?=
 =?us-ascii?Q?Jx2QN5MXVHery18wijgKHtUIwpj4fJVawwyobCvqke23TVYvkMByW6HkfMAR?=
 =?us-ascii?Q?OSI8c3pVB+kciziQ/W1Z0MB0fn32kVUqZm3qJFFjFrtJSN3pkZbDbWL80z96?=
 =?us-ascii?Q?xUTvB2Fuudrc7/fvL8EBFBiAsQtj1F9r+GmRCU8oEpR/j0F7ZMggCaZjbN7N?=
 =?us-ascii?Q?sDNWsvY+E5INRgd9RnpxrapbP90VPzgUf8lkDsRbIfeGEVxR/cSnbIyqkNJv?=
 =?us-ascii?Q?aPYdipJTp9Cti2Ty9iOru8VxSXkasrbZlYCdtedL+g/BvR/c1ejxG9nM4WFA?=
 =?us-ascii?Q?ZF/k/N0Tt7pXrryY4aXkCs0oH06M88tU7J+0WUvGTFR/SDzSvzGxgIbVBrXc?=
 =?us-ascii?Q?chCscZ9rjD79FQae+bu5xB5W8hI3BoKVVZTDeS4AFQxEQHZScCwIT6EKPkD5?=
 =?us-ascii?Q?DdNXQWra08Xm9r/ioKHfbdAO/XAZFlBz71LOqGUhUYJa838xzklRvcfnJS/P?=
 =?us-ascii?Q?sK0jUBd2dxfplkGMr50YjSpmhFDwRaO/OLnmYaW14CgDs3f4atFoVnAH9jvw?=
 =?us-ascii?Q?+Q=3D=3D?=
X-OriginatorOrg: in-advantage.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e5b40e68-b9fe-4bde-d812-08dad49bd1db
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2351.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Dec 2022 19:31:33.4711
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 48e842ca-fbd8-4633-a79d-0c955a7d3aae
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: no/h5nyDE2pT5c5Xp3ccX1WkGNtTwiRQnEslSDwnAUp68/HKXZ+FbV1kerWDXz7SliX2F9RcOla0892cqVhQB5hzEomheMRxLufw+CD3C28=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ1PR10MB5905
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Rob,

On Thu, Dec 01, 2022 at 04:42:40PM -0600, Rob Herring wrote:
> On Sun, Nov 27, 2022 at 02:47:29PM -0800, Colin Foster wrote:
> > The dsa.yaml binding contains duplicated bindings for address and size
> > cells, as well as the reference to dsa-port.yaml. Instead of duplicating
> > this information, remove the reference to dsa-port.yaml and include the
> > full reference to dsa.yaml.
> > 
> > Signed-off-by: Colin Foster <colin.foster@in-advantage.com>
> > Suggested-by: Vladimir Oltean <olteanv@gmail.com>
> > ---
> > 
> > v2 -> v3
> >   * Remove #address-cells and #size-cells from v2. The examples were
> >     incorrect and fixed elsewhere.
> >   * Remove erroneous unevaluatedProperties: true under Ethernet Port.
> >   * Add back ref: dsa-port.yaml#.
> > 
> > v1 -> v2
> >   * Add #address-cells and #size-cells to the switch layer. They aren't
> >     part of dsa.yaml.
> >   * Add unevaluatedProperties: true to the ethernet-port layer so it can
> >     correctly read properties from dsa.yaml.
> > 
> > ---
> >  Documentation/devicetree/bindings/net/dsa/qca8k.yaml | 11 +++--------
> >  1 file changed, 3 insertions(+), 8 deletions(-)
> > 
> > diff --git a/Documentation/devicetree/bindings/net/dsa/qca8k.yaml b/Documentation/devicetree/bindings/net/dsa/qca8k.yaml
> > index 6fc9bc985726..93a9ddebcac8 100644
> > --- a/Documentation/devicetree/bindings/net/dsa/qca8k.yaml
> > +++ b/Documentation/devicetree/bindings/net/dsa/qca8k.yaml
> > @@ -66,20 +66,15 @@ properties:
> >                   With the legacy mapping the reg corresponding to the internal
> >                   mdio is the switch reg with an offset of -1.
> >  
> > +$ref: "dsa.yaml#"
> > +
> >  patternProperties:
> >    "^(ethernet-)?ports$":
> >      type: object
> > -    properties:
> > -      '#address-cells':
> > -        const: 1
> > -      '#size-cells':
> > -        const: 0
> > -
> >      patternProperties:
> >        "^(ethernet-)?port@[0-6]$":
> >          type: object
> >          description: Ethernet switch ports
> > -
> >          $ref: dsa-port.yaml#
> 
> So here you need 'unevaluatedProperties: false'.
> 
> unevaluatedProperties only applies to the properties defined in a single 
> node level, and child nodes properties from 2 schemas can't 'see' each 
> other. IOW, what dsa.yaml has in child nodes has no effect on this node. 

I'm buttoning up v4 right now and removing this line deletion.
unevaluatedProperties: false exists under the etherent-port node, just
at the end of the properties list.

Since the etherent-ports node in net/dsa/dsa.yaml has
unevaluatedProperties: false, I understand that isn't necessary here.

> 
> >  
> >          properties:
> > @@ -116,7 +111,7 @@ required:
> >    - compatible
> >    - reg
> >  
> > -additionalProperties: true
> > +unevaluatedProperties: false
> 
> So this has no effect on anything within "^(ethernet-)?port@[0-6]$" and 
> below.
> 
> Rob