Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp2599746rwb; Fri, 2 Dec 2022 12:05:49 -0800 (PST) X-Google-Smtp-Source: AA0mqf5ODGVuuCi8+7Fh6mvtd8rcQfTRlqgMNZf1gDlq5FUuuWbtfp7iyC54v6qKJYGvarAZsh3/ X-Received: by 2002:a63:2251:0:b0:476:cb2a:b99b with SMTP id t17-20020a632251000000b00476cb2ab99bmr65112363pgm.436.1670011549124; Fri, 02 Dec 2022 12:05:49 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1670011549; cv=none; d=google.com; s=arc-20160816; b=A7btnNhNFOzk69TxWYIBI9vRMP9ONaWc8qtdEigNsD+AhtZXk5yMVfBowMrh2K2eLR cWN3mLBsIswfEFz/CcNQZb8D+S5jlYG+OblRJOa6t1HGds4avlvj3mOU+5RA9cpxD5Nh OSkMCZZc3Ls5/46wjeAAskKothK6KzkzZ6RYMVZiaYKLL3hJ0hv84z/D0D7PYR+Fthds li3ubUyj7BGTIX1S+FQgt94qJXZuK5VBNwS4i74WR556S11y4jCaZgCDo+Xqx3CG2erx V390h958nizZdpbsiXFRrOeiP9PjYSmJyKVpATF9/dkN/hP890e0ljF2wu7Qu5p7V/3V ZNZw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=iQuycMZtPbvV3NkGCSrY+6L3hWEFkqI8nUbsdweZv5I=; b=qgm7XhzY3AYR86G7f35we5hC7EJmUnXFiyDNN2Amv8NMGNvffVolVnNdoDM5DZp8Gy qRqBwCtHfxb1blU3wk+PXJi6iN9V631/ZS+C9xnDaUPkLUq6/DlxJn2uTaUeEp0FJYW1 qzuDIslsK0gw/nA+QbbRQmaP8CT+gtXfSb/hqNT7n8O7RPa2zJjBYJdaJxb/H3i+LGCu PLGuiSxxTvs4ZYbJ5FZ3lu6PMXX07n4e9HsCgAmQPG5BBeKFFhaD1la8+SIMTsjc63WJ mX/Xescx9ETkeJMO3adAQaRfDNw3167xWvmwcGUITGTz1JDWCQzxSYNF8xk5ykLkuaDd DHmw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@sberdevices.ru header.s=mail header.b=PdwMshCw; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=sberdevices.ru Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id l135-20020a633e8d000000b0046ebb90e5bdsi8027927pga.337.2022.12.02.12.05.37; Fri, 02 Dec 2022 12:05:49 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@sberdevices.ru header.s=mail header.b=PdwMshCw; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=sberdevices.ru Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234771AbiLBSyA (ORCPT + 82 others); Fri, 2 Dec 2022 13:54:00 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40794 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234744AbiLBSxl (ORCPT ); Fri, 2 Dec 2022 13:53:41 -0500 Received: from mx.sberdevices.ru (mx.sberdevices.ru [45.89.227.171]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 28295F1150; Fri, 2 Dec 2022 10:53:11 -0800 (PST) Received: from s-lin-edge02.sberdevices.ru (localhost [127.0.0.1]) by mx.sberdevices.ru (Postfix) with ESMTP id C7ED85FD0D; Fri, 2 Dec 2022 21:53:09 +0300 (MSK) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sberdevices.ru; s=mail; t=1670007189; bh=iQuycMZtPbvV3NkGCSrY+6L3hWEFkqI8nUbsdweZv5I=; h=Date:From:To:Subject:Message-ID:MIME-Version:Content-Type; b=PdwMshCwBMAKVTGNeWOXTPj2ABBu4B+QFW/VUvJDRztT4++AWjxWutSaFASALLwZq bEqT3rHN2CxVJ/8lDehljuoOWlksuKZxT9z0J5iCqVcjteJoW7fuJO761V9kbO4oxK eoftSwrKuQWrXBbx4qZEoj0/rPdL2l3x/ScJdW9I+aLvhWKvUwVsEWJLTj8LJrfE/C Jl1diTs38oUToyIcP70K51f3x8I3ahf7X+mXWL0IU+fpn1VRX/mg9dDP3rOe+N3s1J eYJo1Iy1ZWotOurCndP1VDqbU+rPgqoJRFEODrVMJ9dSuo+hfdEnHVT1dUcqWRQ9la WxQUF/1jlhtlg== Received: from S-MS-EXCH01.sberdevices.ru (S-MS-EXCH01.sberdevices.ru [172.16.1.4]) by mx.sberdevices.ru (Postfix) with ESMTP; Fri, 2 Dec 2022 21:53:08 +0300 (MSK) Date: Fri, 2 Dec 2022 21:53:08 +0300 From: Dmitry Rokosov To: Krzysztof Kozlowski CC: Martin Kurbanov , Pavel Machek , Rob Herring , Krzysztof Kozlowski , Jonathan Corbet , Andy Shevchenko , "linux-leds@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-doc@vger.kernel.org" , kernel Subject: Re: [PATCH v1 1/2] dt-bindings: leds: add binding for aw200xx Message-ID: <20221202185308.zh5kesfxvyrco2cr@CAB-WSD-L081021> References: <20221124204807.1593241-1-mmkurbanov@sberdevices.ru> <20221124204807.1593241-2-mmkurbanov@sberdevices.ru> <0a9e7d65-4ad7-b753-ec9b-8e58a549b5db@sberdevices.ru> <620b19f5-2202-21a5-7e3b-816dcd42d1b4@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <620b19f5-2202-21a5-7e3b-816dcd42d1b4@linaro.org> User-Agent: NeoMutt/20220415 X-Originating-IP: [172.16.1.6] X-ClientProxiedBy: S-MS-EXCH01.sberdevices.ru (172.16.1.4) To S-MS-EXCH01.sberdevices.ru (172.16.1.4) X-KSMG-Rule-ID: 4 X-KSMG-Message-Action: clean X-KSMG-AntiSpam-Status: not scanned, disabled by settings X-KSMG-AntiSpam-Interceptor-Info: not scanned X-KSMG-AntiPhishing: not scanned, disabled by settings X-KSMG-AntiVirus: Kaspersky Secure Mail Gateway, version 1.1.2.30, bases: 2022/12/02 17:01:00 #20638911 X-KSMG-AntiVirus-Status: Clean, skipped X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Krzysztof, On Fri, Dec 02, 2022 at 05:41:37PM +0100, Krzysztof Kozlowski wrote: > On 28/11/2022 18:43, Martin Kurbanov wrote: > > Hi. Thank you for quick reply. > > > > On 25.11.2022 11:29, Krzysztof Kozlowski wrote: > >>> + > >>> + imax: > >>> + maxItems: 1 > >>> + description: > >>> + Maximum supply current, see dt-bindings/leds/leds-aw200xx.h > >> > >> No. Use existing properties from common.yaml. This looks like > >> led-max-microamp and it is per LED, not per entire device. > > > > The AW200XX LED chip does not support imax setup per led. > > Imax is the global parameter over the all leds. I suppose, it's better > > to add vendor prefix or take minimum from all subnodes? > > How do you think? > > Have in mind that led-max-microamp is a required property in some cases, > so skipping it and using per-device properties does not solve the > problem of adjusting proper currents. What if each LED you set for > something which in total gives more than your imax? > You are right. From my point of view too, we must build our solutions from HW capabilities. In the current situation, AW200XX chips support global Imax value, so it's acceptable decision to use vendor prefix for global imax parameter, why not? ... -- Thank you, Dmitry