Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20221202174039.3360904-1-ssreevani@meta.com>
In-Reply-To: <20221202174039.3360904-1-ssreevani@meta.com>
From:   Alexei Starovoitov <alexei.starovoitov@gmail.com>
Date:   Fri, 2 Dec 2022 12:01:09 -0800
Message-ID: <CAADnVQLYpvhbKqv_8EriF29dHFdDYi8dt3Yxh4QUiUfRoFaLJw@mail.gmail.com>
Subject: Re: [PATCH bpf-next] bpf, docs: BPF Iterator Document
To:     Sreevani Sreejith <ssreevani@meta.com>
Cc:     bpf <bpf@vger.kernel.org>, LKML <linux-kernel@vger.kernel.org>,
        Alexei Starovoitov <ast@kernel.org>,
        Andrii Nakryiko <andrii@kernel.org>,
        Daniel Borkmann <daniel@iogearbox.net>, psreep@gmail.com,
        David Vernet <void@manifault.com>,
        Yonghong Song <yhs@meta.com>, mykolal@meta.com
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Fri, Dec 2, 2022 at 9:42 AM Sreevani Sreejith <ssreevani@meta.com> wrote:
>
> From: Sreevani Sreejith <psreep@gmail.com>
>
> Document that describes how BPF iterators work, how to use iterators,
> and how to pass parameters in BPF iterators.
>
> Acked-by: David Vernet <void@manifault.com>
> Signed-off-by: Sreevani Sreejith <psreep@gmail.com>
> ---
>  Documentation/bpf/bpf_iterators.rst           |  487 +
>  .../bpf/images/bpf_iterator_flow.svg          | 9589 +++++++++++++++++

The graph looks nice, but it's huge.
Almost 1Mbyte.
The largest .svg file in the kernel tree is 200k.

Also it doesn't seem to add too much additional info
vs what's described in the text.
I suggest to drop .svg and stick to text only.
Or draw a text only diagram, but it doesn't look necessary in this case.