Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Wang, Weilin" <weilin.wang@intel.com>
To:     Namhyung Kim <namhyung@kernel.org>,
        Arnaldo Carvalho de Melo <acme@kernel.org>,
        Jiri Olsa <jolsa@kernel.org>
CC:     Ingo Molnar <mingo@kernel.org>,
        Peter Zijlstra <peterz@infradead.org>,
        LKML <linux-kernel@vger.kernel.org>,
        Ian Rogers <irogers@google.com>,
        "Hunter, Adrian" <adrian.hunter@intel.com>,
        "linux-perf-users@vger.kernel.org" <linux-perf-users@vger.kernel.org>,
        "Kan Liang" <kan.liang@linux.intel.com>,
        Zhengjun Xing <zhengjun.xing@linux.intel.com>,
        James Clark <james.clark@arm.com>,
        "Athira Jajeev" <atrajeev@linux.vnet.ibm.com>
Subject: RE: [PATCH] perf stat: Fix multi-line metric output in JSON
Thread-Topic: [PATCH] perf stat: Fix multi-line metric output in JSON
Thread-Index: AQHZBoD5lGUsRu3DdE2l74CJjH33Pa5a/C4g
Date:   Fri, 2 Dec 2022 19:31:59 +0000
Message-ID: <CO6PR11MB5635C3BB62A1B9FA532DF57BEE179@CO6PR11MB5635.namprd11.prod.outlook.com>
References: <20221202190447.1588680-1-namhyung@kernel.org>
In-Reply-To: <20221202190447.1588680-1-namhyung@kernel.org>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?WRql0SrHW30swYQZUMtNwuLj2fTj24bsd6xxY/0j+HdntSe6zCoTR+m9nVjk?=
 =?us-ascii?Q?Ry0OcZ+SObi3E7bje2j+x1cO/ZTumCPSfGOVAIdE9PBy7+vhyEaiIZ8abeFi?=
 =?us-ascii?Q?V0aHvBsHkxQoyzYVlOr986//4Frd5w5UOfZr89AXtY5W9swStAdci5XIrNUr?=
 =?us-ascii?Q?naE/f6xb1sAngzRrTAigG2Ow+nwcmbsOEXz/W9cdO42az2LvQhtK6X23mIH5?=
 =?us-ascii?Q?LafHgMrUw+htHM/LSJkPiOTRwiJHIAYzN9+xinMF/Qkl9khbTOaVP5x7sHaC?=
 =?us-ascii?Q?O3XYqRdXxwhyTHbz73Pyt9M+NFQ/cm8VxQkuhycO8VuPxuarHX8AKZpz24bS?=
 =?us-ascii?Q?/zUeVt5KbQ4cla8DRDQjnrNsDYk8QChv2WZMhrSKTddGa4S0Pa8F+yr0q0Z0?=
 =?us-ascii?Q?dHYWsbwKzLhWZZfU2HvAJQdQO4gH7a6Z35tCI6jyGfnnaOm6yLZHlWon1U42?=
 =?us-ascii?Q?R2+oLVILVK6LvAWCCZzVU5Lit95EtuCbuQaA8IOaF6AZ5uVnv1PZ4U2lHlcX?=
 =?us-ascii?Q?eaOJfBUWrhSdR5ROwqNfPM0VC/vm5xwrgR53xop3SQ0VdC7ADi/1Swfms8Gt?=
 =?us-ascii?Q?9VPGdNcSDQOdqKUOoBu1ck8IJnme2I1TExfbudO2lgRSashw4SwSQQ57us9D?=
 =?us-ascii?Q?DIInCDB/cgmSm3RF406GRbqpLBTdRo2Ax1sjbx+vFC3HHmeZHIwpi/5eXTLw?=
 =?us-ascii?Q?xbF7wit9XWa8MXhP7tJnAbHAJlZ9PgLNvfvTVngnHxpAJ9c1kcH5o+chTfLP?=
 =?us-ascii?Q?cIrUKIxzO4Ek1So/joHF5ks9c7EkIsylgvyma50/QsYUuaU6FvqEVrqJzvLZ?=
 =?us-ascii?Q?L7i4BuryCqaR/RW6+TeHPO4B48QHOP9vh5IJgncKXSwhtZGypla/guCOA6s/?=
 =?us-ascii?Q?f3UU7yC9NFAn1m9oPaB4njs++ZsnnXc08Bqw2FDqCcpftSBGNRinlUWNYoXn?=
 =?us-ascii?Q?kqUXSqc7HAQvIhY0V9Qv0axewJq/oJhuyN0bpUbKVmZSZvYuk4cN0VONkbGO?=
 =?us-ascii?Q?FikS40oeTUme0YjD/UL8GdO8tdS6u66YjC19AYC9ex1sOPtPZ0sfLtNo7smU?=
 =?us-ascii?Q?EkVYcWrtRjLqxrgdbLmgueMmW2rDYRObDbTxFAHhWuvB2ag1hPXeD1OOlzg0?=
 =?us-ascii?Q?twwZ8He4egrvvuCLwZ5zp6x+uFlbpTTtDurUgLxM+L8YYnSFOkv+4797OPKM?=
 =?us-ascii?Q?GCMniaAvedxvh/egeZp9wKsRhWUGHW4QZETn4nb9FNz+Z4vieQrChZC5gF4w?=
 =?us-ascii?Q?JS1rBM6Dpo9oVabji51jz+RB8rELuQPaqYFpIaEOLPCK0wKPov0xv7fg8Edt?=
 =?us-ascii?Q?sefpkiDtk7AqxCAEX0OeLHHt8MVQztK4Oia4CaUevzjC8OUDdifUuUEugyO5?=
 =?us-ascii?Q?KZn/bUPjgb1/wrc+jEqsHE1V8uiO66M2VvALUPV2QGK6JYiR+zv0Jv3fjhUJ?=
 =?us-ascii?Q?M3XD5NR6NjfU+w49Nu2Tpzuty0/FsHfLi5BCdqBYK1D7HMHyEn4XgvYPzJkp?=
 =?us-ascii?Q?RsbwXUBlWpQJrA/Q83OXZZITAqUp4wUV7TKP5RoauOuu2XfWTLZY4yH3GCXK?=
 =?us-ascii?Q?JUrHBAuPUxX/B5+mbuJiEtTTJ0eXrAUB8n0yaABV?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: CO6PR11MB5635.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1c7bddb3-56ac-4f84-42dc-08dad49be17d
X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Dec 2022 19:31:59.3823
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 7Ou9h2ce7tSz4X8H7DCddP+aNOIz6PuHvDsxCYrvo2fP72xEvsps0ib+6NGskrJv+8sg2B7HcnxEsD0LgRUC0g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR11MB7265
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Namhyung, it works. Thanks!

-----Original Message-----
From: Namhyung Kim <namhyung@gmail.com> On Behalf Of Namhyung Kim
Sent: Friday, December 2, 2022 11:05 AM
To: Arnaldo Carvalho de Melo <acme@kernel.org>; Jiri Olsa <jolsa@kernel.org=
>
Cc: Ingo Molnar <mingo@kernel.org>; Peter Zijlstra <peterz@infradead.org>; =
LKML <linux-kernel@vger.kernel.org>; Ian Rogers <irogers@google.com>; Hunte=
r, Adrian <adrian.hunter@intel.com>; linux-perf-users@vger.kernel.org; Kan =
Liang <kan.liang@linux.intel.com>; Zhengjun Xing <zhengjun.xing@linux.intel=
.com>; James Clark <james.clark@arm.com>; Athira Jajeev <atrajeev@linux.vne=
t.ibm.com>; Wang, Weilin <weilin.wang@intel.com>
Subject: [PATCH] perf stat: Fix multi-line metric output in JSON

When a metric produces more than one values, it missed to print the opening=
 bracket.

Fixes: ab6baaae2735 ("perf stat: Fix JSON output in metric-only mode")
Reported-by: "Wang, Weilin" <weilin.wang@intel.com>
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
---
Weilin, could you please verify it fixes your problem?

 tools/perf/util/stat-display.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/perf/util/stat-display.c b/tools/perf/util/stat-display.=
c index f1ee4b052198..8d0bdd57163d 100644
--- a/tools/perf/util/stat-display.c
+++ b/tools/perf/util/stat-display.c
@@ -440,7 +440,7 @@ static void new_line_json(struct perf_stat_config *conf=
ig, void *ctx)  {
 	struct outstate *os =3D ctx;
=20
-	fputc('\n', os->fh);
+	fputs("\n{", os->fh);
 	if (os->prefix)
 		fprintf(os->fh, "%s", os->prefix);
 	aggr_printout(config, os->evsel, os->id, os->nr);
--
2.39.0.rc0.267.gcb52ba06e7-goog