Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Bjorn Andersson <andersson@kernel.org>
To:     swboyd@chromium.org, dianders@chromium.org
Cc:     dmitry.baryshkov@linaro.org, konrad.dybcio@somainline.org,
        mka@chromium.org, sboyd@kernel.org, quic_tdas@quicinc.com,
        linux-arm-msm@vger.kernel.org, tdas@codeaurora.org,
        judyhsiao@chromium.org, agross@kernel.org, mturquette@baylibre.com,
        linux-kernel@vger.kernel.org, quic_srivasam@quicinc.com,
        linux-clk@vger.kernel.org
Subject: Re: (subset) [PATCH 1/3] clk: qcom: lpass-sc7280: Fix pm_runtime usage
Date:   Fri,  2 Dec 2022 14:58:44 -0600
Message-Id: <167001472419.2721945.15791825531411350207.b4-ty@kernel.org>
In-Reply-To: <20221104064055.1.I00a0e4564a25489e85328ec41636497775627564@changeid>
References: <20221104064055.1.I00a0e4564a25489e85328ec41636497775627564@changeid>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
Precedence: bulk

On Fri, 4 Nov 2022 06:56:28 -0700, Douglas Anderson wrote:
> The pm_runtime usage in lpass-sc7280 was broken in quite a few
> ways. Specifically:
> 
> 1. At the end of probe it called "put" twice. This is a no-no and will
>    end us up with a negative usage count. Even worse than calling
>    "put" twice, it never called "get" once. Thus after bootup it could
>    be seen that the runtime usage of the devices managed by this
>    driver was -2.
> 2. In some error cases it manually called pm_runtime_disable() even
>    though it had previously used devm_add_action_or_reset() to set
>    this up to be called automatically. This meant that in these error
>    cases we'd double-call pm_runtime_disable().
> 3. It forgot to call undo pm_runtime_use_autosuspend(), which can
>    sometimes have subtle problems (and the docs specifically mention
>    that you need to undo this function).
> 
> [...]

Applied, thanks!

[1/3] clk: qcom: lpass-sc7280: Fix pm_runtime usage
      commit: d470be3c4f30b4666e43eef6bab80f543563cdb0
[2/3] clk: qcom: lpass-sc7180: Fix pm_runtime usage
      commit: ff1ccf59eaffd192efe21f7de9fb0c130faf1b1b
[3/3] clk: qcom: lpass-sc7180: Avoid an extra "struct dev_pm_ops"
      commit: e3ad6c3f21ddb89e4b71361be8318da57dbe3597

Best regards,
-- 
Bjorn Andersson <andersson@kernel.org>