Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <f46f133e-d401-a91b-b67a-cca278f171f2@intel.com>
Date:   Fri, 2 Dec 2022 12:57:23 -0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.5.0
Subject: Re: [Patch V1 3/7] x86/microcode/core: Move microcode_check() to
 cpu/microcode/core.c
To:     Ashok Raj <ashok.raj@intel.com>
CC:     X86-kernel <x86@kernel.org>,
        LKML Mailing List <linux-kernel@vger.kernel.org>,
        Dave Hansen <dave.hansen@intel.com>,
        "Tony Luck" <tony.luck@intel.com>, <alison.schofield@intel.com>,
        <reinette.chatre@intel.com>, Borislav Petkov <bp@alien8.de>
References: <20221129210832.107850-1-ashok.raj@intel.com>
 <20221129210832.107850-4-ashok.raj@intel.com>
Content-Language: en-US
From:   Sohil Mehta <sohil.mehta@intel.com>
In-Reply-To: <20221129210832.107850-4-ashok.raj@intel.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?K2VJaFI4dVltYWQyakppYThFVVhPaElhSlQzL2RhUjdnNzludTZPMHFpNEsr?=
 =?utf-8?B?bVhRcW1ia05OVGNqTUVKcDBrUTFwQk1rTzMzbjJzNUV0MDl3SjJwUmg0eFZ4?=
 =?utf-8?B?bnlrOGpHRDJpV1V4VzZubzVvWTM2bjhaWjdITk83ejRNbElVa1J0aHFUMmZP?=
 =?utf-8?B?aHhRTGs2MWppTFM0c2xDcVkzNmdZZVpZTkhnL1hNdHhSRm0wYzRpMGZRYVow?=
 =?utf-8?B?RlVPZW5jT0dmMEd3VGZvWkFveE9UR1U1Q2JFcjNVRXNZRjlseWNoZXFiZFcr?=
 =?utf-8?B?Q2JCQ1NNbkU2VWF1a2J5L3dqMVhJeFVncmJPY1VIdmZYY0JTV21KemoreW9l?=
 =?utf-8?B?TXFqanJFbC94VFQrb1FYazhUblpzK0FBaXpKRFJaM3ZkSUhZSitTUDJsYmc4?=
 =?utf-8?B?UTRrRTdLc0dRdUNybWdKUkhsMm9KYWZNT2ZYNks4U3hhT1hjd24yQlRSQVpr?=
 =?utf-8?B?bHZQY3ZjNE9Lb0pTQkxzTFBtZUVISjBLeElTNXN6MVkzcTA3akFPOTNwY1Y5?=
 =?utf-8?B?cWJNU0ljOHhYNW9sM1NWT0tNcGFjMU11Y2JrVU8xSHJGMkl1N1Y4a2RWeFJ2?=
 =?utf-8?B?ZEhSQXQ0Qk1zUXVab0hLOTZSVmxyV3pyYmhKU1ZON2NaYjFqY1RZOEUzcnFu?=
 =?utf-8?B?MzhnN1JIZmlkMjl3ZXlkQkxLWmFUMEFGZE1ZTnFndmxlcTZuN3dKc0swMVFw?=
 =?utf-8?B?MjVwT0R2TncvbVJXUXFFZlk4aVpCVk5NYUtYcEwyM2FhanlFR2xwSlZFSkVy?=
 =?utf-8?B?SC8xT2lpZ3c4OHZuRUxvUWl0S1RVRVQxNkh5TW5FS1dIUFlkemxVWEkwTU42?=
 =?utf-8?B?c2s5cFJOQjJkbG9sdDA2STV0WmVKUW1QQ0FuSm04NjdmcXlualF6WjA2VzNv?=
 =?utf-8?B?eFF3NTl4K2NlcGcyLzJCSFJhWUlodk0rUmpkWXA3d0FWOFJkNHYxKzNGenVU?=
 =?utf-8?B?U0RXMkpsM0dvZ3hKMzNuaDBteHNaeWl3R003N1MyV3A4a0M3ekZIWXVXeVIx?=
 =?utf-8?B?WDNPSlhqQjVpdWlLSC9tSGVNN2NVM2JCMEV0OElTaHpQUkhDV2RINHZMTDd2?=
 =?utf-8?B?aXZNMEErbXYzRDBseGw2SnljNG1wSTFHeFl6MG1wU0xNdWw2WW1CVE5XdnlU?=
 =?utf-8?B?b1dva2tvL2dWZmoyV0Q2MmNCN0xmaWVjTzYzMk41SkRCSTZyZU5yL0Jyd0lt?=
 =?utf-8?B?aDVndXJEZ1ExQXU4OEo4bDMyVjdmd0NqZGpRRGlDTGUzNzJrUFFSempvM2p0?=
 =?utf-8?B?bTRWYmpaZStqaVJWWHE3THNKM0hFVUkxWE1sTVdFUVJPZGR4RUF6emRvZy9t?=
 =?utf-8?B?UFFQQURZZjF4cVhEc1l0elh1UFljLzQrcndmaGF1V0dhOGJwRG41SUVPbGFy?=
 =?utf-8?B?NE5FVjFrZDhYWFF1UzIrZ251RG1ZWmxvSytjRS9mcm1lZmFKSERML3VTNXUr?=
 =?utf-8?B?aU1FejRUd1Y4elMrU1NiRDhNU3g4NW5LRkhsenZ3Z3ppR1hISzYyNUZUUFFz?=
 =?utf-8?B?eGl4b2pjNy8vbkxJN3h2SWV3Y09HbG44dUNsczRzUURWTC9BSUREZ3FHOVBy?=
 =?utf-8?B?TUlPV0FtcFBLR0hidVBmekFZcmxjdXhUOVJWZXVOd1NUaTRVV0tpQzhwZVJY?=
 =?utf-8?B?MlUrT1NqWWVEQW9OKzlXRW5iNHdpUWRnT3Z2UlgxNjAzN2NWbi9aaXZxNWNr?=
 =?utf-8?B?bldrYSt2cXJHU2pMcE9qTUh4aHl6UzlxUVIyZHlCYS9iY2ErZ0JMcDdoVjFW?=
 =?utf-8?B?MnQyNGJuK25uL0habjg0Rm1MQTRrVDhuTlZNajV6YUJOOEFhdVI5eTg5QlNB?=
 =?utf-8?B?czZ3NW5KTjVQeUZzeFBJNG8xZGgxNnlFZWVCZDAyTW1DQ0p6SVRZcDNDbDFx?=
 =?utf-8?B?YmNPQmRJejQ3RldLNklZUGZPZjN3cU5VY2lTRXFXSFJFakEzTEU5Sm1uU25K?=
 =?utf-8?B?R0xaSEd6Kyt6M3pWUzZPVE0zbktSd0tXVjFiL2w5b3hVc0FaMVdDZVBUaXJl?=
 =?utf-8?B?UHFLWlBoZ241NUVWaWJ0dnJxUVJwcFlwRk5NQzMyRXVKcjVWWmpHL0wzbXpH?=
 =?utf-8?B?N2pFdy9ldkJhNm4wZVY2YlBHSFhRNVQ0VVJkZmxkZmtCcS9ZZTd4WUV0aWhL?=
 =?utf-8?B?ZlJzY0J2LzhTZ25sdGNGN1hSSmx3Q1J4Z0RUTUdYSnhOQTllbDlHL2kvZytu?=
 =?utf-8?B?UlE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 5394f3a6-ba69-4131-a591-08dad4a7d055
X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3320.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Dec 2022 20:57:24.7809
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: V6bgJgVvw6xZSeWBwXQSX7GGJMJc0Ux72lQQ+pEkWAm1/EcUllimgdj5Cl3ropCecQed4reg/M/slMaVU/Hj7A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB4829
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 11/29/2022 1:08 PM, Ashok Raj wrote:
> microcode_check() is only called from microcode/core.c. Move it and make
> it static to prepare for upcoming fix of false negative when checking CPU
> features after a microcode update.

Should we use this opportunity to also make the function name a bit more 
descriptive? microcode_check() seems very ambiguous to a first time reader.

> +/*
> + * The microcode loader calls this upon late microcode load to recheck features,
> + * only when microcode has been updated. Caller holds microcode_mutex and CPU
> + * hotplug lock.
> + */
> +static void microcode_check(void)

How about, microcode_recheck_features() or simply recheck_features() 
since it is static now?

Sohil