Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 2 Dec 2022 21:01:44 +0000
From:   Matthew Wilcox <willy@infradead.org>
To:     Andrew Morton <akpm@linux-foundation.org>
Cc:     Aditya Garg <gargaditya08@live.com>,
        "ira.weiny@intel.com" <ira.weiny@intel.com>,
        "axboe@kernel.dk" <axboe@kernel.dk>,
        "bvanassche@acm.org" <bvanassche@acm.org>,
        "keescook@chromium.org" <keescook@chromium.org>,
        "songmuchun@bytedance.com" <songmuchun@bytedance.com>,
        "slava@dubeyko.com" <slava@dubeyko.com>,
        "linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH] hfsplus: Add module parameter to enable force writes
Message-ID: <Y4pnuBnoHvIS8UB6@casper.infradead.org>
References: <53821C76-DAFE-4505-9EC8-BE4ACBEA9DD9@live.com>
 <20221202125344.4254ab20d2fe0a8e784b33e8@linux-foundation.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20221202125344.4254ab20d2fe0a8e784b33e8@linux-foundation.org>
Precedence: bulk

On Fri, Dec 02, 2022 at 12:53:44PM -0800, Andrew Morton wrote:
> > +		if (force_journaled_rw) {
> > +			pr_warn("write access to a journaled filesystem is not supported, but has been force enabled.\n");
> > +		} else {
> > +			pr_warn("write access to a journaled filesystem is not supported, use the force option at your own risk, mounting read-only.\n");
> > +			sb->s_flags |= SB_RDONLY;
> > +		}
> 
> All these super long lines are an eyesore.  How about
> 
> 			pr_warn("write access to a journaled filesystem is "
> 				"not supported, but has been force enabled.\n");

Linus has asked us to not do that because it makes it hard to grep.