Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp2703174rwb; Fri, 2 Dec 2022 13:48:59 -0800 (PST) X-Google-Smtp-Source: AA0mqf5rdQS3RR2BKYxC9R0Ssr9694FMnIevwVYN2ymLbbcdKn2oEH82P0g9LfWtsiVL/Xc1wmMr X-Received: by 2002:a17:906:6847:b0:7bf:a827:35c with SMTP id a7-20020a170906684700b007bfa827035cmr22594401ejs.711.1670017738852; Fri, 02 Dec 2022 13:48:58 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1670017738; cv=none; d=google.com; s=arc-20160816; b=lNuy3Tcqb2nZACaqPVN+Yzkb4W3eswygvznrI5Q/lwf+ZVJmVlXQjOakRkSWVdMlgb 1uqJ5KJnfvY6zf2NVX2GM0qouDyR8PnY/wMzp5K42U9PJyEuGqaCNxozVhnrUKDHPII/ 9AA6nkG1oTz5Tz2RoGP46aaEw7fYMYMeOp8S0HPTZQIhh9MKrvont47o7OSZGwn6oPbt 5L6LqRXdTxLgXrvxgfmrKsdY4UOYQGOmDXJbq4Pkymnlu5HfDEooYUQ17TDdQtHNEyjn rtK6E2geJ1RYUsOHmRuw3vcCTGfDAyNreT/b++3IixUi6mYqTwKt1AdcWQmtQzCjKOCX xsWA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=jbDqvFAgp4MnB8B6YQ5sRiaoj/wEsc4ByhyQ4FcZagQ=; b=K4kvjDiB27ShiwZ9H5ZUtJtv60AZtbPn7K4QmeV8XHY6B5p8IdZbBp5rDA4gzXWN8j yVbSDxccNj63g9wdVoGwzan/ajcBtq08wkgYNwpNISz8SHWRULdnIGNq2OIQ6My5fN3M JVZHf09H4lY1qEOWuTXeeSWtjeQhQRA8u1a35GNZ4kXxZ/PkH+tBcpVBFfJgO3TIQJuE K6ih6gPB38i37rPQTXIaezO+lqBgirc+ByUspd8J1yzgQVdZtiILORwxoIWlnayezoSW Cejec3MbEMBT8jIS44VR9KfsjcKyPRNV4wzzxY7V/CtCWeFhrsqA4dTPTuw8zoyBsrKO c5RA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=V57rmamK; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id bg11-20020a170906a04b00b0078200e81b92si5551978ejb.758.2022.12.02.13.48.35; Fri, 02 Dec 2022 13:48:58 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=V57rmamK; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234579AbiLBVgD (ORCPT + 82 others); Fri, 2 Dec 2022 16:36:03 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48900 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233821AbiLBVgB (ORCPT ); Fri, 2 Dec 2022 16:36:01 -0500 Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 48AC0EF8B0; Fri, 2 Dec 2022 13:36:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1670016960; x=1701552960; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=jbDqvFAgp4MnB8B6YQ5sRiaoj/wEsc4ByhyQ4FcZagQ=; b=V57rmamKXdp95ydSpJ/UyI6ToOS3DFrg1O4Vwta/3Ev19FACW6+tdp4y bEbEq3wgrfzAzaeT3UgbbzNfDAdMhYGWy/BLNzOdn6dkIWiXF5Ob+fpFI 99sJK7/QqgqaTp2CkXxoR33wbFeb1hsCMCfmW/XIX7KSWsaC8DKEPqU7k +ag0BpP9V52jpD3UvQbCqUvV046TWptD6PhpmkM3S3Pw7FZWVMFaQ2bqr L1LuVfNa9T+mnfO5QfIUQ5ZNMCiQHNv/Tn4SK6607lWtpOnQMaMkKIWlU LEkbadXKjA4z8/P3TO6Ydfz8ee3uv7Gri46cYOMh1RAn3bY3KWhACJ3zk A==; X-IronPort-AV: E=McAfee;i="6500,9779,10549"; a="295744092" X-IronPort-AV: E=Sophos;i="5.96,213,1665471600"; d="scan'208";a="295744092" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Dec 2022 13:36:00 -0800 X-IronPort-AV: E=McAfee;i="6500,9779,10549"; a="713767380" X-IronPort-AV: E=Sophos;i="5.96,213,1665471600"; d="scan'208";a="713767380" Received: from rsnyder-mobl.amr.corp.intel.com (HELO [10.209.68.71]) ([10.209.68.71]) by fmsmga004-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Dec 2022 13:35:58 -0800 Message-ID: <3a789b1c-4c70-158b-d764-daec141a5816@intel.com> Date: Fri, 2 Dec 2022 13:35:58 -0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [PATCH v2 02/18] x86/sgx: Store struct sgx_encl when allocating new VA pages Content-Language: en-US To: Kristen Carlson Accardi , jarkko@kernel.org, dave.hansen@linux.intel.com, tj@kernel.org, linux-kernel@vger.kernel.org, linux-sgx@vger.kernel.org, cgroups@vger.kernel.org, Thomas Gleixner , Ingo Molnar , Borislav Petkov , x86@kernel.org, "H. Peter Anvin" Cc: zhiquan1.li@intel.com, Sean Christopherson References: <20221202183655.3767674-1-kristen@linux.intel.com> <20221202183655.3767674-3-kristen@linux.intel.com> From: Dave Hansen In-Reply-To: <20221202183655.3767674-3-kristen@linux.intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A, RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/2/22 10:36, Kristen Carlson Accardi wrote: > When allocating new Version Array (VA) pages, pass the struct sgx_encl > of the enclave that is allocating the page. sgx_alloc_epc_page() will > store this value in the encl_owner field of the struct sgx_epc_page. In > a later patch, VA pages will be placed in an unreclaimable queue, > and then when the cgroup max limit is reached and there are no more > reclaimable pages and the enclave must be oom killed, all the > VA pages associated with that enclave can be uncharged and freed. What does this have to do with the 'encl' that is being passed, though? In other words, why is this new sgx_epc_page-to-encl mapping needed for VA pages now, but it wasn't before?