Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <33c88623-b08c-c8b9-e0b6-be8ce5694af0@kernel.org>
Date:   Fri, 2 Dec 2022 13:40:35 -0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.1
Subject: Re: [PATCH] ktest.pl minconfig: Unset configs instead of just
 removing them
Content-Language: en-MW
To:     Steven Rostedt <rostedt@goodmis.org>,
        LKML <linux-kernel@vger.kernel.org>
References: <20221202115936.016fce23@gandalf.local.home>
From:   John 'Warthog9' Hawley <warthog9@kernel.org>
In-Reply-To: <20221202115936.016fce23@gandalf.local.home>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 12/2/22 08:59, Steven Rostedt wrote:
> From: Steven Rostedt <rostedt@goodmis.org>
> 
> After a full run of a make_min_config test, I noticed there were a lot of
> CONFIGs still enabled that really should not be. Looking at them, I
> noticed they were all defined as "default y". The issue is that the test
> simple removes the config and re-runs make oldconfig, which enables it
> again because it is set to default 'y'. Instead, explicitly disable the
> config with writing "# CONFIG_FOO is not set" to the file to keep it from
> being set again.
> 
> With this change, one of my box's minconfigs went from 768 configs set,
> down to 521 configs set.
> 
> Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
> ---
>   tools/testing/ktest/ktest.pl | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/tools/testing/ktest/ktest.pl b/tools/testing/ktest/ktest.pl
> index 590518144167..56135e7d2295 100755
> --- a/tools/testing/ktest/ktest.pl
> +++ b/tools/testing/ktest/ktest.pl
> @@ -3775,9 +3775,10 @@ sub test_this_config {
>       # .config to make sure it is missing the config that
>       # we had before
>       my %configs = %min_configs;
> -    delete $configs{$config};
> +    $configs{$config} = "# $config is not set";
>       make_new_config ((values %configs), (values %keep_configs));
>       make_oldconfig;
> +    delete $configs{$config};
>       undef %configs;
>       assign_configs \%configs, $output_config;
>   

Reviewed-by: John 'Warthog9' Hawley (VMware) <warthog9@eaglescrag.net>