Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 2 Dec 2022 13:31:14 -0800
From:   Ira Weiny <ira.weiny@intel.com>
To:     Steven Rostedt <rostedt@goodmis.org>
CC:     Dan Williams <dan.j.williams@intel.com>,
        Alison Schofield <alison.schofield@intel.com>,
        Vishal Verma <vishal.l.verma@intel.com>,
        "Ben Widawsky" <bwidawsk@kernel.org>,
        Jonathan Cameron <Jonathan.Cameron@huawei.com>,
        Davidlohr Bueso <dave@stgolabs.net>,
        "Dave Jiang" <dave.jiang@intel.com>,
        <linux-kernel@vger.kernel.org>, <linux-cxl@vger.kernel.org>
Subject: Re: [PATCH V2 02/11] cxl/mem: Implement Get Event Records command
Message-ID: <Y4puolf7AF9NkNJ5@iweiny-desk3>
References: <20221201002719.2596558-1-ira.weiny@intel.com>
 <20221201002719.2596558-3-ira.weiny@intel.com>
 <20221201123849.0f7802ce@gandalf.local.home>
 <Y4lCLfQrjyRtLmDM@iweiny-desk3>
 <20221201234052.35e5a001@gandalf.local.home>
 <20221202000059.50d4961e@gandalf.local.home>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20221202000059.50d4961e@gandalf.local.home>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?qNldnslcMPf4vPln8S8gjxLoRbx1AzMOrgT7pu97DyCCRHRHqK4rLaEvQ6dt?=
 =?us-ascii?Q?4YMMg9CRSuIHT+kAnf05A8Lk2FysyR+E1Cz0d6TuIm9dYKGQIqWibzrzJWbd?=
 =?us-ascii?Q?++DF6mxbMYfI4P7Pn3FEjVmqEHJmYqOOGX3wvZXEoouIIDaHKJdC0tJQCQOo?=
 =?us-ascii?Q?X1GLXxAHNLFkwrK5yvmPdLBpjdsG/oOS4CRLzfstEiDkcrSzqYoBY1pm3pwN?=
 =?us-ascii?Q?SOB0qDRLvRMd05eCeteoqLC9oTNcRfzh0fkxcbgtfiRGuvVyZs9NpgiM/1QX?=
 =?us-ascii?Q?X0tpm6L58kMfBE4FHx+/ZSLxHf8SNmB10yBMh6PKenv2uZdSGPJPouZDtZov?=
 =?us-ascii?Q?Vs4dfefZ1Tfpju/8UIuuw9K5w5Lvuboxreb5xOKl+ZNodT2AG+sG42u9xbX3?=
 =?us-ascii?Q?J7FWe2mCQ/2A+FJbtAvDG8i89X9SfYJuCdvXGOBzYjAKVL4wlFOcldqEs5Ox?=
 =?us-ascii?Q?8GgibZ5oLdR8f854lVN4nmtC9qx9HFwxy8vHxJYzyauayACSBV8Z1fS548cb?=
 =?us-ascii?Q?NPpHSciyAESWTf8FNjUV/q/fUk1elDAYWNvzGoWEum08yks0dCDLHSfMuuRi?=
 =?us-ascii?Q?bRoY7hlvsf8mEX/1wBDi7Yp4XWKzScQdGn3TxUgKT4iE38msiV7Keo6p//a/?=
 =?us-ascii?Q?GvREGM5iJOFypkg3ocqdEfmZcxOrn1K6EyuO0IssLXIyDFQT1RvtPANWd+uD?=
 =?us-ascii?Q?H8EiJK9ywn/+U5GIk5Ma8+/b7CEi/Lv9Ir/48IpegXsLQI9pgJQolMI5tKnN?=
 =?us-ascii?Q?ze713Oi0awIXKi3opcUG1bUS1P2L+9sMmsOYtITdoIRSs/qS+i9whfxyHZcN?=
 =?us-ascii?Q?OpIppITaS9Iu9ppei37KPuO6xVv1HIsHzVBC5gvzGiMyWRXHQX0SgzPizksg?=
 =?us-ascii?Q?Synou5FbzPRlQZhb2cMSCcVZ0kMomxOhaO4UblVuQyxgjfTDRDvYh5ls65jg?=
 =?us-ascii?Q?Tfec08k4kYuSCbDZ0QFzJjnRaDNnmEXGsPlo8fVDqVo12lE8tr8oZurSYvK4?=
 =?us-ascii?Q?2IKCwNyD/oI1jQYZDFg7Su31zMfHM1et2o8l/8Fdn8oTW2o0jxJDwWOAgiqf?=
 =?us-ascii?Q?Q3o5FeVmF8AdZscid3JphtGIElrtfWd2qXPMoUyq0bYOw9RSqf9Nj1Qq8Zxl?=
 =?us-ascii?Q?3/G4LrmXL3YPZqZH1JMgD1OB3lq8C8KdKiAswLZvwZktmU6/LWt0KnXHYuYL?=
 =?us-ascii?Q?/KhjvnnyIYhi3xtMoeFz87swjD2ktvdEdan4TABC9DwfOLbrNBQ2MY/lDSwM?=
 =?us-ascii?Q?Q2jTbmZliLgGl9ehn44ksPiTgtN0NM1yzpibB84XCF7sGnJ0D8xH1Mq8KWyi?=
 =?us-ascii?Q?ThAGLILTTVdxD2UruyXLw8EhwdEUmabfsZFZdT8lt8d9+a/kXM+fj8qEK+2R?=
 =?us-ascii?Q?rKj6BXZN3PM9WDe9SQ4D5xxlBibRHkgAP8e20EjWg7dP8xEB1p73mHi/npgj?=
 =?us-ascii?Q?15VBTReANOIiDCBxEmyBzH3pCEFJLwyJ/Oq4wB0n0kdsSbbCx0mWiJ07WLgw?=
 =?us-ascii?Q?D9RsxpXHqeGg45hAqOd17XoFYAOFbXjG5JmwxY66FhPCQ7xP/WCVhkiEmedg?=
 =?us-ascii?Q?Cr1bdbk1wg71or8ZBGjBnbhzjzA/HBlbv5lkib7K?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 4ca72d23-463c-4977-97e1-08dad4ac8c3c
X-MS-Exchange-CrossTenant-AuthSource: SA1PR11MB6733.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Dec 2022 21:31:17.9841
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: VwU4RyAvFu9fFNYDwZGocl6ZuYvHAFbWx98xtZCyobI8KpGo8XM1x7aZeZqqhC3JOH8XY7MAF1QFpEUqqkjjKg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR11MB7506
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI,
        SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Dec 02, 2022 at 12:00:59AM -0500, Steven Rostedt wrote:
> On Thu, 1 Dec 2022 23:40:52 -0500
> Steven Rostedt <rostedt@goodmis.org> wrote:
> 
> > +#undef __print_symbolic
> > +#define __print_symbolic(value, symbol_array...)			\
> > +	({								\
> > +		static const struct trace_print_flags symbols[] =	\
> > +			{ symbol_array, { -1, NULL }};			\
> > +		__print_symbolic_str(value, symbols);			\
> > +	})
> > +
> >  #endif /* CREATE_TRACE_POINTS */
> 
> Bah, I want this outside that #ifdef
> 
> > diff --git a/include/trace/stages/stage7_class_define.h b/include/trace/stages/stage7_class_define.h
> > index 8a7ec24c246d..6fe83397f65d 100644
> > --- a/include/trace/stages/stage7_class_define.h
> > +++ b/include/trace/stages/stage7_class_define.h
> > @@ -6,7 +6,6 @@
> 
> I also don't think I need to touch stage7.
> 
> New patch:

I'm still going to defer this but will include a follow up patch to add this
back in after the bulk of the series gets in.

Thanks for helping here.  I still want to understand this all better but I have
to focus on the main features ATM.

Thanks again!
Ira

> 
> diff --git a/include/trace/define_trace.h b/include/trace/define_trace.h
> index 00723935dcc7..9d665f634614 100644
> --- a/include/trace/define_trace.h
> +++ b/include/trace/define_trace.h
> @@ -133,3 +133,24 @@
>  #define CREATE_TRACE_POINTS
>  
>  #endif /* CREATE_TRACE_POINTS */
> +
> +#ifndef __DEFINE_PRINT_SYMBOLIC_STR
> +#define __DEFINE_PRINT_SYMBOLIC_STR
> +static inline const char *
> +__print_symbolic_str(int type, struct trace_print_flags *symbols)
> +{
> +	for (; symbols->name != NULL; symbols++) {
> +		if (type == symbols->mask)
> +			return symbols->name;
> +	}
> +	return "<invalid>";
> +}
> +#endif
> +
> +#undef __print_symbolic
> +#define __print_symbolic(value, symbol_array...)			\
> +	({								\
> +		static const struct trace_print_flags symbols[] =	\
> +			{ symbol_array, { -1, NULL }};			\
> +		__print_symbolic_str(value, symbols);			\
> +	})