Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <d9a6e626-96fb-0593-3410-3bed6c3fb3d0@intel.com>
Date:   Fri, 2 Dec 2022 13:51:11 -0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.5.0
Subject: Re: [PATCH 3/3] dmaengine: idxd: Do not call DMX TX callbacks during
 workqueue disable
Content-Language: en-US
To:     "Yu, Fenghua" <fenghua.yu@intel.com>,
        "Jiang, Dave" <dave.jiang@intel.com>,
        "vkoul@kernel.org" <vkoul@kernel.org>,
        "dmaengine@vger.kernel.org" <dmaengine@vger.kernel.org>
CC:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
References: <cover.1670005163.git.reinette.chatre@intel.com>
 <93b5d144bfc16e0c0f640d5f7cfaeda6bf08753f.1670005163.git.reinette.chatre@intel.com>
 <IA1PR11MB6097E887BBCE14CE2D47CDDB9B179@IA1PR11MB6097.namprd11.prod.outlook.com>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <IA1PR11MB6097E887BBCE14CE2D47CDDB9B179@IA1PR11MB6097.namprd11.prod.outlook.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Nkg3ZFpCMG5HcUd4QXdiUk83OEsrU2ZaYU9FOVNKRUpid2JETGhwVFpuQTU2?=
 =?utf-8?B?dmdFLzk5a29URVJNV1VrRlRETWNjaG1WeGllK1hZVzNpeUJZV3FndkN2VVRF?=
 =?utf-8?B?MzlJa05ZKzFINERXK2dhVWtOc1lhQXp5UlRVNFl2U1EwN3FaZk9rdTdIKzVy?=
 =?utf-8?B?VGxZS25LUkdkTEhvWkJNQmNzOFQ0OFByMWRWcjJlN3d2UllyemdHcXlrWUdp?=
 =?utf-8?B?VU8wV1J5aDhHenEyMlJEZUFERStXeXZ3UUVXcDM0L1plK3BLVTFINWdPYVpD?=
 =?utf-8?B?WXh6WGM3czBHUzU0Y1VKNkZYSElwa0Izazd6K2YyZFBMUEtxMTdvT0JaZzhZ?=
 =?utf-8?B?dk9BVjgvM1YyMzZEeis5M1hLZ2RsRUIwNFo1RytsZlBTSlBVbFd4eXBnT0o5?=
 =?utf-8?B?R2xWd3RSV3V5QXpOeTRHcDdxZUR6Mk9UM3NTTnBqbW1YN1kvYmY2UEFhd3Zj?=
 =?utf-8?B?WkR2QVB0VERSU2JHZ2ZqMzlRR0lOeUdwdmd0VmJYa3lGZFJqRkpXVGw1WFpW?=
 =?utf-8?B?NWF4UWg4a2M5bjBqd0JzbDJSVXpQcHBjZEJZbWNCR2g4VlFKc3pKak9xOThT?=
 =?utf-8?B?S2lHdURvSEt5UXNQZjNQVVZFVUVVTHRyRHp2VklvL0ptdlQ3SmhvWHp6dzdG?=
 =?utf-8?B?WVltbDA0NElzdnh1VU16RmEzYk1MZ0tmTWNCNXNNazQ0OEhjbVBJTE52R2ZL?=
 =?utf-8?B?VUdGQnNvQjBzWnJxTy84WFA0QmEzQTZOMzdkd1o3SW1GTEs2WXFyMWJmUzFo?=
 =?utf-8?B?dmhUOGNybmhmL1RVeGc2dHl5OEVjT0ZNOXhrbGZCclFURHlyOVJvRTBhN3pE?=
 =?utf-8?B?eU5Ib2RHM0t5Q1ZoWEFqdUc4RWt2Q0tiaW1jb2FuNVdJS3NtdUxCUlNFVUFQ?=
 =?utf-8?B?K0h4QU1VNlJWdXArWnFqejQ3aldiSDQxUGlnbjNJTkpJWElaMEF2NFlVUUxP?=
 =?utf-8?B?Z1QxL0RhSmN3bis3SzBjNW1wQzRHSGNoUmgxZlZiLzNpbXpUZk9saXRnR2JG?=
 =?utf-8?B?SURYTDRDL2hvRlg1RytrODlHcnRWWUptOE01amZlZUZCb1FtTzNWWk9STEQ4?=
 =?utf-8?B?cTY1RytzbmpnY1FLYUFGdU9FdlNxZnVzVDhSMkZFeXQ4SHdCckk1UE9GNm1i?=
 =?utf-8?B?cGgxMXdZODdiVDg4NVRrMWZydTZ2L0hBM1hneUFCTDJVZFdBemxNSlF1dnk1?=
 =?utf-8?B?cGMzYjhnUTM5U2U4cDBlREJCNml3YzJGaEwzUUU2c1BTamNRVkhqdmV4alZZ?=
 =?utf-8?B?cS9DK2RpeUpUdXBBeEM5MlIwK3I2T3ZENHhTeUt0R1dWZUlmSG5Bb0g5RUtR?=
 =?utf-8?B?UkdrU0xNNEEwY1dHdjlDU1F1Tjg3N3RGTkhnaGpPSHR2MEhLN0xYcUk3NGMw?=
 =?utf-8?B?Y3BMWmRuZjZoeUVxRVJvZzFpVnpjVXAxZlQybXJFdlpFZC9weU8yK0ZzWWsx?=
 =?utf-8?B?WUhRLzFsK0ZZS1ZUNmZ0R1dRK1NlWVNTSk4xMHpXNnBuZTNTQ3NRV09GMUdQ?=
 =?utf-8?B?dit5NDlWQmtoSVhGeGRBcm5hd1RmU0xjR0lQd1VCbE5zUlMwYU40ZDdZTTQ4?=
 =?utf-8?B?UWJHZ3FVWUdZbE1HalVnNi9UZTczblo5MW9za1RPV21sT0w2dUxtZWJCS01m?=
 =?utf-8?B?RnFid1k4LytBZzRaMGpVN2hxekFJbEJIT2JCRmEyV3pKbk0rOWtRTmdxcmMz?=
 =?utf-8?B?U0NNQ1RiVEt0WUNlU0ZTY3Y3RjZtSTRFM2F1dE5iNHp6bUN0ZkNKWnNNK3Nj?=
 =?utf-8?B?N0JORGlYSWJ2WGxhRGFXSExFMlJmY3lIdVZFOHZEM3FpY3ZQVWNHN0cvT0t0?=
 =?utf-8?B?YVhDajNJTXRuY0kxMXFkWWVKVEdqazl2NVREcTBSaGFUUzVLTStVYStTeFJB?=
 =?utf-8?B?QS9kNUxZSjZFOXhoVnVjbU01OWtPUUd5emVvUEs5cVBYTWFiTjQ0Wmw3L25t?=
 =?utf-8?B?L3JXeURVR1RHc0h0VVF3TWlPYk1MYUg3VGdid0c0bjRMZkVvY3cyQ2NmamEz?=
 =?utf-8?B?bXJMcklBRDAyMzhUb2c4T1NDcURLMUZZdStBTTc1VTROSUJVNzlNN1Z5bm80?=
 =?utf-8?B?MDFhWHhGb2RXWjVTREZKdmtWOWcrZzJPUU85Q0cxaTZ2bzJGZ25ZK3dobHFs?=
 =?utf-8?B?Yk9CWlJxTUJoTTR5ZnpXS1llOXNvZWpYSS9HRzFnS1pDY0d5cGJwdHoxTGxx?=
 =?utf-8?B?MkE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: a63d358e-3436-42cc-cac6-08dad4af553b
X-MS-Exchange-CrossTenant-AuthSource: CY4PR11MB1862.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Dec 2022 21:51:15.4131
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: XaeGo6n7qlHyLJBO/j0WTDcMTpavN+59U91anxb3X06j69qPB9gfmL4omvm3Sf1UUyst30XrSjb0zodiH9Km7oW6IQYbdbtu2g8eVMYL//s=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN0PR11MB6230
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-7.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_HI,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Fenghua,

On 12/2/2022 1:12 PM, Yu, Fenghua wrote:

...

>> diff --git a/drivers/dma/idxd/device.c b/drivers/dma/idxd/device.c index
>> b4d7bb923a40..2ac71a34fa34 100644
>> --- a/drivers/dma/idxd/device.c
>> +++ b/drivers/dma/idxd/device.c
>> @@ -1156,6 +1156,7 @@ int idxd_device_load_config(struct idxd_device *idxd)
>>
>>  static void idxd_flush_pending_descs(struct idxd_irq_entry *ie)  {
>> +	struct dma_async_tx_descriptor *tx;
> 
> Nitpicking. It's better to move this line to below:
> 
>>  	struct idxd_desc *desc, *itr;
>>  	struct llist_node *head;
>>  	LIST_HEAD(flist);
>> @@ -1175,6 +1176,15 @@ static void idxd_flush_pending_descs(struct
>> idxd_irq_entry *ie)
>>  	list_for_each_entry_safe(desc, itr, &flist, list) {
> 
> here?
> +	struct dma_async_tx_descriptor *tx;
> 

Will do.

>>  		list_del(&desc->list);
>>  		ctype = desc->completion->status ?
>> IDXD_COMPLETE_NORMAL : IDXD_COMPLETE_ABORT;
>> +		/*
>> +		 * wq is being disabled. Any remaining descriptors are
>> +		 * likely to be stuck and can be dropped. callback could
>> +		 * point to code that is no longer accessible, for example
>> +		 * if dmatest module has been unloaded.
>> +		 */
>> +		tx = &desc->txd;
>> +		tx->callback = NULL;
>> +		tx->callback_result = NULL;
>>  		idxd_dma_complete_txd(desc, ctype, true);
>>  	}
>>  }
>> --
>> 2.34.1
> 
> Reviewed-by: Fenghua Yu <fenghua.yu@intel.com>

Thank you very much.

Reinette