Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <ff01f296-f3bb-4fdf-d57f-8dd14f1b61d2@ieee.org>
Date:   Fri, 2 Dec 2022 16:20:16 -0600
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.2
Subject: Re: [PATCH] net: ipa: use sysfs_emit() to instead of scnprintf()
Content-Language: en-US
To:     ye.xingchen@zte.com.cn, davem@davemloft.net
Cc:     elder@kernel.org, edumazet@google.com, kuba@kernel.org,
        pabeni@redhat.com, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <202212021642142044742@zte.com.cn>
From:   Alex Elder <elder@ieee.org>
In-Reply-To: <202212021642142044742@zte.com.cn>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 12/2/22 2:42 AM, ye.xingchen@zte.com.cn wrote:
> From: ye xingchen <ye.xingchen@zte.com.cn>
> 
> Follow the advice of the Documentation/filesystems/sysfs.rst and show()
> should only use sysfs_emit() or sysfs_emit_at() when formatting the
> value to be returned to user space.

The buffer passed is non-null and the existing code properly
limits the buffer to PAGE_SIZE.

But... OK.

Reviewed-by: Alex Elder <elder@linaro.org>

> 
> Signed-off-by: ye xingchen <ye.xingchen@zte.com.cn>
> ---
>   drivers/net/ipa/ipa_sysfs.c | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/net/ipa/ipa_sysfs.c b/drivers/net/ipa/ipa_sysfs.c
> index 5cbc15a971f9..14bd2f903045 100644
> --- a/drivers/net/ipa/ipa_sysfs.c
> +++ b/drivers/net/ipa/ipa_sysfs.c
> @@ -46,7 +46,7 @@ version_show(struct device *dev, struct device_attribute *attr, char *buf)
>   {
>   	struct ipa *ipa = dev_get_drvdata(dev);
> 
> -	return scnprintf(buf, PAGE_SIZE, "%s\n", ipa_version_string(ipa));
> +	return sysfs_emit(buf, "%s\n", ipa_version_string(ipa));
>   }
> 
>   static DEVICE_ATTR_RO(version);
> @@ -70,7 +70,7 @@ static ssize_t rx_offload_show(struct device *dev,
>   {
>   	struct ipa *ipa = dev_get_drvdata(dev);
> 
> -	return scnprintf(buf, PAGE_SIZE, "%s\n", ipa_offload_string(ipa));
> +	return sysfs_emit(buf, "%s\n", ipa_offload_string(ipa));
>   }
> 
>   static DEVICE_ATTR_RO(rx_offload);
> @@ -80,7 +80,7 @@ static ssize_t tx_offload_show(struct device *dev,
>   {
>   	struct ipa *ipa = dev_get_drvdata(dev);
> 
> -	return scnprintf(buf, PAGE_SIZE, "%s\n", ipa_offload_string(ipa));
> +	return sysfs_emit(buf, "%s\n", ipa_offload_string(ipa));
>   }
> 
>   static DEVICE_ATTR_RO(tx_offload);