Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <d8944efc-57df-98ec-a6ec-678db9c6ffa8@gmail.com>
Date:   Sat, 3 Dec 2022 07:52:38 +0900
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.2
Subject: Re: [PATCH 3/3] extcon: intel-cht-wc: Add support for Lenovo Yoga Tab
 3 Pro YT3-X90F
To:     Hans de Goede <hdegoede@redhat.com>, Wolfram Sang <wsa@kernel.org>,
        Lee Jones <lee.jones@linaro.org>,
        MyungJoo Ham <myungjoo.ham@samsung.com>,
        Chanwoo Choi <cw00.choi@samsung.com>
Cc:     linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20221127182257.104410-1-hdegoede@redhat.com>
 <20221127182257.104410-4-hdegoede@redhat.com>
From:   Chanwoo Choi <cwchoi00@gmail.com>
Content-Language: en-US
In-Reply-To: <20221127182257.104410-4-hdegoede@redhat.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 22. 11. 28. 03:22, Hans de Goede wrote:
> The Lenovo Yoga Tab 3 Pro YT3-X90F needs the same handling as
> the Lenovo Yogabook models. That is it needs the extcon code to:
> 
> 1. Control the Vbus regulator and USB-role-switch for the micro-USB
>    port's host/device mode switching.
> 2. Register a power_supply device so that the charger-chip driver can
>    see what sort of charger (SDP/CDP/DCP) is connected.
> 
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
> ---
>  drivers/extcon/extcon-intel-cht-wc.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/extcon/extcon-intel-cht-wc.c b/drivers/extcon/extcon-intel-cht-wc.c
> index c45d7ff6cc61..323ab8731284 100644
> --- a/drivers/extcon/extcon-intel-cht-wc.c
> +++ b/drivers/extcon/extcon-intel-cht-wc.c
> @@ -539,6 +539,7 @@ static int cht_wc_extcon_probe(struct platform_device *pdev)
>  		cht_wc_extcon_set_gpio(ext, CHT_WC_VBUS_GPIO_CTLO, false);
>  		break;
>  	case INTEL_CHT_WC_LENOVO_YOGABOOK1:
> +	case INTEL_CHT_WC_LENOVO_YT3_X90:
>  		/* Do this first, as it may very well return -EPROBE_DEFER. */
>  		ret = cht_wc_extcon_get_role_sw_and_regulator(ext);
>  		if (ret)

Acked-by: Chanwoo Choi <cw00.choi@samsung.com>

Thanks.

-- 
Best Regards,
Samsung Electronics
Chanwoo Choi