Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp2792306rwb; Fri, 2 Dec 2022 15:23:23 -0800 (PST) X-Google-Smtp-Source: AA0mqf5C175fNEpQEuHq4AHIcIrTyF4Fm5gPhypULGoZDK9nvwQUO/KV2Vsvz8S/kGcccDSK1ThM X-Received: by 2002:a63:1708:0:b0:477:ba9c:d8f4 with SMTP id x8-20020a631708000000b00477ba9cd8f4mr41353482pgl.283.1670023403274; Fri, 02 Dec 2022 15:23:23 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1670023403; cv=none; d=google.com; s=arc-20160816; b=hRIChxy25HsFwyV21r5PABT5kcEiI/PK7GTFbsL9+y992h6KY0wUos+GXyx5cD+oDP NYaERKgNanEiCHQLSjiNNmS5yQF/bfU2ckwrMUdTBDkrNkkSSBwtvTzvB7SKnLefXoMn PVic3rD5MqrAkQKw8gFfjOuyBiEVgrAMu/geCJhBSMK1mlR2hwuGNGsUmTqw4m89x7bD xnmKsDk+JlD/MG7nYGBvhJXNnb5vCXjEwAk1JXbOS2Roj3ChXrceE8SlctW3ZDiFaYvQ N+CW/97dv4M54GyJKYL3Uj9reKbefxPTYLH7x8ePRHYVlHldt1+ehUVVCFqUxb9hMsuR Kydw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id; bh=yeaYWU+3i8hJhYxbYSjWcKLZ68H+ZM9quUzrKih1bmI=; b=uvZQDUixTreY06PzaT2OQlMIPRRYGJeuusD9A3FHpwBcB8GeHs8U6PFKcFFcJu7E3m 4E6Ab9oC32n2ZDLaQayOE6qRhdvqlYWma6odTko/HdCW1s76S3sRBkzS+92EALLJTum9 Y0Xs7iyS/63v0fMYVh/2ocJEeuJK67XsM5uTCKuTJ5yq10/HnzlEymTsbYJzzI7wfldM m5ubXtPzqoB1n2Z2ao87XnCDQZZLibXHwXEJXBtWdBgxO+B3aFdQYr/CPCizXtOs+mBT EHW31f90Ta0MSj6FzMHWuOR7WcFNFhs/gl9prVKkGp7bd5+iVPIq0Ptujf0+IIxtLokN akug== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=acm.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id nn13-20020a17090b38cd00b002129a8204d2si8823188pjb.44.2022.12.02.15.23.12; Fri, 02 Dec 2022 15:23:23 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=acm.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234639AbiLBXGk (ORCPT + 82 others); Fri, 2 Dec 2022 18:06:40 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36778 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234110AbiLBXGj (ORCPT ); Fri, 2 Dec 2022 18:06:39 -0500 Received: from mail-pf1-f173.google.com (mail-pf1-f173.google.com [209.85.210.173]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 72BF8E2543; Fri, 2 Dec 2022 15:06:38 -0800 (PST) Received: by mail-pf1-f173.google.com with SMTP id 130so6229932pfu.8; Fri, 02 Dec 2022 15:06:38 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=yeaYWU+3i8hJhYxbYSjWcKLZ68H+ZM9quUzrKih1bmI=; b=PXCMcae2/cyTtwdcdjU5kUBMaPmudQZ/MwFie64nB6UgI1VhyTFh+0HaCIGx9JhyZV IO5gYW7W/b1D2QKbndMshTH4imuJtjpv0jyvISTSQackLlEFgNUtNmuV9eRM8iTYqU+x Dhfu9hH8DnpfcSpypGIvWGeE1KrRzQjxrQgX5ZoIkHYV2ipmZjMsoqyEbFosN6qEXQXm fexxd7AAodtP4xWgQIQgmWGCn33v8Immvwd0VOQLriEgq1sB+RTt/isr0WvfxTaJebUw oooiUdonEQW689sJ3ICwxrEakLfOthmX50eMuaVb6v1JUydu1/5qYP49Rlx6WqtXX8Dv TklQ== X-Gm-Message-State: ANoB5pkJ2mU2axCeNEDHhb5cSfTAJzBveYnBAl3l3hclh+APH8Q1/Tji EKrLRO9aSwX1swI/34MJ8MUkbk4GDzo= X-Received: by 2002:a05:6a02:187:b0:46b:26a6:51bc with SMTP id bj7-20020a056a02018700b0046b26a651bcmr64720229pgb.204.1670022397719; Fri, 02 Dec 2022 15:06:37 -0800 (PST) Received: from [192.168.3.219] ([98.51.102.78]) by smtp.gmail.com with ESMTPSA id f14-20020aa7968e000000b0056bee23a80bsm5593515pfk.137.2022.12.02.15.06.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 02 Dec 2022 15:06:36 -0800 (PST) Message-ID: Date: Fri, 2 Dec 2022 15:06:35 -0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH v5 2/2] RDMA/srp: Fix error return code in srp_parse_options() Content-Language: en-US To: Wang Yufen , jgg@ziepe.ca, leon@kernel.org, dennis.dalessandro@cornelisnetworks.com Cc: linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org, andriy.shevchenko@linux.intel.com, bart.vanassche@wdc.com, easwar.hariharan@intel.com References: <1669953638-11747-1-git-send-email-wangyufen@huawei.com> <1669953638-11747-2-git-send-email-wangyufen@huawei.com> From: Bart Van Assche In-Reply-To: <1669953638-11747-2-git-send-email-wangyufen@huawei.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS, NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/1/22 20:00, Wang Yufen wrote: > In the previous iteration of the while loop, the "ret" may have been > assigned a value of 0, so the error return code -EINVAL may have been > incorrectly set to 0. To fix set valid return code before calling to > goto. Also investigate each case separately as Andy suggessted. Reviewed-by: Bart Van Assche