Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp2815023rwb; Fri, 2 Dec 2022 15:50:35 -0800 (PST) X-Google-Smtp-Source: AA0mqf4Zn5IDuCiPDVSRJ8v0PJAJvrfagcMPhcvq7v0TKU/5hpKIs4wGEB52igoofRX1iBioElwK X-Received: by 2002:a17:906:5a94:b0:7bc:34d3:31fe with SMTP id l20-20020a1709065a9400b007bc34d331femr34439703ejq.427.1670025034927; Fri, 02 Dec 2022 15:50:34 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1670025034; cv=none; d=google.com; s=arc-20160816; b=BP9ezo5NigjWERTWXoPidGQk6hzkzZnqe5gi8vsPbG7lJu/RNkPluRa/+daBZhl8Tu +wzdvxtP4wYisrySWPON0yEbGE1R6k1MIqMpKU6qWpbL18Jb7iafdhQUbANGkQ6rwf1a yf+80ZIt/IX+OFWTdo9eO0KEA0l2FnfA17h6SdHrOGRw3zW+y0vwQlIrq6nXSpJrNoSy Ghh0Jv41ZLZmbzYahoQkuLg0upe4JiulEgQu1RTuXXXidvMGALgKTFJESvD+nFogNCdo uhzwYfN9dF57oTo1F6h0tCsXuU+X8kqu6hBWaUg2dmthv5W0ckBwWs0/yhhx1mHTUSnT hCaw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=hp97z6Oq94kD4oNk7hwdd9jEwMoHqPZsQxvRNRE9SgY=; b=iuXUQpbnT3V7gHTAYze5aqBJM/KJKnMMpBBecno3n49A2gyMeuY15JXqkWFIpa1Erd CuLacz43IsmF7bYhecGK7rKOh71+khWQqK2C6ctFYW6mn9fjqSq/QqVfWBvPmNvqzOeq HsdYL2yKoq+GJ0lXfCQtGQeybLEF+9Lle4hbW7ksS4l6oRqiDHa+DZru9rG3S/SwRA8D QOjUFKnmxd7bagsg5ulGw+KDDavUOr9K0g0DrftWM241xjiwT+mrJPLiVnRm9/keQ6E6 Wz4XZz5euTc/ZZAaKZv724FC5oaNF0k3SkY3PLm6dpNKpAvBJUhBPSDGcuPA2wNcjnO9 d1aQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b="BqLJ8/+5"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id u20-20020a05640207d400b0046b0dedf5d5si7055829edy.199.2022.12.02.15.50.14; Fri, 02 Dec 2022 15:50:34 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b="BqLJ8/+5"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234457AbiLBXUg (ORCPT + 82 others); Fri, 2 Dec 2022 18:20:36 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49488 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229436AbiLBXUe (ORCPT ); Fri, 2 Dec 2022 18:20:34 -0500 Received: from mail-pf1-x436.google.com (mail-pf1-x436.google.com [IPv6:2607:f8b0:4864:20::436]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C98DCF7A29 for ; Fri, 2 Dec 2022 15:20:33 -0800 (PST) Received: by mail-pf1-x436.google.com with SMTP id 21so6269626pfw.4 for ; Fri, 02 Dec 2022 15:20:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=hp97z6Oq94kD4oNk7hwdd9jEwMoHqPZsQxvRNRE9SgY=; b=BqLJ8/+5cvlb+cGyYMCDD7XiYBv9EPehcr1jyW1WNfSLU6aCDvBxWm5YuzDczHH4c3 03C9HscCa1iN2yyNG2uH2+wY6uFVS+V+G7xCeau/3RW7UW0RCVGdqzyKHQrVeUt42qN9 deaXd7hnR5VKSqotdRfwcCJx+UaKb5Jf+u07Q= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=hp97z6Oq94kD4oNk7hwdd9jEwMoHqPZsQxvRNRE9SgY=; b=slPsfhWzp0Vhy8mnWU4C2H8wWZYAucEcDBJ/4Ij5sbfNJTOvtF7pSRIr7GKDXkbiLp iczhpd2gwOUxvcSVo1voV7AawEAFI7iVJaC4Zj1mDZzvwIlUWkYgxCIKQ+mf+45mwElK 0aHpamUtQLh2CyQGJKfc9YzdfEC5R35FWsc5CuY6WyhCccl2m7xppFShk5DJqGTEY1ao 2zFuCEjSggYS/S8YEHlElfTOZqP5+m2JDUpjmqvSXuoSlu1ER28lX5qVuR0wWeBDGr+I jkbhM/Zy7mMXTvNKf352Xwr34tmg3YrpTFswL7uHEhSgRQ4Ij593gOscCMOzUaHlniFB X+MQ== X-Gm-Message-State: ANoB5pm5jnEWB2mtuSXYuUgqpdDum9ZJcLRqAZkTsJgPXxxdGR4D2n7S rHSzvyvKxmGMyTjx4/vHL/PA5w== X-Received: by 2002:a62:8648:0:b0:56e:cbe8:9353 with SMTP id x69-20020a628648000000b0056ecbe89353mr54493372pfd.5.1670023233308; Fri, 02 Dec 2022 15:20:33 -0800 (PST) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id t3-20020a1709027fc300b00187022627d8sm6060166plb.62.2022.12.02.15.20.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 02 Dec 2022 15:20:32 -0800 (PST) From: Kees Cook To: wangyufen@huawei.com, ccross@android.com, anton@enomsg.org, Tony Luck Cc: Kees Cook , linux-kernel@vger.kernel.org Subject: Re: [PATCH] pstore/ram: Fix error return code in ramoops_probe() Date: Fri, 2 Dec 2022 15:20:29 -0800 Message-Id: <167002322852.1897586.7406208701529652326.b4-ty@chromium.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <1669969374-46582-1-git-send-email-wangyufen@huawei.com> References: <1669969374-46582-1-git-send-email-wangyufen@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2 Dec 2022 16:22:54 +0800, Wang Yufen wrote: > In the if (dev_of_node(dev) && !pdata) path, the "err" may be assigned a > value of 0, so the error return code -EINVAL may be incorrectly set > to 0. To fix set valid return code before calling to goto. > > Applied to for-next/pstore, thanks! [1/1] pstore/ram: Fix error return code in ramoops_probe() https://git.kernel.org/kees/c/e1fce564900f -- Kees Cook