Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <baf496c4-afb5-bb89-02eb-17a319618833@intel.com>
Date:   Fri, 2 Dec 2022 15:53:52 -0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.5.0
Subject: Re: [Patch V1 2/7] x86/microcode/intel: Remove retries on early
 microcode load
Content-Language: en-US
To:     Ashok Raj <ashok.raj@intel.com>, Borislav Petkov <bp@alien8.de>
CC:     X86-kernel <x86@kernel.org>,
        LKML Mailing List <linux-kernel@vger.kernel.org>,
        Dave Hansen <dave.hansen@intel.com>,
        "Tony Luck" <tony.luck@intel.com>, <alison.schofield@intel.com>,
        <reinette.chatre@intel.com>
References: <20221129210832.107850-1-ashok.raj@intel.com>
 <20221129210832.107850-3-ashok.raj@intel.com>
From:   Sohil Mehta <sohil.mehta@intel.com>
In-Reply-To: <20221129210832.107850-3-ashok.raj@intel.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MElEKzNnc3R4T1gvenFZYUhPUkorQVZmUXV5ZTRldFU4ODc4OTB6ek5BMllO?=
 =?utf-8?B?c0VVTUU2d2lFYlUzR0tpWWlYM3d5ZlByUWhnT1RRU1ZpNmhjd08yZXA4ZmRj?=
 =?utf-8?B?VGRHckZsQVdRMGJCeTJrUmN1RXNqZnYvWTUwZHZBY0NVN1BuL1NhZmRacnl5?=
 =?utf-8?B?bERIdndGRVJ0SGlDeEZBdjZxZmJIdC94Z1pmZUxKNUpCOXZSUDRWU0txNmZW?=
 =?utf-8?B?MWxBcGduVEY5RHdQL3VmTGRFZmRNeGpHYmUwSmxGSmVqRS9CMHlMOVlnT01L?=
 =?utf-8?B?Y0EwZUxGV3RFWmJueXAvb3BHM2c5SHl5QmpDL05SOXJTcTE3MTEwUjdleXhE?=
 =?utf-8?B?ZVd0aEM0SUdjMUdWaUN1aUp6YmZwNkcrbmZpbGpyeWZpMzRNUlROVUc3ODlQ?=
 =?utf-8?B?bmpQKzBlK3lHS0VNQWJ2a3VkM1hFUkxwRmYyT2wyYmlDSVRZL0ZJVXg4RW1F?=
 =?utf-8?B?ZmJ0ZDYzd0hZR0htNVhXck0xTmx3UTROMVhmL2VpeDdGbEcvQ0N0Tk5jek8x?=
 =?utf-8?B?VWtZVzFnQ3V2Q0hnbzNWOFpNQk9taGIvVUxMbWRYUWZwbTJFaXBLSis1NGJq?=
 =?utf-8?B?YXhjZDVUNG1sWVNUNTNrUlVaMXFDMzlJNGxiOGNvcG9oWVRVaUtiRU1LWU1I?=
 =?utf-8?B?cnNPYit0U2hVUEF1K2FMVXBkVFF3VG1TemtJYjU2K1NrN0kxQjkwVGVIVjJx?=
 =?utf-8?B?dCtJS3BCMTlGMmdvazFaUFMrNWNhclk3RkNKWkJvTm0vc2tLRUhqbEZrS1NP?=
 =?utf-8?B?bHk5RzZSOXRtVUpiNGNKVEl5R3Q3ZEp6cHBSWmZMZXdwellUMTFxeGxwd3RE?=
 =?utf-8?B?Mm1KSzJCZ2I4S1ZuVHZUU05yVUJBVUMwU29wZzhpaWlJR0tnRHpVM2JtZXpp?=
 =?utf-8?B?L2NXamZXNzJ1dkxLUjhxSUFXZHhHOGFGSjIyQlZoSUJiM1gxdGpLOHJiUk43?=
 =?utf-8?B?a0YxWXpNc25KU2tYcDVNazdXYjhIQTFmeEp4b3gybzJHZzF5K3hMb3Vnbm54?=
 =?utf-8?B?Uk4yVzYvV0RrcHoxNUFXTFpLdW9aU3llR1hyUU4vRUdjWEdnYjczL3FrU2xR?=
 =?utf-8?B?bldBa21CZlBLS0hiVWZ5Tjl1TDhnTG5GTTZXakU5NEtiTTErMjNlZUV0TFFG?=
 =?utf-8?B?WllENzI3TW5HNG5CUWEwVmNKUXVrcWdWck5JNWtqdzZOSklxaGJScHBQUUZD?=
 =?utf-8?B?QVpOcXpBTkg1c0dZY1BnQ05YQ1R2eXh4KzBDQU5oZDZNd2VBL3NEbGhqZVIz?=
 =?utf-8?B?cnBlMW4yT0IvUHVMUy84ZUhLbzNhTFUvaDBNYk96dHV6aWR5NGxxSksvU09Y?=
 =?utf-8?B?RUpPd2xUeER2L1hqNGxWYzJ3VXVTWURweWVuT3hiQzVkRG1ySDRGU2F1dFBk?=
 =?utf-8?B?VTZzMTV4YXkvQ3RLSVZXcFJJRnFidkVtZVFmVTQxcHlIZkVYODBFNkk2SUMz?=
 =?utf-8?B?WmJSa1FmZkVkdVpEVExUUTRzbzdUWkluZVE3QUNIczlCem9PdWF5eVI2aitr?=
 =?utf-8?B?ZkNmTThqRGU2dllaSU9ncXllelo3NmZsV3N1ZG50RFAyUUdNRGhGZUdFb2ht?=
 =?utf-8?B?cktDQkZUaVA5T0Y4dyt0Y2R3WStidHM3RjZBRFl3dUEyTDYrTldOdHA3bXpJ?=
 =?utf-8?B?TWhvSUxlTVppbm9IaWtkem12ZmlwQ0xQQmpLOWh4OFNCc25jbDd1M3M2eXZq?=
 =?utf-8?B?c3JEeXRncEJYRzZXa2d4VHZFVHBETFFhTFlHbE1pWjFYS1A3d0h0Znd5SFIx?=
 =?utf-8?B?RDFDaXdMSjQwYnpXZmVIQ0pnd2N1SWdINzl5a01Wa1hwcXg0NUxUZTVsQXpP?=
 =?utf-8?B?djg1dTF3NGZPcmtqR1ltQklMOTJqMlg3SXFWUFlEdjc1ZkMxeXZPSFNkcWZH?=
 =?utf-8?B?L3RWbFJ1OWRnLzcxRmJpZ0xBS01QZ3k2Q2M1ODZveG00NVdRcDlkM2xiRlVU?=
 =?utf-8?B?cGlpNDd1VWFGYUhaMVk3bHcrKzNCMjVCZXZ0dmhUdnhWcUZwaU1WQ2xuK3dM?=
 =?utf-8?B?SjNtcFlXUk9BK0hHSjV5U2JrdlNHb1pLa2wxYzJPczlGTnc4YXpRL3FHMjlS?=
 =?utf-8?B?cG9kL1psRmlSSThrdlEzZFBNRHRTYWo3VTloMWdzTVJ4aTR3QjY1aXNXVEx6?=
 =?utf-8?Q?XD/rQSx0FEPoShEm2aFSp9seM?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 07080afb-d7a9-4a9b-dfb4-08dad4c077c0
X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3320.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Dec 2022 23:53:53.5222
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: UA4Xd6+DiQNpvMtKBTDAXeQ8jE9vIWfBPbBReQ97uYzngKPYHDVcVicTfX42kUxInFpGXRjLtEaI1rDuFYzuwg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB5866
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 11/29/2022 1:08 PM, Ashok Raj wrote:
> -
> -	if (apply_microcode_early(&uci, true)) {
> -		/* Mixed-silicon system? Try to refetch the proper patch: */
> -		*iup = NULL;
> -
> -		goto reget;
> -	}
> +	apply_microcode_early(&uci, true);

After this change, none of the callers of apply_microcode_early() check 
the return code.

In future, do we expect callers to care about the return code? The rest 
patches in this series don't seem to suggest so. Also, the expected 
error printing happens in the function itself.

Should the return type for apply_microcode_early() be changed to void 
(in a follow-up patch)?

Sohil