Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 2 Dec 2022 16:21:32 -0800
From:   Ashok Raj <ashok.raj@intel.com>
To:     Sohil Mehta <sohil.mehta@intel.com>
CC:     X86-kernel <x86@kernel.org>,
        LKML Mailing List <linux-kernel@vger.kernel.org>,
        Dave Hansen <dave.hansen@intel.com>,
        "Tony Luck" <tony.luck@intel.com>, <alison.schofield@intel.com>,
        <reinette.chatre@intel.com>, Borislav Petkov <bp@alien8.de>,
        Ashok Raj <ashok.raj@intel.com>
Subject: Re: [Patch V1 3/7] x86/microcode/core: Move microcode_check() to
 cpu/microcode/core.c
Message-ID: <Y4qWjJOwQ/YsiRT0@a4bf019067fa.jf.intel.com>
References: <20221129210832.107850-1-ashok.raj@intel.com>
 <20221129210832.107850-4-ashok.raj@intel.com>
 <f46f133e-d401-a91b-b67a-cca278f171f2@intel.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <f46f133e-d401-a91b-b67a-cca278f171f2@intel.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?KiEe/pjNZTQS8T7F2ocLFJx2+S6/jYUgO67J32is9xM4KF9F2dO9gIVKoqxE?=
 =?us-ascii?Q?cRevx+O0tQzoP4BLvDPbmQijX3j1vLzbBs0okJTwh8eMT4GwKV1zfatyCJll?=
 =?us-ascii?Q?Uhlm0a875LREAK3xmtEWvDuc29kIuKxOYxPsigexu6dhKsioWg81HohpT0mt?=
 =?us-ascii?Q?22eoRs2tej13oY3io9FxdG9zqFd0+B91TEtcdB+FtdjKOMPQukDQ/3rpTKyK?=
 =?us-ascii?Q?ksR1AbmgRrN1TBe22kEhfc1U0U9UXz+kO93YiTFCCIEZFWavL+yRdRVVyIwr?=
 =?us-ascii?Q?qN6vMIY+HnsJxYWQmZY2Ph9KWxL4CdYu7S+kLx6bTH2kFKQh1ltMpKQRZP6g?=
 =?us-ascii?Q?Tzdwd5xau/cIkJcvPRfCFjVLc/jOnm9JtlNIwhjnq9/JcYRLF0HA8EAdOx8e?=
 =?us-ascii?Q?fCK8Hca53cBy2cE6X8jXOczuNF/o6Mr4lzwIXvkIJeRq8TH43e8CZZkE74xP?=
 =?us-ascii?Q?un8btShr6zDFy64p1tBIa+skyz5LCcdfS1u3Pj5rnLlC3XzKu/lZ/oW94Nii?=
 =?us-ascii?Q?nvNLfX8eLFqF3D85vB5+KZqjEnZ9htzjaAYhQ1bXpy19sQ450Ir/3AG9BfKB?=
 =?us-ascii?Q?LQjpRvbaGj+aYdChbbSDBnqycG2oxDN1jUDnvkzdXkZqEUTCjED1a+KQK5ia?=
 =?us-ascii?Q?kZcc8Rmvih7t1hoRGrqMCeW3rC0Gk4rz+C9d/7p1OCwDBe5BxxEP3wDNR5IC?=
 =?us-ascii?Q?k+OYYFg5rARElwSyirUuHsIdGCyx72ZtPuBPDCelr24iUPd79apnE1/wSqu/?=
 =?us-ascii?Q?Qx8DqVuz/g2SFBVhRgmkHed+IrKiZT/pYLXaUpTMAwTPDkkFNGv6PiAVepET?=
 =?us-ascii?Q?pkaBWd6gCMnC+gBg3ue9MupPGNpHkvTHbTiQm858trXzqiEUuUXhaWuDjFiU?=
 =?us-ascii?Q?6+He7jmz2awAsFO0hyvnuENmqMPclZcTZ9Wb7oDLYEx7xA+Y6AdJK5Hx8imZ?=
 =?us-ascii?Q?5fm9TVM7wjhKDiKJeJ9dB1p+I4ECe0kE675GUYa348lkqVNL5OnicTkL5i9c?=
 =?us-ascii?Q?E38y6CcztZ9n6FvqKo0ZOGTWwmlaj3am/AbtQU+ga76ZA3O73dG14L20k32X?=
 =?us-ascii?Q?2INhzKbXzON6E/iO4nQ6ksxHOCvlj4Yv6yubnPHCfEB0lrxeWORvgi6Fhz8a?=
 =?us-ascii?Q?iO9+L/ldhvYqYdQguZDy46ms27cMg8Jp7OLv1wO2UZV0+EUARuLVSm83zna4?=
 =?us-ascii?Q?7k6X/p9E7xHKvdBvVjadxVuExsL1jw+aJ7uFN2Bz2LmPrvnFlVTMeE0Hi9fn?=
 =?us-ascii?Q?n8AJ8BNm5cRNWPr7GdDxKpztq5ksPqYjj4tuIQtNWA4Z0XvfBkQ5G/s0NXhD?=
 =?us-ascii?Q?EFosPe5YBpR8plxU0DonMdtE/wDIuzMrnXv+2IeAIg+VlPSFauAxvhGszpYP?=
 =?us-ascii?Q?WzRXAAdolizZ/5s8lzshx8DSzGEtYKWJEJougObFCWGlvu5A5G4Fb/BYg2Yv?=
 =?us-ascii?Q?KG6AAEfa9qsvvwDtPZV08tDzv2CAEiTfunLjrZ5+UiQmahcm6vIqdz/56aKO?=
 =?us-ascii?Q?14U09yuLIRB2Tpx8ZP0kjzbovYmUifuhENNa9zrM6F1NcCB9quUe5wp1Kyo+?=
 =?us-ascii?Q?MkvdJ83pNCNiL9zXGUra+fWQCTuHPDpegDAZU1a7?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 0fd8146d-1624-4f6b-a790-08dad4c45805
X-MS-Exchange-CrossTenant-AuthSource: SJ1PR11MB6201.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Dec 2022 00:21:39.9760
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 9Rr5GHV3JxN9xxuTWjgN05UX8AIf2gOnmWMp6y0jsaYDqz3Ev0Za1QqADgS/7jKNBEagOmHE5+fOPXfzRSbyRg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB7206
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Dec 02, 2022 at 12:57:23PM -0800, Mehta, Sohil wrote:
> On 11/29/2022 1:08 PM, Ashok Raj wrote:
> > microcode_check() is only called from microcode/core.c. Move it and make
> > it static to prepare for upcoming fix of false negative when checking CPU
> > features after a microcode update.
> 
> Should we use this opportunity to also make the function name a bit more
> descriptive? microcode_check() seems very ambiguous to a first time reader.
> 
> > +/*
> > + * The microcode loader calls this upon late microcode load to recheck features,
> > + * only when microcode has been updated. Caller holds microcode_mutex and CPU
> > + * hotplug lock.
> > + */
> > +static void microcode_check(void)
> 
> How about, microcode_recheck_features() or simply recheck_features() since
> it is static now?

I suppose we could. But given that the function already has some comments
around it and its not having multiple call sites, it seems to be reasonably
serving its named purpose :-)

Cheers,
Ashok