Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sat, 3 Dec 2022 02:23:22 +0100
From:   Sebastian Reichel <sebastian.reichel@collabora.com>
To:     Chris Morgan <macroalpha82@gmail.com>
Cc:     Qiheng Lin <linqiheng@huawei.com>, linux-pm@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] power: supply: Fix refcount leak in rk817_charger_probe
Message-ID: <20221203012322.pfempb5m4qtj6mjm@mercury.elektranox.org>
References: <20221128142740.1414-1-linqiheng@huawei.com>
 <638642f3.050a0220.8b7f1.d555@mx.google.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="w6mbcapmpzzamqzj"
Content-Disposition: inline
In-Reply-To: <638642f3.050a0220.8b7f1.d555@mx.google.com>
Precedence: bulk


--w6mbcapmpzzamqzj
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi,

On Tue, Nov 29, 2022 at 11:35:45AM -0600, Chris Morgan wrote:
> On Mon, Nov 28, 2022 at 10:27:40PM +0800, Qiheng Lin wrote:
> > of_get_child_by_name() returns a node pointer with refcount
> > incremented, we should use of_node_put() on it when not need anymore.
> > Add missing of_node_put() to avoid refcount leak.
> >=20
> > Fixes: 11cb8da0189b ("power: supply: Add charger driver for Rockchip RK=
817")
> > Signed-off-by: Qiheng Lin <linqiheng@huawei.com>
>=20
> Good catch, thank you!
>=20
> Reviewed-by: Chris Morgan <macromorgan@hotmail.com>

Thanks, merged.

-- Sebastian

> > ---
> >  drivers/power/supply/rk817_charger.c | 4 +++-
> >  1 file changed, 3 insertions(+), 1 deletion(-)
> >=20
> > diff --git a/drivers/power/supply/rk817_charger.c b/drivers/power/suppl=
y/rk817_charger.c
> > index 635f051b0821..d25a81d79fac 100644
> > --- a/drivers/power/supply/rk817_charger.c
> > +++ b/drivers/power/supply/rk817_charger.c
> > @@ -1060,8 +1060,10 @@ static int rk817_charger_probe(struct platform_d=
evice *pdev)
> >  		return -ENODEV;
> >=20
> >  	charger =3D devm_kzalloc(&pdev->dev, sizeof(*charger), GFP_KERNEL);
> > -	if (!charger)
> > +	if (!charger) {
> > +		of_node_put(node);
> >  		return -ENOMEM;
> > +	}
> >=20
> >  	charger->rk808 =3D rk808;
> >=20
> > --
> > 2.32.0
> >=20

--w6mbcapmpzzamqzj
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEE72YNB0Y/i3JqeVQT2O7X88g7+poFAmOKpQYACgkQ2O7X88g7
+pr0TA/+LmliblYQ0qVceGiVsTJnEuRbNevemtyfA9n7+Pl4fwq1uv08/RJXzXTl
7EERJ7SJIzDz+XHZkN8Frbvw+f/2QwN1jL0VHIPFxizN/OXBJ7MnmQrVheB/3uHh
OWwMidbGFsHsPHpt4qumU0NN2AbXnBMwD9gg4tcJXUsGrIP5rfC7apnNvZv2+/bb
+UHhxjmDVs4WCnYGVO6rqxqcwtFhEiwkzVggfI4aGzqXD+3AaCg6LXK/OpqHs7I6
G6sMK48R3e5CZWr3YplPElMQEpWKzpWsvIe/ZDvRzo6gzWyPZUsPDK1WY+2Txmlk
jnfOSac+OX7JJ1uNTTRm97ypVUizKbGtFoSkiFCieI/TePCl1kQng1beQVphiki/
Bzom8q0j1tFEAUhlLmilFkM85noSaoCoEqKeckIYxkkzKY31zgfdjLTK+Ea6MtKd
nf5QHSCZLChcXioNUf4Ib4pJ3jVLjm3DLyplCfu8nSR5gy0kT27EMIDVAHSi2zp5
xzi2CsG4m9kDbtIMLZXeP/Qn8j9XDtvOnuMPhvBOWgc1IQNPL/KfDm1Lqj4bCJqo
socICvZ+YzMU4/4tCs/2wbYPCeBYGr1iH1ZHhAsGDUVUaAIz+QCwfLSOTOByEr73
l7i7HZO4mcTgsMkpaAIAj4kKhk4tXUS4CPirBgk3wrgROT3o4EM=
=7IdE
-----END PGP SIGNATURE-----

--w6mbcapmpzzamqzj--