Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 2 Dec 2022 17:48:57 -0800
From:   Ashok Raj <ashok.raj@intel.com>
To:     Thomas Gleixner <tglx@linutronix.de>
CC:     Borislav Petkov <bp@alien8.de>, X86-kernel <x86@kernel.org>,
        "LKML Mailing List" <linux-kernel@vger.kernel.org>,
        Dave Hansen <dave.hansen@intel.com>,
        Tony Luck <tony.luck@intel.com>, <alison.schofield@intel.com>,
        <reinette.chatre@intel.com>, Ashok Raj <ashok.raj@intel.com>
Subject: Re: [Patch V1 2/7] x86/microcode/intel: Remove retries on early
 microcode load
Message-ID: <Y4qrCUm4xjBoe46R@a4bf019067fa.jf.intel.com>
References: <20221129210832.107850-1-ashok.raj@intel.com>
 <20221129210832.107850-3-ashok.raj@intel.com>
 <87a645pr31.ffs@tglx>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <87a645pr31.ffs@tglx>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?A06eyR4CcgExGnksCXpvxz7L1ZrRUTp9YH3DwnDXHuhwu/jdhMjSPzAxzcLj?=
 =?us-ascii?Q?8JyHHaf4o9gh3Vsmz0BSfAkNZEAgE7UGwljty8kUFR/N9pXuStLiLxMXE9Ij?=
 =?us-ascii?Q?JicSaNiKwamC3I+3MgeWLtlSNQ3ZC1+qRK4ADPmv/rKcUoTS7NzpTED2Ds/L?=
 =?us-ascii?Q?NYCuFiiqv2fB0mjMjoyBuLfjl9+A+57RkoFJrj1JRT23ai0SUeyXPORoF2Ya?=
 =?us-ascii?Q?mxv1NdGguxXQ0v6FBVUs3ZhED2Caf0z1Cf5Dn3IKBOMbOmGygIfFdGNAz8wu?=
 =?us-ascii?Q?SIowQybwzWV7JxQj8kZJOZcaO6cHtd4d/EN7LMqdVT8+/iXqcWsMQ+QUyi+r?=
 =?us-ascii?Q?qyqwhYLKdGkNOwlK2/Gm27cOlED3a4k9VlWpN/HgEFBkozl2mxpP2CpD5O3q?=
 =?us-ascii?Q?6XjDcgsN++SqVJm7e9G1OkabjFwUSp3lW3E4Kz2tToQfKChevwGdkjsXppmB?=
 =?us-ascii?Q?QCSTu4Q5awCP781NzYxobOQsyuDkp6Eh0txkDVugSfUv9i+TZ/jVb7aBszx7?=
 =?us-ascii?Q?MZVcJ8j0nPHTZIaydnFlqpbWKK+0FAVGy/v0rbyaBtI1rLNEcYE8DAq0cZFv?=
 =?us-ascii?Q?aCNvZkx46ndtj54SCsHWREWeD8iMDScrg+0FVcpF/edlZbvJwDDTJtkHfwme?=
 =?us-ascii?Q?b5Y3mvt4tmHhuurB970TX6i7/yPKsdzQZlwNvuQcFGu3x9MMw9DXA4rOk1R/?=
 =?us-ascii?Q?+OSbv1mYJTfYPIh0MWFP+aJ8psfv3Atwcuj+uHHC/nKDr1OzwRyvtyl7i567?=
 =?us-ascii?Q?LpxAg7EDqGnOXtop2KuTz5nvbI7Zu2xPnrSs6kNRwJqmbj025EgPJNuYC3ak?=
 =?us-ascii?Q?qhl6INsP6osR+eSVxhyBE1R/Au7VkHZ6Z93/QwRvrgOlPQiefchbab7IKZ0t?=
 =?us-ascii?Q?ZLkdbUeEajgeiDaa3ATVYTmV0rJYjgkZsPuquY/D659BVtVQ2nCLbkkMVu2g?=
 =?us-ascii?Q?pHqowSs+vqpheQFJadeKBOroO55R8lzPcg6HGhORVqMaCnMFRdI1V593XYIp?=
 =?us-ascii?Q?PmYhcDuVZBFxTRwv8BkHUgoRy00Vf5Cp94GueXC9Gs2wdHmGjWlPPWf2m9Uo?=
 =?us-ascii?Q?EFRtcAOw2FS1Ik18qEOF+DUeChYxCPSVkW6Cs0D+1SjLstJxZfDC5C+3MR7+?=
 =?us-ascii?Q?3WFda59ohcdPyMaqsvFo2PqwcazYi+ihq4IReqxUCoKAFIlvux2YpEoQ7bMb?=
 =?us-ascii?Q?mBko2ke6wkg9Q6o2aVcULBIQq66PKJbQ6/yEVoU68x6MdtuSzHaS7WrQqGtI?=
 =?us-ascii?Q?osfmcTiMFsMnpr8KXKo4kztc6pm+nDWGOkIqFPCVE63iJ/QBb41UpmPaCnKw?=
 =?us-ascii?Q?DLToEwfv3F/m8HxXHFadUEkMoFzZpi32t0W9XzZ8IzRj/eTyyNBEfFDnCGCq?=
 =?us-ascii?Q?N4EPQMTASUtS9IVy7eA0zwpT/9ZT5QFzC865arUcbNe0FxKsFBzZlCqz8qHq?=
 =?us-ascii?Q?k2Nzr0aLWLDb/BYnX/WVb6uE3i/1nZVUSfwymOnXRAh1+kEOjjR7hRAa/XEB?=
 =?us-ascii?Q?bhedKeULUzvs7hF9/emC5FeiKEBz3qeMJ4+Ik6/nG2y95qZN1mSDv8S71jGT?=
 =?us-ascii?Q?BQLp20DqFw0T987JmnrZekTrZ+O6l89rthmLoAg8ywJVXCRgsjoXeGrHZPvc?=
 =?us-ascii?Q?Sg=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 576447cf-eed9-46d7-48de-08dad4d08ca6
X-MS-Exchange-CrossTenant-AuthSource: SJ1PR11MB6201.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Dec 2022 01:49:00.5121
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: /5GkCHSl5l/KhWuTWg5HBW4o8huLOkndR5y80CjbaRThJaM8TNbvaF5WuMsaf4tyqXT897yR/y4mkEWMeJjI7A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR11MB7058
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI,
        SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Dec 02, 2022 at 08:01:54PM +0100, Thomas Gleixner wrote:
> On Tue, Nov 29 2022 at 13:08, Ashok Raj wrote:
> > Microcode loading can fail. This happens today when handling mixed
> > steppings. But it can also happen for other reasons such as corrupted
> > image, Security Version Number (SVN) preventing anti-rollback,
> > dependencies on BIOS loaded microcode image for some capabilities.
> >
> > When the microcode loading fails, the kernel will quietly hang at boot.
> > This has been observed by end users (Links below) who had to revert their
> > microcode packages in order to boot again.
> >
> > The hang is due to an infinite retry loop. The retries were in place to
> > support systems with mixed steppings. Now that mixed steppings are no
> > longer supported, there is only one microcode image at a time. Any retries
> > will simply reattempt to apply the same image over and over without making
> > progress.
> >
> > Some possible past bugs that could be due to this bug are below.
> >
> > There is no direct evidence that these end user issues were caused by this
> > retry loop. However, the early boot hangs along with reverting the
> > microcode update workaround provide strong circumstantial evidence to
> > support the theory that they are linked.
> >
> > Remove the retry loop and only attempt to apply microcode once.
> 
> Very concise and informative changelog. See, you can do it :)
> 
> > Link: https://bugs.launchpad.net/ubuntu/+source/intel-microcode/+bug/1911959
> > Link: https://forums.linuxmint.com/viewtopic.php?p=1827032#1827032
> > Link: https://askubuntu.com/questions/1291486/boot-crash-after-latest-update-of-intel-microcode-nov-11-2020
> > Fixes: 06b8534cb728 ("x86/microcode: Rework microcode loading")
> > Cc: stable@vger.kernel.org
> > Signed-off-by: Ashok Raj <ashok.raj@intel.com>
> 
> Nit: Can you order the tags according to the tip documentation next time
>      please?
> 
> Reviewed-by: Thomas Gleixner <tglx@linutronix.de>

Thanks!. Dave Hansen gave me script to order them correctly :-).. I'll fix
when i repost them.