Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp3073878rwb;
        Fri, 2 Dec 2022 21:31:23 -0800 (PST)
X-Google-Smtp-Source: AA0mqf7DPWhFRx99xwN3Eq5zsJbMtBiti8OSgHyoHXkTuIXiEGO3Jn8TsiD0lZTaZCVSk541XGxn
X-Received: by 2002:a17:90a:b706:b0:212:e75b:1602 with SMTP id l6-20020a17090ab70600b00212e75b1602mr78291299pjr.139.1670045482828;
        Fri, 02 Dec 2022 21:31:22 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; t=1670045482; cv=none;
        d=google.com; s=arc-20160816;
        b=is9DtvHEWEIK6ivPnR6PvvJ3QZzUhyUrm5iUDrJP+4wmbhwufX49PTQKrfsDSR/E26
         lsD3A5LDgIh0A8nLIeeJmugX+l+UT56IWuDgVlIgy6c/A9oRcD1cqC3yKfx6r+ef3tS6
         g17RMf0KFkiXM3XevPIxn5CIxM9folY5bWmDa1NG8/Xg+wJFyeGHCShob/0DJ2nJV0vh
         Y9p/5dtC1bVJqLVQCNxk4uSdQjTmyXqp8cl80X1NTvOjjLRZ79dBlXaLzAEwjMyn7z1D
         z/sKLAGtduBbBwR+uFjV+Phv02Zlciab3u7g/LzZIwfRgdGQY7DiDiwz5LTpud2lJ3pO
         hZsg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:content-transfer-encoding:mime-version
         :references:in-reply-to:message-id:subject:cc:to:from:date
         :dkim-signature;
        bh=8tcQ8u2UVQOELPil/2I49l51np9qS+r7Vul4L+RHy5o=;
        b=Bmxf5w87/Y1Z/nqUPkaYkG23WkxEj2uIS0FeC1S30Yw91zJvUAVSr53/TIAEoXeS/C
         ddi695p/S7hQER1WzmY+N9VnDdF3lb4nX2k+ZaXzaBo9G5Scmd1yUHGCfp/8/+n5vVdN
         KxOR28R/UFOU9pdIpzcAG7NFDC38jy7IpmRAiiZQl/PYGFN1CGH4tmKddiuhl/GH/x3M
         xQHBOrRjEEidNbC2EjUSCjhBMlc9AKK3RjZGNMyNopGsA9iWJC/ukOnyvPy28VxJYoij
         vfdJJ84caHR1Dr8FpVjwma/iZ4OmYYixqc4P47bsdttGIibDzNkic/A5oqN9h9P1vAAs
         s5/A==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@kernel.org header.s=k20201202 header.b=A7XUbRZJ;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20])
        by mx.google.com with ESMTP id h189-20020a636cc6000000b00476c9add60bsi8633217pgc.404.2022.12.02.21.31.06;
        Fri, 02 Dec 2022 21:31:22 -0800 (PST)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@kernel.org header.s=k20201202 header.b=A7XUbRZJ;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S231310AbiLCE7x (ORCPT <rfc822;2bno13@gmail.com> + 83 others);
        Fri, 2 Dec 2022 23:59:53 -0500
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34358 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S231285AbiLCE7u (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 2 Dec 2022 23:59:50 -0500
Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E3527C5E00;
        Fri,  2 Dec 2022 20:59:49 -0800 (PST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
        (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
        (No client certificate requested)
        by dfw.source.kernel.org (Postfix) with ESMTPS id 7E3E260F7D;
        Sat,  3 Dec 2022 04:59:49 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 737D9C433D6;
        Sat,  3 Dec 2022 04:59:48 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
        s=k20201202; t=1670043588;
        bh=iDabNK+qHFzYeXCjIx3inwDEOC5l3HWEnuS+ahRLzLk=;
        h=Date:From:To:Cc:Subject:In-Reply-To:References:From;
        b=A7XUbRZJj38kac+2/ow9JcavYG1D5Mw5WfPFDDus4nvPfAxLnyoRD3rDa/92VpbJ+
         zPuPOLx3aGYY3eLmvf7r2nR2P1cFSldaBwrWPa0LomXXvhX1Ns64zrcdEhy9Ow0Z3k
         guRDUO7FWRJaE/FQeJ/s2a0qASAEYVXvylMYOI/ghUCg3Nz7ZOEdivHsh4ArRYLjyE
         7eZx5MorWcmys4rRTPc1Zl6y4S7r1m8sNzqEyB49G66sLy5CtotPg1qWu09qlAQWd+
         VO6Clqfq5ZmBYySDnJHnEgmOwIHEKkpIuBgPk2M86BzmtcW1J4X9tVYYmW+kgq4Ayj
         okAkLpU21j4Ug==
Date:   Fri, 2 Dec 2022 20:59:47 -0800
From:   Jakub Kicinski <kuba@kernel.org>
To:     Li Qiong <liqiong@nfschina.com>
Cc:     Jamal Hadi Salim <jhs@mojatatu.com>,
        Cong Wang <xiyou.wangcong@gmail.com>,
        Jiri Pirko <jiri@resnulli.us>,
        "David S . Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Paolo Abeni <pabeni@redhat.com>, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org, Yu Zhe <yuzhe@nfschina.com>
Subject: Re: [PATCH] net: sched: fix a error path in fw_change()
Message-ID: <20221202205947.7175aad1@kernel.org>
In-Reply-To: <20221201151532.25433-1-liqiong@nfschina.com>
References: <20221201151532.25433-1-liqiong@nfschina.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI,
        SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu,  1 Dec 2022 23:15:32 +0800 Li Qiong wrote:
> The 'pfp' pointer could be null if can't find the target filter.
> Check 'pfp' pointer and fix this error path.

Sounds like a fix, we need a Fixes tag.