Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp3074984rwb;
        Fri, 2 Dec 2022 21:32:52 -0800 (PST)
X-Google-Smtp-Source: AA0mqf5aJNkJCRdf3AdnWIXQrTIaeAkafpokD0wmQWZYNHpnfr7SUkqfWFUVL0gBmbg2oW3RtaDp
X-Received: by 2002:a17:902:7782:b0:189:c20f:8b56 with SMTP id o2-20020a170902778200b00189c20f8b56mr3996214pll.150.1670045572231;
        Fri, 02 Dec 2022 21:32:52 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; t=1670045572; cv=none;
        d=google.com; s=arc-20160816;
        b=olKarOiQMT5hil4dmnS5n7sZsSgmoWflFdscpHQR3+0Ceqhdc6j1SCEL9JXr9DbEVO
         ka5JRqpyBu4SqoY9aHKEaLjzTfWKHhS/rV49MX8bKIqJ507/0dLRwPBMl+yioZubrMWd
         yICmC/7C4Uv8BX1myr4EkZUOX24to7FKHLT9JqmRbOrq2wrlyZBcsP2GJ1alhVGFsaRX
         4gaclavB8B7y+vakFpVSKzFx9A4X0p3Vj1qxOKvA+iwLaZzraCCnJUImvNuBLIC0NtXy
         6GkuwuI4KSwNmhIgbLzPTA3H6QDewGswJqFx4v1gGsnK30fqNo5GIAA78mEl8GRbW6av
         7fQA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:content-transfer-encoding:mime-version
         :references:in-reply-to:message-id:subject:cc:to:from:date
         :dkim-signature;
        bh=WLqBpD/hSijALuUZgakx2ku24eQYSRBUVggDObxBitk=;
        b=pMrAFV6ekUPkoW5OKi3YZ1RULyA8Ee2ZoyxHDjB+t4SgRmzX8oui75ukkiq/sHmsvo
         9ie1ZCzJFm3ms8zEFZS4kuu3dDZPmofvYfE7ohtouwQxaxQlJO3j88dwW3oSgOf3hfMo
         Xo+x5qbEHfMHxstI3Hkrwub+o6EwaRKqAUIoo5Bs+IMTUXeAw3C7w0hIRIrI9L8he/Nz
         PZnBic+NdmczqQrM+TGsTRuPncJJzPA3cp50iXfiwADDoSYIn29F1c0UeAsOnahhWE26
         B5FWO8HO3DDZFkipWGxZnOPrxfpQquoEPfkqmwudhlJx8SkmF9iS75qrujNMw8gZ4PN3
         h+Eg==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@kernel.org header.s=k20201202 header.b=TzK10HAu;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20])
        by mx.google.com with ESMTP id ix4-20020a170902f80400b0018725be1285si8286543plb.558.2022.12.02.21.32.42;
        Fri, 02 Dec 2022 21:32:52 -0800 (PST)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@kernel.org header.s=k20201202 header.b=TzK10HAu;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S231281AbiLCE7N (ORCPT <rfc822;2bno13@gmail.com> + 82 others);
        Fri, 2 Dec 2022 23:59:13 -0500
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34040 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S231225AbiLCE7L (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 2 Dec 2022 23:59:11 -0500
Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BB1BFC5126;
        Fri,  2 Dec 2022 20:59:10 -0800 (PST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
        (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
        (No client certificate requested)
        by dfw.source.kernel.org (Postfix) with ESMTPS id F0E0560EC4;
        Sat,  3 Dec 2022 04:59:09 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id D542BC433D6;
        Sat,  3 Dec 2022 04:59:08 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
        s=k20201202; t=1670043549;
        bh=WLqBpD/hSijALuUZgakx2ku24eQYSRBUVggDObxBitk=;
        h=Date:From:To:Cc:Subject:In-Reply-To:References:From;
        b=TzK10HAu0CIj719qjw8PCN2xzDB73wBFHbXEp/E3lMahLs81IOyNEOfrbIimej+BM
         QuwIlkQ/V8h9ZaUnCmsPpcXkubbgeRK0Ng60VRClOtHROKE4XcGKMDMzBPFMrlF3k/
         3oa59IA8W22yfIFAspjpqTyqyIFvLRPLPTFZ91QI4YZmaaoIzhMZJUTX3k2mAND1wf
         +APOJYi7+pvaqPZcMM0BZWE2cJX0UbcJ34wH66XgzjaWUy0p92D1UEZdAHP9zajGHA
         Q0uWzb47lNPN8R54wz52EgV5/SfoCqoLLvfgaNaMAUeRr+xpb3SFwY9MQcvEg9KgIn
         aRF9eGyfsdsrg==
Date:   Fri, 2 Dec 2022 20:59:07 -0800
From:   Jakub Kicinski <kuba@kernel.org>
To:     Qiheng Lin <linqiheng@huawei.com>
Cc:     <davem@davemloft.net>, <edumazet@google.com>, <pabeni@redhat.com>,
        <lars.povlsen@microchip.com>, <Steen.Hegelund@microchip.com>,
        <daniel.machon@microchip.com>, <UNGLinuxDriver@microchip.com>,
        <netdev@vger.kernel.org>, <linux-arm-kernel@lists.infradead.org>,
        <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] net: microchip: sparx5: Fix missing destroy_workqueue
 of mact_queue
Message-ID: <20221202205907.39eabc1c@kernel.org>
In-Reply-To: <20221201134717.25750-1-linqiheng@huawei.com>
References: <20221201134717.25750-1-linqiheng@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI,
        SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, 1 Dec 2022 21:47:17 +0800 Qiheng Lin wrote:
> The mchp_sparx5_probe() won't destroy workqueue created by
> create_singlethread_workqueue() in sparx5_start() when later
> inits failed. Add destroy_workqueue in the cleanup_ports case,
> also add it in mchp_sparx5_remove()

This is a fix so it needs a Fixes tag.