Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp3292768rwb; Sat, 3 Dec 2022 02:26:45 -0800 (PST) X-Google-Smtp-Source: AA0mqf6gzhencyhqIVVuaPvrJjX+rHyCsxPvppjCnb/weGMAU/zz6/MigbT8cu8UCv6RamuJRm1N X-Received: by 2002:a17:90b:3c0a:b0:212:510b:5851 with SMTP id pb10-20020a17090b3c0a00b00212510b5851mr77943371pjb.57.1670063205160; Sat, 03 Dec 2022 02:26:45 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1670063205; cv=none; d=google.com; s=arc-20160816; b=ZuOHiUvp/y0j4lUgcx8J2lDvdMj/rcN2JT7s+yM+z0kvh29PMUZBQr+NVLEJD5XhRV Yip5DxS4n7XWq7Ionb6N/Pt9QMdLNwsXHWvZt8LafpZfNXB1bHp6aQfeMeORtjfHHAZQ tUm2IeFpRqKfEJiAr1uyTAyPNY1BmQoxRh04KBJGiQuKv7C1SDVxP1dP9OE8+S3nZn3y qlKkdQkom9AfmzBjy/vG75zqN3YpLc2niLKW6Zm4Z1aMrhf1tor2tlEqi0IGCeBHSF+D hSX7wza7FGhTCl74v1gA3ddeF9Y83hXTUIonGj1w1Rd300bnA6SZk0cPj5q68h7nZHSS G9YQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=i8ivVIAR3Hl3GeEWDWKdonaWgssAeiZcW6ff920f8pY=; b=V/lYxftkVf+fyRFgkv7oF7BX1MsNiSVRDvve82hLuWtWDldFqQQfSfFufFV1yiecnd MVr8fjq9zap3vjk5sKaxt+YH7UhgYrrvnFJMPViMfUw7ge6yhOTF2k95Mx2q6Fv+GC0l YqgGarWiGB3FaAESCV98hY1UrLK0bwF8XOIXDkMEWa8ptAeQAqe4cMFMnfYjJhrU8B7+ cbFDlSE61gTlVjk8hFa0zYhu6jeQ03H/jV3WYK8lRHiDDGbeTe2gntAEIVJV7wKH6Ahd TDFwV/cIskuo038VA2cgGCUfQXWh07ytH9MLOLYHqXdAxtO0p6f9/rAcxHlMfmbfqS3U bPfw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=hfQ8Bub3; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id h189-20020a6253c6000000b0057500a7665dsi8813273pfb.272.2022.12.03.02.26.33; Sat, 03 Dec 2022 02:26:45 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=hfQ8Bub3; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229477AbiLCJwr (ORCPT + 82 others); Sat, 3 Dec 2022 04:52:47 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33884 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229475AbiLCJwp (ORCPT ); Sat, 3 Dec 2022 04:52:45 -0500 Received: from mail-yw1-x1129.google.com (mail-yw1-x1129.google.com [IPv6:2607:f8b0:4864:20::1129]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4A2071E1 for ; Sat, 3 Dec 2022 01:52:43 -0800 (PST) Received: by mail-yw1-x1129.google.com with SMTP id 00721157ae682-3e45d25de97so15768637b3.6 for ; Sat, 03 Dec 2022 01:52:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=i8ivVIAR3Hl3GeEWDWKdonaWgssAeiZcW6ff920f8pY=; b=hfQ8Bub3CUzpaUwsLlJWVhV4Xn5nzBGG1/DnqQG+CRPeGXn9mpgC1TDGqAA6rrjosF /mlluNdI8INwyW1rwUyQBrFDwJNXoXnbdmBzWHoNzRpOC9sRwFzoOxbkBc5EJZGsBRun 2cgSSTQ8HzNOKwD8RkrogNaf93VMcHqr5WcToBQmixPGhFCE3+TY2vnLCBwlb5Wsh9BH jQpzYYK7cUeVFVhmWnN+rJLljAhjK4j7BybHwq3CKAZIsGyJsdyklPartSA/fFDQBxOC QdDeK0ri2hxOd3F4Vk+0w4OjPLMS2wLYvlvNBWPUc5SFSCjlspDxiMV/pmyUARlYE/Gn w5nw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=i8ivVIAR3Hl3GeEWDWKdonaWgssAeiZcW6ff920f8pY=; b=n5GfCERJuzgcPYueRa2tu9PUazLWEZtUB5uoTH8t9TN3ROVuFRDhIQDICOQlE2JxhH AKGZfaqr3WZyjFTT2YrOckZDDsYQAKPxt35Nd2Ex/1pSY92oeoKA6ndybF/4ERPJIyfX Dq7bLZrvhfMSHHkizv5EADjOKoN8Qh32hMtGdVjEE64NsEbPEBXt5teOr2kX75M0xI3q SHLp/G4hdAnE7FSjzbRR+pM1vU8Y+QO4RpKXzh2HKoo4rB3BT0LESB/39DSa5/HcwQ6s ezkGyTnhKDcJAXpmBYEZLvryOwwZnlwg3jawRpe05Mbti2eIAvGNqkkn/6Tv81PjQOoP 5IdQ== X-Gm-Message-State: ANoB5plgvj+pMFFwWDz+D9Xb/KGsi55cFOea/HuXlov3xD6y013gqY6F ul5oibEKiEEKifKyNZGvANgTN1rVcfSIWmxTglSjeg== X-Received: by 2002:a81:3855:0:b0:38b:17c4:4297 with SMTP id f82-20020a813855000000b0038b17c44297mr54547195ywa.446.1670061162443; Sat, 03 Dec 2022 01:52:42 -0800 (PST) MIME-Version: 1.0 References: <1669704115-40011-1-git-send-email-wangyufen@huawei.com> In-Reply-To: <1669704115-40011-1-git-send-email-wangyufen@huawei.com> From: Linus Walleij Date: Sat, 3 Dec 2022 10:52:31 +0100 Message-ID: Subject: Re: [PATCH v2] USB: FHCI: fix error return code in of_fhci_probe() To: Wang Yufen Cc: gregkh@linuxfoundation.org, mailhol.vincent@wanadoo.fr, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 29, 2022 at 7:21 AM Wang Yufen wrote: > Fix to return a negative error code of PTR_ERR(fhci->gpiods[i]) > instead of 0. > > Fixes: a4efdb8a423b ("USB: FHCI: Switch to GPIO descriptors") > Signed-off-by: Wang Yufen Reviewed-by: Linus Walleij Yours, Linus Walleij